From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68463 invoked by alias); 25 Apr 2017 11:34:25 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 68448 invoked by uid 89); 25 Apr 2017 11:34:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR01-VE1-obe.outbound.protection.outlook.com Received: from mail-ve1eur01on0047.outbound.protection.outlook.com (HELO EUR01-VE1-obe.outbound.protection.outlook.com) (104.47.1.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 25 Apr 2017 11:34:22 +0000 Received: from VI1PR0802MB2621.eurprd08.prod.outlook.com (10.175.20.147) by VI1PR0802MB2351.eurprd08.prod.outlook.com (10.172.14.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1047.13; Tue, 25 Apr 2017 11:34:20 +0000 Received: from VI1PR0802MB2621.eurprd08.prod.outlook.com ([10.175.20.147]) by VI1PR0802MB2621.eurprd08.prod.outlook.com ([10.175.20.147]) with mapi id 15.01.1047.019; Tue, 25 Apr 2017 11:34:20 +0000 From: Wilco Dijkstra To: "Hurugalawadi, Naveen" , "Pinski, Andrew" CC: Kyrylo Tkachov , James Greenhalgh , nd , GCC Patches Subject: Re: [PING][PATCH][AArch64] Implement ALU_BRANCH fusion Date: Tue, 25 Apr 2017 11:39:00 -0000 Message-ID: References: ,,, In-Reply-To: authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; x-microsoft-exchange-diagnostics: 1;VI1PR0802MB2351;7:Yg451Eb4z+p8IY7h3L/0l1leS7fUoerSMWNBk6IK+LRF9kLKrky2Krl83Jjr0FRtQswM5iAIFoUllGy8SsTXOOfo51ImCFkRzfisxy/Mu/QBNLGQX7q4GObuU+m/SWo8zZauHRUJ6qMs3fHa335eiAW/9jjR6rl+mfvIR+R48Nvk4jhdBeVPzfY/BxEX4QBPz+oycbYTRZE8teXexkwZ05pW7opBiyT/yadjtxUU9dWjVqd9gC5LR9UPaTRm/TEfdAfgJb4Fl/tfQoHOGbi3qlGyoJTcUx1Q1ebX7jHsfuoDGIcZdQaXHronT7NJ1fw5XeOrStprTyMGC5VmBdkkyw== x-ms-office365-filtering-correlation-id: 440fd679-f507-4cfe-027c-08d48bcf03f5 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081)(201702281549075);SRVR:VI1PR0802MB2351; nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(22074186197030)(183786458502308); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041248)(20161123564025)(20161123560025)(20161123555025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(6072148);SRVR:VI1PR0802MB2351;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0802MB2351; x-forefront-prvs: 0288CD37D9 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(39400400002)(39410400002)(39840400002)(39450400003)(39860400002)(39850400002)(6306002)(4326008)(9686003)(6436002)(50986999)(54356999)(76176999)(77096006)(6506006)(2950100002)(25786009)(99286003)(8936002)(33656002)(2906002)(54906002)(81166006)(5660300001)(8676002)(3660700001)(3846002)(6116002)(2900100001)(102836003)(93886004)(3280700002)(55016002)(53936002)(7696004)(66066001)(74316002)(229853002)(7736002)(38730400002)(6246003)(305945005)(122556002)(86362001)(189998001);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0802MB2351;H:VI1PR0802MB2621.eurprd08.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Apr 2017 11:34:20.3159 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2351 X-SW-Source: 2017-04/txt/msg01163.txt.bz2 Hi Naveen, > https://gcc.gnu.org/ml/gcc-patches/2017-03/msg01369.html Same comment for this part, we want to return true if we match: + if (SET_DEST (curr_set) !=3D (pc_rtx) + || GET_CODE (SET_SRC (curr_set)) !=3D IF_THEN_ELSE + || ! REG_P (XEXP (XEXP (SET_SRC (curr_set), 0), 0)) + || ! REG_P (SET_DEST (prev_set)) + || REGNO (SET_DEST (prev_set)) + !=3D REGNO (XEXP (XEXP (SET_SRC (curr_set), 0), 0))) + return false; Note writing these complex conditions using positive logic makes them much more readable - if you have to negate use !(X && Y && Z) rather than !X || = !Y || !Z. Wilco =A0=A0=A0=20=20=20=20=20