From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on2051.outbound.protection.outlook.com [40.107.14.51]) by sourceware.org (Postfix) with ESMTPS id 6D96A3858C39 for ; Tue, 9 Jan 2024 16:10:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6D96A3858C39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6D96A3858C39 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.14.51 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1704816611; cv=pass; b=W9KCsoI42zr7ELSX3u3gHHdl3GCoj7NMQoESZ0mY3ndRYj9qjeEKh3GXtdouBllOTH30b23u5WVnzgwn+RikrdDUtXpMpVzK+IsNy7afj8VN/mo7nlcvZj+gJ7YmTqwHRTTX1w3yvF2CwuYCkzcF0Yvj0+SfZD9J+Dm1NrNe5XQ= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1704816611; c=relaxed/simple; bh=j/DQ46YKqOgZd9Jq9KhH0R8GrmA27hNzNmce1WOFRGo=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=BRYiX3gjuY29lGiok/sAYcniqPOrS0NYHnp58AvVPfUDQ4jmZ32SBmF+HotYcR85J1yfVd5z/dgDeF40Xg1so9lS4OP/uL1dJYS8RgwYn+Gn3hOH5dLQd95KVHqVpEIF4EuBBpH4ZYXAm6UyWb2f8bbjJ0Mz22aoPW/mOhY73B8= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=hO/Z1rFMF+2bZM4kE74KjikEpxM7Ko/rRV74441ZD3V4iOy+SzSh+lSgG1n91Vi65MK18sgUZtvuKEOwJws5PMflfdTkG+nPTKveGxdHnwBcIWMcnYDCbn0+9RcwBg7oilzHcs9XMrbxUGOatoVM9UF2Jh+qbFDEg+oX2ZsJig6ZO1HRgk2ptjBRJwafbDzc1l5fBfWnzg0b5JssG6/9l9zY/MIt5RCZBc0Wb48IkuTU6hQTcpwuPaUSpQi1Be8d1eaVBSvbry+3fFWRIPcjerWWeUC6HcxwruGuKtaLjyl7Kl7d9vVDbJ00IQ1ncSXZMwNnvSqVeDXYk5uH0O+VFQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ctjzJ4igk6AzSt929I7Qr0f6iTizT7TvTdO6wuiKXSc=; b=mORFGN1t97m/ZLFswoBxzAZQSK0fN7OR9hkQvdvlyZmBUV/t/G+Q5U3gueNd5xoSZviWWII0m55eFlNfDv87Y1DMV1Bg19CrYQeQ+STrBSBXafATTjj8M1YcbD4b/53zbj2PPxIdhLvlrtEkfFJ4VCjWt0d0aupryhnD5MzkioDbjTsGDKjBzcMh/MtNJVahGESDoVpyeYZUPQcVJx6fkOHCoqwUzEKFnPEx7k87+RCrLvkSjS9HR36bsuRRWfL13oUmOvt6BkNqnnHDA/9x9M7HYKBp15s/J5DPxDoZzhXA/E73Rr0jp0XQXRFxx5x4j5Y46+eVvEwnWmfqg5udCg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ctjzJ4igk6AzSt929I7Qr0f6iTizT7TvTdO6wuiKXSc=; b=4oWwujJ9A9oxwcSujh9N37DBAUotCZRy2rNa1VL5ubMitOP7EMQRcetpFKcs423AyGulBJ3J/OuaRzb+xdnK0hAZbSNIOtvtGiLPoNEbUe16kJlaJSQG6AWxkQ8gmFcCcg/150uVq7Qh+3rNg5ekMMooOTwqnJfm37tyWIkmVW8= Received: from DUZP191CA0009.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:4f9::17) by AS8PR08MB6600.eurprd08.prod.outlook.com (2603:10a6:20b:33e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.23; Tue, 9 Jan 2024 16:10:03 +0000 Received: from DB1PEPF00039233.eurprd03.prod.outlook.com (2603:10a6:10:4f9:cafe::dd) by DUZP191CA0009.outlook.office365.com (2603:10a6:10:4f9::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.23 via Frontend Transport; Tue, 9 Jan 2024 16:10:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB1PEPF00039233.mail.protection.outlook.com (10.167.8.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.14 via Frontend Transport; Tue, 9 Jan 2024 16:10:03 +0000 Received: ("Tessian outbound 52fd419df13e:v239"); Tue, 09 Jan 2024 16:10:02 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 8b81a1594276d2bf X-CR-MTA-TID: 64aa7808 Received: from 9c62841ce602.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E467D88C-4FED-445C-916D-42802201E102.1; Tue, 09 Jan 2024 16:09:56 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9c62841ce602.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 09 Jan 2024 16:09:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G/NXigZbbFUs1LyPLOwiYIRcc9lOPWnszMfyWXYSW0Tum89z1PKmPY0Y/kACo+fpCftlZUQ/3XuRlS98oz6XZd5vtNWzpUIQPeWu1kCntrpYRv68/v2MIbT9O41a2/U/TzeDcZU3JvrelrKpmR9cPyKksySKh6jYphMXRAR3ssh+YT610YxDL0Ow6Uf2KS4eisK6WxOznHdN15FSzd3f7PFEmt4BPI/E3E7CjqaouV70/A61JxJjaO8alj/jTSNga7adWSIuUryLARyNyzBK9nRQQynqCKvqdvW3qskzIuLRu2xEfdNa+5NG3HyH0Mv9mgtrIFisna8xVIolfybFiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ctjzJ4igk6AzSt929I7Qr0f6iTizT7TvTdO6wuiKXSc=; b=hvZ0QDlFI5r/KTBDfSRcBTyHbJAD7FNCzRr2TeU4vxHuul04N4d7+r0ZRzrtrc9Nmud26gdUME7MxAJfcc+weAhZLLoHihptDq5YIRdJaGR5glK4mYiFbd5AEs1fbjFHu8ZfGNbmrvcpvcK8No8qAtakQWdciXhJwK6NQgDv5b6Gmxto5xykW/+4//hPPJoMPGoKYczqIVPhIqCtIuw98Q7LBp4OSTcZg2cI3nf8oRm6SNirq+0+o3mS/Nkx6ILnCC7Kbu+ShIEkZjYkNtnHvkWZkHHGeB6chPDDNVJBZPYdv1j3ngJ0YLLOybbodJ1yLKHl3RL3ccyNvPl0m3MIuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ctjzJ4igk6AzSt929I7Qr0f6iTizT7TvTdO6wuiKXSc=; b=4oWwujJ9A9oxwcSujh9N37DBAUotCZRy2rNa1VL5ubMitOP7EMQRcetpFKcs423AyGulBJ3J/OuaRzb+xdnK0hAZbSNIOtvtGiLPoNEbUe16kJlaJSQG6AWxkQ8gmFcCcg/150uVq7Qh+3rNg5ekMMooOTwqnJfm37tyWIkmVW8= Received: from VI1PR08MB5325.eurprd08.prod.outlook.com (2603:10a6:803:13e::17) by DU0PR08MB7414.eurprd08.prod.outlook.com (2603:10a6:10:352::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.23; Tue, 9 Jan 2024 16:09:54 +0000 Received: from VI1PR08MB5325.eurprd08.prod.outlook.com ([fe80::9679:2ab0:99c6:54a3]) by VI1PR08MB5325.eurprd08.prod.outlook.com ([fe80::9679:2ab0:99c6:54a3%6]) with mapi id 15.20.7159.020; Tue, 9 Jan 2024 16:09:53 +0000 From: Tamar Christina To: Rainer Orth , Richard Biener CC: "gcc-patches@gcc.gnu.org" , nd , "jlaw@ventanamicro.com" Subject: RE: [PATCH]middle-end: check if target can do extract first for early breaks [PR113199] Thread-Topic: [PATCH]middle-end: check if target can do extract first for early breaks [PR113199] Thread-Index: AQHaPaUibSSEU0sWh0KFm1jT8FPWKrDP5oMAgAGAjlCAAAaIgIAAQruggAAA0HA= Date: Tue, 9 Jan 2024 16:09:53 +0000 Message-ID: References: <472o65so-2n1q-s6pn-0os5-s2o22npso06o@fhfr.qr> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: VI1PR08MB5325:EE_|DU0PR08MB7414:EE_|DB1PEPF00039233:EE_|AS8PR08MB6600:EE_ X-MS-Office365-Filtering-Correlation-Id: bbe56a5d-9211-4c3c-1ccf-08dc112d7016 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: GfHsxhOKkv13Wy++aC8bIgxSjjZhMoKA+NggakcJlWnlC8odnaDxj8zWGkhK82FB6QCrOWPYz0jOsf6sKz7eH/W3/yQKgMXIsdQA0WOZPHzGwjvY3wfJlGkC+BUkuUiEAmuggsRHv4nSYVgI5zvR8K1yyomCL4F8SgyfnnSq9/I7UiSR3i0ikguSogVsNqaUwAwn0mcTLafZ4st9pXjgvs8LStP7NM8lblhsgsvIUJ0zeuc0piXpp4LU4UnC2+3FYRzZ6rvzAJx5HBSE7EyUc94asgVp0OlIyuuSUlMlJ25ro1cSEjAjWDXafgl9baAYeN0OsH/ryG5G0f6yYFCy283sS5nYceD9DO9FHAkMWnhXsPtQ3xfdUQkLM0FxIlcid+n3h7Dbu5gSqwixZstzYxoVglorviPuk/dUjkonevy1TQ0/MLsC33JDxmB5Axo9Mc+Bp7guStf1s3bf3c/jwhhJt0Ok6M0xb3N1gvjLMXpf7KJy6o9c/aBGfVKt5iXaMf7hRU8aHgBApH6hii2Ph59Q8banGYLis7xpP5ebC5jVdtoe1Kw5C3wq4nC4U/WZdZuZXAViU9mmwro7jA5hoCRwss10WlBwNx/xL7E3was= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB5325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(396003)(39860400002)(136003)(376002)(346002)(230922051799003)(64100799003)(1800799012)(186009)(451199024)(52536014)(4326008)(8676002)(8936002)(55016003)(64756008)(54906003)(76116006)(66476007)(66556008)(66946007)(316002)(66446008)(110136005)(33656002)(122000001)(38100700002)(38070700009)(86362001)(71200400001)(6506007)(26005)(7696005)(9686003)(478600001)(53546011)(5660300002)(41300700001)(2906002)(83380400001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7414 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB1PEPF00039233.eurprd03.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 08110411-638f-4cf2-3677-08dc112d6a92 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +F8z4IncxXuQDMXiPhX3DFOMItFnAEUzENm7p7gy6Cllgei7UmT2ezxYpy2gRN+Vi8tI9iZ5GhkpTKhkl/ljv6esw33Bi80sV64ZNv68BMlajQNoeYfy8WPU/A1+OOs9qn1tgC6QUzQVxcEaa/M7dyKvUBfNYLzJ44MBT5FbfzyHr4auwYeKFTx2XblI3eb0i3cJ1yRx6/Vb02ze7BOcgMD4/d0Yzh2KoY62cIEzD0sWdicpYwN+aXhBjKP3d78T8II2YmxDElGxnrc57aRzEbeS3VTo4yjY2Aq7dXJwFNZ9AWHpWn+6cESChgzOqWnl3E6mYrniX8obo6LWUdRTlxTF8MVGh42IyUyDuSjDShM3VFQLZrHZHhFSJDTZftfT1uBFODUn9pbUgn1va2/mcqUxdsUDWQMgR7NPQpPaIdqrNkssyR3rYvbyztXbm0UzHIwAEmIHBNKvXjH5z5RjV1tNs5OQDnz/EDULeGXANNoDcBlIgLyhNGtnoRx5axLTjPB0gkeCyRPG4Lgg/4/5xwHi08InKpcJIZA+oOP6JRm10dzoAED/gLdNKIoPvx7IHs1k366T/Woc66RWi8KJ4E70eTLkrHV5TlJ+xQiP4AAeWmZbvyfohwVP4m/hYP4kZ0Btcnl/J2j9d2kuiqRcXApup5ywlO6M1/DYS8AgL/oiWJDqwrkp8vnO+Wkz/6lFUS9FFXNI91j1n0YY5gEXeQ1s4qe3fFCTCTr8fN+mUsE= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(4636009)(346002)(396003)(376002)(136003)(39860400002)(230922051799003)(82310400011)(451199024)(64100799003)(1800799012)(186009)(46966006)(40470700004)(36840700001)(82740400003)(36860700001)(356005)(81166007)(53546011)(7696005)(6506007)(2906002)(478600001)(70586007)(70206006)(8676002)(54906003)(8936002)(316002)(110136005)(4326008)(9686003)(5660300002)(41300700001)(47076005)(336012)(107886003)(26005)(83380400001)(33656002)(40480700001)(52536014)(86362001)(40460700003)(55016003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2024 16:10:03.1465 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bbe56a5d-9211-4c3c-1ccf-08dc112d7016 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF00039233.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6600 X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hmm I'm confused as to why It didn't break mine.. just did one again.. anyw= ay I'll remove the unused variable. > -----Original Message----- > From: Rainer Orth > Sent: Tuesday, January 9, 2024 4:06 PM > To: Richard Biener > Cc: Tamar Christina ; gcc-patches@gcc.gnu.org; n= d > ; jlaw@ventanamicro.com > Subject: Re: [PATCH]middle-end: check if target can do extract first for = early breaks > [PR113199] >=20 > Richard Biener writes: >=20 > > On Tue, 9 Jan 2024, Tamar Christina wrote: > > > >> > > - > >> > > - gimple_seq_add_seq (&stmts, tem); > >> > > - > >> > > - scalar_res =3D gimple_build (&stmts, CFN_EXTRACT_LAST, scal= ar_type, > >> > > - mask, vec_lhs_phi); > >> > > + scalar_res =3D gimple_build (&stmts, CFN_VEC_EXTRACT, TREE_TYPE > >> > (vectype), > >> > > + vec_lhs_phi, bitstart); > >> > > >> > So bitstart is always zero? I wonder why using CFN_VEC_EXTRACT over > >> > BIT_FIELD_REF here which wouldn't need any additional target support= . > >> > > >> > >> Ok, how about... > >> > >> --- > >> > >> I was generating the vector reverse mask without checking if the targe= t > >> actually supported such an operation. > >> > >> This patch changes it to if the bitstart is 0 then use BIT_FIELD_REF i= nstead > >> to extract the first element since this is supported by all targets. > >> > >> This is good for now since masks always come from whilelo. But in the= future > >> when masks can come from other sources we will need the old code back. > >> > >> Bootstrapped Regtested on aarch64-none-linux-gnu, x86_64-pc-linux-gnu > >> and no issues with --enable-checking=3Drelease --enable-lto > >> --with-build-config=3Dbootstrap-O3 --enable-checking=3Dyes,rtl,extra. > >> tested on cross cc1 for amdgcn-amdhsa and issue fixed. > >> > >> Ok for master? > > > > OK. > > > >> Thanks, > >> Tamar > >> > >> gcc/ChangeLog: > >> > >> PR tree-optimization/113199 > >> * tree-vect-loop.cc (vectorizable_live_operation_1): Use > >> BIT_FIELD_REF. >=20 > This patch broke bootstrap (everywhere, it seems; seen on > i386-pc-solaris2.11 and sparc-sun-solaris2.11): >=20 > /vol/gcc/src/hg/master/local/gcc/tree-vect-loop.cc: In function 'tree_nod= e* > vectorizable_live_operation_1(loop_vec_info, stmt_vec_info, basic_block, = tree, int, > slp_tree, tree, tree, tree, tree, bool, gimple_stmt_iterator*)': > /vol/gcc/src/hg/master/local/gcc/tree-vect-loop.cc:10598:52: error: unuse= d > parameter 'restart_loop' [-Werror=3Dunused-parameter] > 10598 | tree lhs_type, bool restart_loop, > | ~~~~~^~~~~~~~~~~~ >=20 > Rainer >=20 > -- > -------------------------------------------------------------------------= ---- > Rainer Orth, Center for Biotechnology, Bielefeld University