From: Tamar Christina <Tamar.Christina@arm.com>
To: Richard Biener <rguenther@suse.de>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: RE: [PATCH] Remove -save-temps from tests using -flto
Date: Mon, 19 Jun 2023 10:50:26 +0000 [thread overview]
Message-ID: <VI1PR08MB53253D697388E5AED6C28CB2FF5FA@VI1PR08MB5325.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <nycvar.YFH.7.77.849.2306191018090.4723@jbgna.fhfr.qr>
> -----Original Message-----
> From: Richard Biener <rguenther@suse.de>
> Sent: Monday, June 19, 2023 11:19 AM
> To: Tamar Christina <Tamar.Christina@arm.com>
> Cc: gcc-patches@gcc.gnu.org
> Subject: RE: [PATCH] Remove -save-temps from tests using -flto
>
> On Mon, 19 Jun 2023, Tamar Christina wrote:
>
> > > -----Original Message-----
> > > From: Richard Biener <rguenther@suse.de>
> > > Sent: Monday, June 19, 2023 7:28 AM
> > > To: gcc-patches@gcc.gnu.org
> > > Cc: Tamar Christina <Tamar.Christina@arm.com>
> > > Subject: [PATCH] Remove -save-temps from tests using -flto
> > >
> > > The following removes -save-temps that doesn't seem to have any good
> > > reason from tests that also run with -flto added. That can cause
> > > ltrans files to race with other multilibs tested and I'm frequently
> > > seeing linker complaints that the architecture doesn't match here.
> > >
> > > I'm not sure whether the .ltrans.o files end up in a non gccN/
> > > specific directory or if we end up sharing the same dir for
> > > different multilibs (not sure if it's easily possible to avoid that).
> > >
> > > Parallel testing on x86_64-unknown-linux-gnu in progress.
> > >
> > > Tamar, was there any reason to use -save-temps here?
> >
> > At the time I was getting unresolved errors from these without it.
> > But perhaps that's something to do with dejagnu versions?
>
> I don't know. Can you check if there's an issue on your side when removing -
> save-temps?
Nope no issues, all tests still pass.
Regards,
Tamar
>
> Richard.
>
> > Tamar
> >
> > >
> > > * gcc.dg/vect/vect-bic-bitmask-2.c: Remove -save-temps.
> > > * gcc.dg/vect/vect-bic-bitmask-3.c: Likewise.
> > > * gcc.dg/vect/vect-bic-bitmask-4.c: Likewise.
> > > * gcc.dg/vect/vect-bic-bitmask-5.c: Likewise.
> > > * gcc.dg/vect/vect-bic-bitmask-6.c: Likewise.
> > > * gcc.dg/vect/vect-bic-bitmask-8.c: Likewise.
> > > * gcc.dg/vect/vect-bic-bitmask-9.c: Likewise.
> > > * gcc.dg/vect/vect-bic-bitmask-10.c: Likewise.
> > > * gcc.dg/vect/vect-bic-bitmask-11.c: Likewise.
> > > ---
> > > gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-10.c | 2 +-
> > > gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-11.c | 2 +-
> > > gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-2.c | 2 +-
> > > gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-3.c | 2 +-
> > > gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-4.c | 2 +-
> > > gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-5.c | 2 +-
> > > gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-6.c | 2 +-
> > > gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-8.c | 2 +-
> > > gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-9.c | 2 +-
> > > 9 files changed, 9 insertions(+), 9 deletions(-)
> > >
> > > diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-10.c
> > > b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-10.c
> > > index e9ec9603af6..e6810433d70 100644
> > > --- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-10.c
> > > +++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-10.c
> > > @@ -1,6 +1,6 @@
> > > /* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } }
> > > */
> > > /* { dg-do run } */
> > > -/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" }
> > > */
> > > +/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
> > >
> > > #include <stdint.h>
> > >
> > > diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-11.c
> > > b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-11.c
> > > index 06c103d3885..f83078b5d51 100644
> > > --- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-11.c
> > > +++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-11.c
> > > @@ -1,6 +1,6 @@
> > > /* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } }
> > > */
> > > /* { dg-do run } */
> > > -/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" }
> > > */
> > > +/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
> > >
> > > #include <stdint.h>
> > >
> > > diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-2.c
> > > b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-2.c
> > > index 059bfb3ae62..e33a824df07 100644
> > > --- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-2.c
> > > +++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-2.c
> > > @@ -1,6 +1,6 @@
> > > /* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } }
> > > */
> > > /* { dg-do run } */
> > > -/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" }
> > > */
> > > +/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
> > >
> > > #include <stdint.h>
> > >
> > > diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-3.c
> > > b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-3.c
> > > index 059bfb3ae62..e33a824df07 100644
> > > --- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-3.c
> > > +++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-3.c
> > > @@ -1,6 +1,6 @@
> > > /* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } }
> > > */
> > > /* { dg-do run } */
> > > -/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" }
> > > */
> > > +/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
> > >
> > > #include <stdint.h>
> > >
> > > diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-4.c
> > > b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-4.c
> > > index 91b82fb5988..8895d5c263c 100644
> > > --- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-4.c
> > > +++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-4.c
> > > @@ -1,6 +1,6 @@
> > > /* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } }
> > > */
> > > /* { dg-do run } */
> > > -/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" }
> > > */
> > > +/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
> > >
> > > #include <stdint.h>
> > >
> > > diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-5.c
> > > b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-5.c
> > > index 59f339fb8c5..77d4deb633c 100644
> > > --- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-5.c
> > > +++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-5.c
> > > @@ -1,6 +1,6 @@
> > > /* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } }
> > > */
> > > /* { dg-do run } */
> > > -/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" }
> > > */
> > > +/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
> > >
> > > #include <stdint.h>
> > >
> > > diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-6.c
> > > b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-6.c
> > > index 84df8371be5..7930346a602 100644
> > > --- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-6.c
> > > +++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-6.c
> > > @@ -1,6 +1,6 @@
> > > /* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } }
> > > */
> > > /* { dg-do run } */
> > > -/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" }
> > > */
> > > +/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
> > >
> > > #include <stdint.h>
> > >
> > > diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-8.c
> > > b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-8.c
> > > index b3e0b5ba92f..1af7104a37d 100644
> > > --- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-8.c
> > > +++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-8.c
> > > @@ -1,6 +1,6 @@
> > > /* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } }
> > > */
> > > /* { dg-do run } */
> > > -/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" }
> > > */
> > > +/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
> > >
> > > #include <stdint.h>
> > >
> > > diff --git a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-9.c
> > > b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-9.c
> > > index 5fcde11ad4e..f0a75604bcb 100644
> > > --- a/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-9.c
> > > +++ b/gcc/testsuite/gcc.dg/vect/vect-bic-bitmask-9.c
> > > @@ -1,6 +1,6 @@
> > > /* { dg-skip-if "missing optab for vectorization" { sparc*-*-* } }
> > > */
> > > /* { dg-do run } */
> > > -/* { dg-additional-options "-O3 -save-temps -fdump-tree-dce -w" }
> > > */
> > > +/* { dg-additional-options "-O3 -fdump-tree-dce -w" } */
> > >
> > > #include <stdint.h>
> > >
> > > --
> > > 2.35.3
> >
>
> --
> Richard Biener <rguenther@suse.de>
> SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461
> Nuernberg, Germany; GF: Ivo Totev, Andrew Myers, Andrew McDonald,
> Boudien Moerman; HRB 36809 (AG Nuernberg)
next prev parent reply other threads:[~2023-06-19 10:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bd7c5e8e-5ef1-4ca2-b83a-7abec21b2cf2@DBAEUR03FT015.eop-EUR03.prod.protection.outlook.com>
2023-06-19 9:59 ` Tamar Christina
2023-06-19 10:18 ` Richard Biener
2023-06-19 10:50 ` Tamar Christina [this message]
2023-06-19 11:19 ` Richard Biener
2023-06-19 6:28 Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR08MB53253D697388E5AED6C28CB2FF5FA@VI1PR08MB5325.eurprd08.prod.outlook.com \
--to=tamar.christina@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).