From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2067.outbound.protection.outlook.com [40.107.249.67]) by sourceware.org (Postfix) with ESMTPS id AA8903858D33 for ; Mon, 27 Nov 2023 08:22:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AA8903858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AA8903858D33 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.249.67 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1701073365; cv=pass; b=HkbPGk0XWkjAQINWstjjSGwKAsLZVMfmpJ/3z4G8PUy0jjekY9h/yJqMRCab+71KP6aersRHdpXCiJ5khd0YdsFn0cic0M2xQh9CpZ+/Dxl1HyqlAkOcXumrKw9gbtAIWY+fGNgJbN+RyFk1q3gZsH0YNWetV8JSs54NhA0QpPo= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1701073365; c=relaxed/simple; bh=61M1MH6LTn/fZjq5p+6cv54wo4FclV/nUVp60E7bh5A=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=k6OA080d9rJLOsFU9UvYkIla+OY7kaK/15Krvo4mOOxZpdKY8uNHB5VDYEyjw0VkZ3o3aMeZ/uU+b9C38JCVgRb6SiZpAG5VRjtCWCKkuijSQ3LWLkkzonVrOcLgSuq0ZHBPTONDhudjq7lLvJuOINj1AQPtdC3GLVf/QXndhLk= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=RFwpoof17CRkO/v0Bj4futALSNJkMlAsPnMBg86ZyJOnqi7/3996a0fFYlfLsiqfBBbw00Lar1GVOUCbBtYG/rRXzauq3vRBGNC0TGSDOAp7f3lkC7dJALwW61sZeav6bzFi7CCVLDgGlOgvlNkpgsG5B8rnaQUWcgoHbDHX6Ol1lrrFWXZnyczkc/bFHbfjzdKiu43Rieix2Tt00Wn/LUl7RyGtgamce4t41j6GMB5rwonXHemCmx6Ny0OS2QopNL9/qW2Wlx+9PxYcDu2uFLMqGqBL/nUNPxqQz3SyVpjMp4qtXgY0XmwNBTYJYHgOFdiuYl5dderOtg+VdJUk1A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PMcVqlZqgfkHxi6Pd3zDi0s4DvM2bGC0ayFH19zQ6DA=; b=biL7+Ut2snNfs0Jr+3AAjrugPevu7tfdhISxkDuecToo168PJWki/GpXGdesqWAQ5FQ3YOlRRJg369ThOKlgXmZ0pJequtbkkcdsRRSfrabpnx57J0wxAm2IjKZZ4Gu2mFgs7G33nlz3uBnCui2NpihVr4sJpvuxvLf3wDKoGKocXuEIwEguDluaquyf2ixrb82W9suUl9A0MNDl391lZedRu988ieaFlA1veXNIlZ+NWJ0xqNuk/lRdNQ1PuSDV/x51iAnyIvSASP6wmXRBYUPILgCCRm+OqaShCkY7SSPoyCc3z+EhLzLZuq67Q3y/RZnHfh7xReLOTXrlpDEmFw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PMcVqlZqgfkHxi6Pd3zDi0s4DvM2bGC0ayFH19zQ6DA=; b=6FxI7WXH49qoI3sl6bmFUYB3XscLRYoQwXGqV9OSGVrrbijCd/m1ufjim6F3KdSxG71DYZ69Ar71of5rWhz6ZHbAlG+nOXuZgxpzD+EUoZyA98lbyUyYVyphP8Kp1xcbDGs0eY2bqAccYFLqMI3fE1Pko+c7zGS7Ve4hsMN8p8U= Received: from DU2PR04CA0063.eurprd04.prod.outlook.com (2603:10a6:10:232::8) by PA4PR08MB6093.eurprd08.prod.outlook.com (2603:10a6:102:e8::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.27; Mon, 27 Nov 2023 08:22:36 +0000 Received: from DB5PEPF00014B9D.eurprd02.prod.outlook.com (2603:10a6:10:232:cafe::d8) by DU2PR04CA0063.outlook.office365.com (2603:10a6:10:232::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.25 via Frontend Transport; Mon, 27 Nov 2023 08:22:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5PEPF00014B9D.mail.protection.outlook.com (10.167.8.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.17 via Frontend Transport; Mon, 27 Nov 2023 08:22:36 +0000 Received: ("Tessian outbound 7671e7ddc218:v228"); Mon, 27 Nov 2023 08:22:36 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 921ef99216d00294 X-CR-MTA-TID: 64aa7808 Received: from c2a30bdfd2f4.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 26BB76A5-1DD2-4554-B29B-30DF595D0232.1; Mon, 27 Nov 2023 08:22:30 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c2a30bdfd2f4.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 27 Nov 2023 08:22:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lZOYKap0ijuLpzcXmY4WVfH5o8pwzSrJu85mEmMBPstqBEB9dYDmbA4FPLjfXofY3neRTivGzjf//mBXZRuOBTONE72cIFMGoOsKo2BDH8wpgHD2BBs3ko+/MxWL2cDOiEzHryxnagWhnSzeQRVYaDN9SgVm7HsoJL97Cm1GiGOHhdnRg4Qgf8FmJu81s+WLu6donqL7wKtA1Zb892eKx3vstvWQeFkTalEMSzn76CXALz7lV6TVe9pn4Re2RLeQFA2b5Z8/QzrhezKmomrd7sdtM8dDpA/a7KgGlmWBTUhTkk9i90UDeTBX7FPscwBsERiVdHWguLDcN8+BIzLJfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PMcVqlZqgfkHxi6Pd3zDi0s4DvM2bGC0ayFH19zQ6DA=; b=Y1rH+JHFhMPc3sWPPYhXCHW5PiYlSFyPABFDb2NWaiLh7EtIkfy6xfug3/G3ov7fRdb7IyoMuis7I6QJGYmdNf3u4jPK98CE3wLGi7p0nNI5MQflE+WA0UrE8+Pwr/GwlMqk80plvvm34anS7y5pGFsg08TKbO1swD/wHvgK0b8nZmFm/Gi4DpFbcTTJPEmfaqQr6dor4xCxzk5nqeOzDsII8KWSa9py31Dxa35NOpyQfNAdan2HuxOwFVVJ6SAAECp9/as1ZAfSv0Gqs4VZnFlwMSYXL/XbKd9NuHdAFI4wwxzYQ5v/8npfvrHNtcv3Stph3P4+BQLSC8JNcfiDmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PMcVqlZqgfkHxi6Pd3zDi0s4DvM2bGC0ayFH19zQ6DA=; b=6FxI7WXH49qoI3sl6bmFUYB3XscLRYoQwXGqV9OSGVrrbijCd/m1ufjim6F3KdSxG71DYZ69Ar71of5rWhz6ZHbAlG+nOXuZgxpzD+EUoZyA98lbyUyYVyphP8Kp1xcbDGs0eY2bqAccYFLqMI3fE1Pko+c7zGS7Ve4hsMN8p8U= Received: from VI1PR08MB5325.eurprd08.prod.outlook.com (2603:10a6:803:13e::17) by PAVPR08MB8967.eurprd08.prod.outlook.com (2603:10a6:102:326::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.27; Mon, 27 Nov 2023 08:22:28 +0000 Received: from VI1PR08MB5325.eurprd08.prod.outlook.com ([fe80::9679:2ab0:99c6:54a3]) by VI1PR08MB5325.eurprd08.prod.outlook.com ([fe80::9679:2ab0:99c6:54a3%6]) with mapi id 15.20.7025.022; Mon, 27 Nov 2023 08:22:28 +0000 From: Tamar Christina To: Jakub Jelinek CC: Xi Ruoyao , Segher Boessenkool , David Edelsohn , "gcc-patches@gcc.gnu.org" , Andrew Pinski Subject: RE: [PATCH] rs6000: Canonicalize copysign (x, -1) back to -abs (x) in the backend [PR112606] Thread-Topic: [PATCH] rs6000: Canonicalize copysign (x, -1) back to -abs (x) in the backend [PR112606] Thread-Index: AQHaH4iwUQDxFdH7Eky0DHd/Y+6ZsrCK2TsAgAAS2oCAAAU+AIAC3RWggAAFgQCAAAEJAA== Date: Mon, 27 Nov 2023 08:22:28 +0000 Message-ID: References: <60b5367881c834d1b0f7377a4f352c7c512e2d37.camel@xry111.site> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: VI1PR08MB5325:EE_|PAVPR08MB8967:EE_|DB5PEPF00014B9D:EE_|PA4PR08MB6093:EE_ X-MS-Office365-Filtering-Correlation-Id: 85d734bf-f31e-4608-ae50-08dbef220357 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: CVQRdl4QirKfJ6/5T91BnaXse0qERyCHF4BEfGyvteb8CxNFRrBfdzq+yRO/a0wPW2p+0npGkYVcRvEXGZy00T3WxptgZsTo5yIy/ElGLqaO2wRlVxc3GpJ+XVvT3oLZ/T/UgM4cLR8j1d88kPCkDjGZ+WtqFSHV9rDlYcFiqi8XVOHELGWoRSz549wBvyl4M+wydxwZuVADm+LYNpd9PgjjPe6vnMPAfQjIqyOq0FSAGXAliSXwE/SlLReYWubSKy1NBBa9Zl1sM78jdpEskLRs7iCivvVwRgFTW+DgDDP1Th7DMhi+m+5AbUXPeCX5UpvQhLJlDEViWQpfMNsKNQ+Q47ScSk0JDb7b1rVbGM8GCrEtWW+EfaZyHFw74zl360ouEQkAL6ZHrjeBW2tZwEASlcOlV7rJiWWmRZ2ls41BdziSGOgLpxS+QwhXQgugHdgfiYHVLKHAyqXGW4dS+xbpkRZ5PdFS8hwDi47Dhd4MVZXPgPwXSgd96wqj30h8M3sK+uzN+uoDOvkJb66euAlvy0BmJ9cQWM/uLHLjxFO5BThCroncb6W6Ypnbu88WuCV2yX3LdJlLxKN/0zq91rc9p1ESH6GMuz2+J90Za5Y= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB5325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376002)(346002)(366004)(39860400002)(396003)(136003)(230922051799003)(64100799003)(1800799012)(451199024)(186009)(38100700002)(41300700001)(33656002)(38070700009)(122000001)(2906002)(55016003)(83380400001)(5660300002)(66446008)(26005)(86362001)(66476007)(9686003)(53546011)(7696005)(6506007)(71200400001)(8936002)(8676002)(52536014)(4326008)(478600001)(966005)(64756008)(66556008)(66946007)(76116006)(316002)(6916009)(54906003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB8967 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5PEPF00014B9D.eurprd02.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ac3992cd-d1ac-4ffb-7729-08dbef21fe77 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +01K2LGFrCT42n2bECmGwKtJDS5heOL7hCkfmPWxK6lb5fdlh5Qa1ki+XP8cEDbmMTdwu6fVBBuEaj0frtSRj7+VJ982o7IRNGkairpROpzK+CIHnHRR6p4AovETjiM4Ziu38wsr7N0JF/8VTLnzyGrpBjk2qdkUvXjuYiKqMNr0tepnhAg3fppX1GveYtdgfEcJy9vAiZa5VOE6BitWNX1pvzOIO4zVH6jcN0mestemoYFm8cgzXv3ikfwyXnGNGRqp5ZdhQLbqt93CE626GSntbDwcDXdMpBDcgAy0U8ZNIb071qehJkgAI8ZTupnrQs+6F9bucVgVsN3C0XnL08bYZHjutLaAUEgOxuoIpm57semSBS2VnbHw+d31FCpuGOdlOTEDNUYlkJuB0oj766RE5S3+hEheKU71+aseDVMWaFVJFdqPuIBpGzcgMCP3wh/OKNOEudhhvpnCi7sKO/xN+GphgqFdE4w+e5faCYW0im6B83qXDM6LxUbhSwt3V74O0YtJbTjvLoKA+kGhkMSYjHHVs95fTMrOx4IuK0/95RE+A+T0Nc0hjukNWK55/vhGcDFE39Etk4peL/fX+RB1yAD9qaqPvdEVDAOaj6BcJXWP4qR3rFt13fxyxTd/O6SLXdSjB1OPq8aF4wjoXMBPr3HveoP+eIFLiYdZVKqxBmmJbgx6zIcbRwjjYEIKdYuOkoc3KJIil058FDNORA76ux6Z+rbNXnzsKbDdxHk= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(4636009)(396003)(376002)(346002)(39860400002)(136003)(230922051799003)(1800799012)(82310400011)(64100799003)(186009)(451199024)(36840700001)(40470700004)(46966006)(40480700001)(41300700001)(33656002)(81166007)(36860700001)(47076005)(356005)(55016003)(336012)(83380400001)(5660300002)(82740400003)(70206006)(26005)(2906002)(86362001)(107886003)(70586007)(9686003)(53546011)(6506007)(7696005)(52536014)(6862004)(8676002)(8936002)(4326008)(478600001)(40460700003)(966005)(316002)(54906003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2023 08:22:36.7061 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 85d734bf-f31e-4608-ae50-08dbef220357 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5PEPF00014B9D.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6093 X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > -----Original Message----- > From: Jakub Jelinek > Sent: Monday, November 27, 2023 8:13 AM > To: Tamar Christina > Cc: Xi Ruoyao ; Segher Boessenkool > ; David Edelsohn ; gcc- > patches@gcc.gnu.org; Andrew Pinski > Subject: Re: [PATCH] rs6000: Canonicalize copysign (x, -1) back to -abs (= x) in > the backend [PR112606] >=20 > On Mon, Nov 27, 2023 at 07:55:52AM +0000, Tamar Christina wrote: > > > For POPCOUNT I've introduced recently a way to provide custom > > > expand_* function and decide there what optimizations to use, even > > > when it otherwise is an integral unary optab ifn. > > > > > > > Oh that sounds interesting, do you have a commit for me to look at? I > > couldn't Spot anything obvious in the history. >=20 > https://gcc.gnu.org/r14-5613 Oh, that's nice! If that's the case a simpler fix could be to let COPYSIGN = become one of these as well, and then just have PPC do a FAIL on the abs and neg c= ases. Expand_copysign already does the fneg (fabs ()) rewriting if the target rej= ects the optab through expand_copysign_absneg That would also fix the i386 and Arm assembly scan failures and te phi-opts= case when the IFN isn't available.. I can do that if you prefer? Since those are= on my list to fix anyway. Thanks, Tamar >=20 > Jakub