public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Tamar Christina <Tamar.Christina@arm.com>
To: Richard Biener <richard.guenther@gmail.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
	nd <nd@arm.com>, "rguenther@suse.de" <rguenther@suse.de>,
	"jlaw@ventanamicro.com" <jlaw@ventanamicro.com>
Subject: RE: [PATCH 1/3]middle-end match.pd: don't emit label if not needed
Date: Tue, 18 Apr 2023 16:46:50 +0000	[thread overview]
Message-ID: <VI1PR08MB532567649D15557237B3D2B1FF9D9@VI1PR08MB5325.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <CAFiYyc3GSAVquPHz6MQ+Q2ODQR5zT_d-zTuqyU-hjiNOJfJ4Kw@mail.gmail.com>

> -----Original Message-----
> From: Richard Biener <richard.guenther@gmail.com>
> Sent: Tuesday, April 18, 2023 11:38 AM
> To: Tamar Christina <Tamar.Christina@arm.com>
> Cc: gcc-patches@gcc.gnu.org; nd <nd@arm.com>; rguenther@suse.de;
> jlaw@ventanamicro.com
> Subject: Re: [PATCH 1/3]middle-end match.pd: don't emit label if not needed
> 
> On Tue, Apr 18, 2023 at 12:21 PM Tamar Christina via Gcc-patches <gcc-
> patches@gcc.gnu.org> wrote:
> >
> > Hi All,
> >
> > This is a small QoL codegen improvement for match.pd to not emit
> > labels when they are not needed.  The codegen is nice and there is a
> > small (but consistent) improvement in compile time.
> >
> > Bootstrapped Regtested on aarch64-none-linux-gnu and no issues.
> >
> > Ok for master?
> 
> OK.  Btw - how many labels does this remove? (just wc -l the generated files?)

Not terribly much anymore, it's about 160 lines.  Though when benchmarking it
shows a consistent 2-5% speedup in compile time (I take the geomean of about 100 compiles).

Regards,
Tamar

> 
> Richard.
> 
> > Thanks,
> > Tamar
> >
> > gcc/ChangeLog:
> >
> >         PR bootstrap/84402
> >         * genmatch.cc (dt_simplify::gen_1): Only emit labels if used.
> >
> > --- inline copy of patch --
> > diff --git a/gcc/genmatch.cc b/gcc/genmatch.cc index
> >
> 4fab4135347c43d95546a7df0bb1c4d074937288..638606b2502f640e595
> 27fc5a0b2
> > 3fa3bedd0cee 100644
> > --- a/gcc/genmatch.cc
> > +++ b/gcc/genmatch.cc
> > @@ -3352,6 +3352,7 @@ dt_simplify::gen_1 (FILE *f, int indent, bool
> gimple, operand *result)
> >    char local_fail_label[256];
> >    snprintf (local_fail_label, 256, "next_after_fail%u", ++fail_label_cnt);
> >    fail_label = local_fail_label;
> > +  bool needs_label = false;
> >
> >    /* Analyze captures and perform early-outs on the incoming arguments
> >       that cover cases we cannot handle.  */ @@ -3366,6 +3367,7 @@
> > dt_simplify::gen_1 (FILE *f, int indent, bool gimple, operand *result)
> >                 fprintf_indent (f, indent,
> >                                 "if (TREE_SIDE_EFFECTS (_p%d)) goto %s;\n",
> >                                 i, fail_label);
> > +               needs_label = true;
> >                 if (verbose >= 1)
> >                   warning_at (as_a <expr *> (s->match)->ops[i]->location,
> >                               "forcing toplevel operand to have no "
> > @@ -3381,6 +3383,7 @@ dt_simplify::gen_1 (FILE *f, int indent, bool
> gimple, operand *result)
> >                 fprintf_indent (f, indent,
> >                                 "if (TREE_SIDE_EFFECTS (captures[%d])) "
> >                                 "goto %s;\n", i, fail_label);
> > +               needs_label = true;
> >                 if (verbose >= 1)
> >                   warning_at (cinfo.info[i].c->location,
> >                               "forcing captured operand to have no "
> > @@ -3423,7 +3426,10 @@ dt_simplify::gen_1 (FILE *f, int indent, bool
> gimple, operand *result)
> >      }
> >
> >    if (s->kind == simplify::SIMPLIFY)
> > -    fprintf_indent (f, indent, "if (UNLIKELY (!dbg_cnt (match))) goto %s;\n",
> fail_label);
> > +    {
> > +      fprintf_indent (f, indent, "if (UNLIKELY (!dbg_cnt (match))) goto %s;\n",
> fail_label);
> > +      needs_label = true;
> > +    }
> >
> >    fprintf_indent (f, indent, "if (UNLIKELY (dump_file && (dump_flags &
> TDF_FOLDING))) "
> >            "fprintf (dump_file, \"%s ", @@ -3496,9 +3502,12 @@
> > dt_simplify::gen_1 (FILE *f, int indent, bool gimple, operand *result)
> >                               "res_op->resimplify (%s, valueize);\n",
> >                               !e->force_leaf ? "lseq" : "NULL");
> >               if (e->force_leaf)
> > -               fprintf_indent (f, indent,
> > -                               "if (!maybe_push_res_to_seq (res_op, NULL)) "
> > -                               "goto %s;\n", fail_label);
> > +               {
> > +                 fprintf_indent (f, indent,
> > +                                 "if (!maybe_push_res_to_seq (res_op, NULL)) "
> > +                                 "goto %s;\n", fail_label);
> > +                 needs_label = true;
> > +               }
> >             }
> >         }
> >        else if (result->type == operand::OP_CAPTURE @@ -3554,9
> > +3563,12 @@ dt_simplify::gen_1 (FILE *f, int indent, bool gimple, operand
> *result)
> >                   continue;
> >                 if (cinfo.info[i].result_use_count
> >                     > cinfo.info[i].match_use_count)
> > -                 fprintf_indent (f, indent,
> > -                                 "if (! tree_invariant_p (captures[%d])) "
> > -                                 "goto %s;\n", i, fail_label);
> > +                 {
> > +                   fprintf_indent (f, indent,
> > +                                   "if (! tree_invariant_p (captures[%d])) "
> > +                                   "goto %s;\n", i, fail_label);
> > +                   needs_label = true;
> > +                 }
> >               }
> >           for (unsigned j = 0; j < e->ops.length (); ++j)
> >             {
> > @@ -3607,6 +3619,7 @@ dt_simplify::gen_1 (FILE *f, int indent, bool
> gimple, operand *result)
> >                     {
> >                       fprintf_indent (f, indent, "if (!_r)\n");
> >                       fprintf_indent (f, indent, "  goto %s;\n",
> > fail_label);
> > +                     needs_label = true;
> >                     }
> >                 }
> >             }
> > @@ -3647,7 +3660,8 @@ dt_simplify::gen_1 (FILE *f, int indent, bool
> gimple, operand *result)
> >      }
> >    indent -= 2;
> >    fprintf_indent (f, indent, "}\n");
> > -  fprintf (f, "%s:;\n", fail_label);
> > +  if (needs_label)
> > +    fprintf (f, "%s:;\n", fail_label);
> >    fail_label = NULL;
> >  }
> >
> >
> >
> >
> >
> > --

      reply	other threads:[~2023-04-18 16:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-06 10:56 [PATCH 1/3] RFC " Tamar Christina
2023-04-06 10:56 ` [PATCH 2/3] RFC - match.pd: simplify debug dump checks Tamar Christina
2023-04-18 10:19 ` [PATCH 1/3]middle-end match.pd: don't emit label if not needed Tamar Christina
2023-04-18 10:20 ` [PATCH 2/3]middle-end match.pd: simplify debug dump checks Tamar Christina
2023-04-18 10:47   ` Richard Biener
2023-04-19 10:44     ` Tamar Christina
2023-04-25 12:30     ` Tamar Christina
2023-04-25 13:13       ` Richard Biener
2023-04-25 14:17         ` Tamar Christina
2023-04-18 10:20 ` [PATCH 3/3]middle-end RFC - match.pd: automatically partition *-match.cc files Tamar Christina
2023-04-19 11:18   ` Richard Biener
2023-04-28 10:43     ` Tamar Christina
2023-04-28 12:39       ` Richard Biener
2023-04-18 10:38 ` [PATCH 1/3]middle-end match.pd: don't emit label if not needed Richard Biener
2023-04-18 16:46   ` Tamar Christina [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR08MB532567649D15557237B3D2B1FF9D9@VI1PR08MB5325.eurprd08.prod.outlook.com \
    --to=tamar.christina@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jlaw@ventanamicro.com \
    --cc=nd@arm.com \
    --cc=rguenther@suse.de \
    --cc=richard.guenther@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).