public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Tamar Christina <Tamar.Christina@arm.com>
To: Sandra Loosemore <sandra@codesourcery.com>,
	"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: nd <nd@arm.com>, "rguenther@suse.de" <rguenther@suse.de>
Subject: Re: [PATCH][committed]middle-end: Fix signbit tests when ran on ISA with support for masks.
Date: Wed, 10 Nov 2021 18:53:34 +0000	[thread overview]
Message-ID: <VI1PR08MB532573AB4A43BE25AB9133BBFF939@VI1PR08MB5325.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <617e70fb-7250-d599-bf38-41899ed99e5c@codesourcery.com>

FAIL: gcc.dg/signbit-2.c scan-tree-dump-times optimized "[file://\\s+]\\s+>\\s+{ 0,
0, 0, 0 }" 1

That's the old test which this patch has changed. Does it still fail with the new patch?
________________________________
From: Sandra Loosemore <sandra@codesourcery.com>
Sent: Wednesday, November 10, 2021 6:37 PM
To: Tamar Christina <Tamar.Christina@arm.com>; gcc-patches@gcc.gnu.org <gcc-patches@gcc.gnu.org>
Cc: nd <nd@arm.com>; rguenther@suse.de <rguenther@suse.de>
Subject: Re: [PATCH][committed]middle-end: Fix signbit tests when ran on ISA with support for masks.

On 11/10/21 4:54 AM, Tamar Christina via Gcc-patches wrote:
> Hi All,
>
> These test don't work on vector ISAs where the truth
> type don't match the vector mode of the operation.
>
> However I still want the tests to run on these
> architectures but just turn off the ISA modes that
> enable masks.
>
> This thus turns off SVE is it's on and turns off
> AVX512 if it's on.
>
> Regtested on aarch64-none-linux-gnu with SVE on,
> and x86_64-pc-linux-gnu with AVX512 on and no
> issues.
>
> Committed under the obvious rule.
>
> Thanks,
> Tamar
>
> gcc/testsuite/ChangeLog:
>
>        * gcc.dg/signbit-2.c: Turn of masks.
>        * gcc.dg/signbit-5.c: Likewise.

I'm seeing this failure on nios2-elf:

FAIL: gcc.dg/signbit-2.c scan-tree-dump-times optimized "\\s+<file://\\s+>>\\s+{ 0,
0, 0, 0 }" 1

I don't understand what it is expecting to happen here.  Should it be
skipped on this target, or restricted to ARM and x86?  Adding some
comments to the testcase to explain the significance of that pattern
might be useful too.

-Sandra



  reply	other threads:[~2021-11-10 18:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-10 11:54 Tamar Christina
2021-11-10 18:37 ` Sandra Loosemore
2021-11-10 18:53   ` Tamar Christina [this message]
2021-11-10 20:03     ` Sandra Loosemore
2021-11-11 13:24       ` Tamar Christina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR08MB532573AB4A43BE25AB9133BBFF939@VI1PR08MB5325.eurprd08.prod.outlook.com \
    --to=tamar.christina@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=nd@arm.com \
    --cc=rguenther@suse.de \
    --cc=sandra@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).