From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on2057.outbound.protection.outlook.com [40.107.15.57]) by sourceware.org (Postfix) with ESMTPS id 94BE3385803B for ; Thu, 14 Dec 2023 18:45:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 94BE3385803B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 94BE3385803B Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.15.57 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1702579504; cv=pass; b=lso5vK5weOJmmpCkfxPKXFqMFgnMyzMAzZGyJzVEL0DVXQzS58Lm28V5aoVYkZceH3+FsV37WN5kTv2abHannLnSW5AYZlr5kX/PTH56XZP3//hsgaUEBnfkylis7mNowiAGmA1nqw920inPdeAo5jozQNSkJhdsAnnq07GfqU8= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1702579504; c=relaxed/simple; bh=wjD8dBU3frJFekoOMqcylCUrr39pS2awOeEviVu/gx0=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=s6bYrBqrNwlZQtbB6T9uztA96427gl2Ohd478dKcHeGB9WLNwnPuTNtKoNM4uwhoAldOOE73Q3RwGApPKrr0ZWXR7KEFFIOYqMbAfh4ZMbZD1zpi28rLmxFCodlmfYvRh1qKDRKRPjwEo6Rlc3bilN5OG9MEaasHPe+3J2e+2a0= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=lTfFOMhFZy+q+z8vUPZaV1NIdsP+8D3jhT1vaEFvSz70u1DUEkNwtqU/yrn/tbwgonlGsvqXFX8T150RhUnKpuAswsZR7XNQEyVMF/cQPap38Qo7GI78kODVz8yhZViamhnUNlJA5ZEgOiYBRdGbEIc47GlGCplTqrtQkpoUdh01xqhF9EJhK5JZO6JmCfOAXzXbrYZfblIayF1EciINg+WhXqPnTv10nSM0P7354LMviMiuRXiOrUpgqy9Vtzlgtrk3LjJ0f1kcRUHpIE+8b7FQX7Zlfl4FIgR/PLOUTSp1QtNo/oYre4wxu8kzxbhChVcKdSai84phq073jLV1cw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jqiaXqE+LysR43cuscBOptXT9uP97vbGWax+cWWjv58=; b=hFFmyKZMZjJI3pSpODLRTuUOHBNKJszq9HIoIeZbD+0lIE6Kl7THBpkfOIJvS1DIawpbl5JJRkCpNk0s3846bqrA+I9nsYGKZzffqIDJ45cAwR7FL2GcO2RhooCKLSjnS6z+vFP2AEekhdd4d/nGC+lBIEjoE9TlCQHeCypr+HlL8w3sClNb8TJfywhVaxSUGqLD5yAKTMZqjkjSTiZ67eMeMDT2DYuDs3rd8RtqL3aEy6s15MdMBWTdy/ilJK31g/pGaN+5caGohqnrjoi/FOw1vPaGpUFKZHQiYsGkih/dFd8qGenh1gRCMAbBS1nvGEJ1eGu/yr+jRpiLSA3rlQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jqiaXqE+LysR43cuscBOptXT9uP97vbGWax+cWWjv58=; b=D0fOudNebzf+VIjgCa+u9gdBV9wECK9VlKYwQ3cdjUEQWJGUUs/aCEUs9U8ry7dfCUrvnis0AbA7Il5Opjbffsx0lGgPkCXhMH0Wzlsb7sWdNVtbSJM4PohuMR24JjgPbpywpXCQ6d5cupyV0/Hu6iYaLmZE7qkn9VSAVxWrtWI= Received: from DU2P251CA0010.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:230::25) by GV1PR08MB10404.eurprd08.prod.outlook.com (2603:10a6:150:16f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.28; Thu, 14 Dec 2023 18:44:53 +0000 Received: from DB5PEPF00014B96.eurprd02.prod.outlook.com (2603:10a6:10:230:cafe::d5) by DU2P251CA0010.outlook.office365.com (2603:10a6:10:230::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.28 via Frontend Transport; Thu, 14 Dec 2023 18:44:53 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5PEPF00014B96.mail.protection.outlook.com (10.167.8.234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.26 via Frontend Transport; Thu, 14 Dec 2023 18:44:53 +0000 Received: ("Tessian outbound 7c4ecdadb9e7:v228"); Thu, 14 Dec 2023 18:44:53 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 826a1e0f1aa1ed41 X-CR-MTA-TID: 64aa7808 Received: from 1a8c750b9da6.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1BE177F3-90B2-40E1-B13A-15F220D25938.1; Thu, 14 Dec 2023 18:44:44 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1a8c750b9da6.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 14 Dec 2023 18:44:44 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DpS9hEhTjJSOD+aqEtpfnDIq5ZqzVPImYEmMNjf6o37hVpFb4XZ3bWfQx85htmzO1/V+BP/4ISFqSEe0A28gs57HLSM8stqo1db3m9FZIKkNeP3OAnB2Y4UsqW8/ULCPFBFdSFk76H2g0UE1UE6rdr81HMYI8vC9ewMNtV3S97Eg4XnwW7BHPaF0/cEXok+X8joKKksscU5xNoah9A3qCw45YMlk4MCN2gUezpWYpqPiWgWRxwJR4VrmtJBCTiepE7sMwVB2P9cmLyd8znNOJ3nEpK27QF/SmDotpPzdfBp/cJb1ttiRc7KIG4uWllgDuujpLFK41waDu2Ad6MjIrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jqiaXqE+LysR43cuscBOptXT9uP97vbGWax+cWWjv58=; b=RjxsQIwb5lmeEj8BSAheS6IlPBCXO/hCNfkyiJ5R19wXOKWtfSNFrkWUM0bnxMzRS71s1npsd7uSoCaRC4DKKw/66Zo5GfY+HCwoWZf/I2WrkM0Hs8dG2INlIqlkWy0hc/5pHFJAXZCsu4ELfhcrjeDWlvAztd+S8uTwbCx3SiUKnT0dRuv2X/G4pCwqiopx1TJrSEQSh2HYjE8RVkMxu/1zt0VvGIpDg4vOPsoyDZR60nE+1WMCwuMm+g0zidjc9nu3Uc/dPdfDMvECyOGXSa34u7WetHSr9z4lmga4UNzNlEhyj4ZQ368yiwTpkI0Sx6HFhS6pcXIZ8AL7wCOibg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jqiaXqE+LysR43cuscBOptXT9uP97vbGWax+cWWjv58=; b=D0fOudNebzf+VIjgCa+u9gdBV9wECK9VlKYwQ3cdjUEQWJGUUs/aCEUs9U8ry7dfCUrvnis0AbA7Il5Opjbffsx0lGgPkCXhMH0Wzlsb7sWdNVtbSJM4PohuMR24JjgPbpywpXCQ6d5cupyV0/Hu6iYaLmZE7qkn9VSAVxWrtWI= Received: from VI1PR08MB5325.eurprd08.prod.outlook.com (2603:10a6:803:13e::17) by GV1PR08MB8009.eurprd08.prod.outlook.com (2603:10a6:150:9b::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.38; Thu, 14 Dec 2023 18:44:39 +0000 Received: from VI1PR08MB5325.eurprd08.prod.outlook.com ([fe80::9679:2ab0:99c6:54a3]) by VI1PR08MB5325.eurprd08.prod.outlook.com ([fe80::9679:2ab0:99c6:54a3%6]) with mapi id 15.20.7091.028; Thu, 14 Dec 2023 18:44:38 +0000 From: Tamar Christina To: Richard Biener CC: Richard Sandiford , "gcc-patches@gcc.gnu.org" , nd , "jlaw@ventanamicro.com" Subject: RE: [PATCH 9/21]middle-end: implement vectorizable_early_exit for codegen of exit code Thread-Topic: [PATCH 9/21]middle-end: implement vectorizable_early_exit for codegen of exit code Thread-Index: AQHaEIRpInfkk2iMNkKe/ayk/lXCPbCO5tuwgAKOHoCACmF78IAAWBaAgAMYIGCAABrAgIAAAmcwgAA4uQCABEHGgIAAK7mAgADdJdCAAL6RgIAADe9igAAIcwCAAb5I4IABgxCAgABbqaA= Date: Thu, 14 Dec 2023 18:44:38 +0000 Message-ID: References: <85570n66-1540-0r07-7q80-269p3o133585@fhfr.qr> <5r3p7378-q309-ooqo-7o76-q9r567ns1890@fhfr.qr> <3o102so4-34pp-3o01-o002-0q245oo10303@fhfr.qr> <6r730004-318n-on85-65q2-94n34psn93ns@fhfr.qr> In-Reply-To: <6r730004-318n-on85-65q2-94n34psn93ns@fhfr.qr> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: VI1PR08MB5325:EE_|GV1PR08MB8009:EE_|DB5PEPF00014B96:EE_|GV1PR08MB10404:EE_ X-MS-Office365-Filtering-Correlation-Id: d4f68e4d-80d9-4e46-5695-08dbfcd4c2f2 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ixYmCj9nFAH9ivQyUFXJ8U1apxWKg2PAsoysmrBxfBZF7SSzmpOm0Wp9QRMkiH1tF7RaT1y3czNy2VAtWnwcgDviogIp0+5nlLsEsbIFAmj3Zl1bo1kCqbJV+rU2qKvwO835L2m72TGT59KH0cOrkJv/sBv9i64EWSFvyK60rwLpCXdwsyLRNtVqvmZnbWn3z2m58eq8Yib3HeVM1N2rPkqGJ/34MwQwNG1DcucLXl//2T4MU0wV1m+su+Q26u/WIvqR3nEEyw697mJtJYIrthJux+XSEGqUxqdo3fbG1kVmJ0C0FjhLfUBXgy/LHUAXJEzNkWok7k8fDFNvaRRHdT+ov81XTbvjCbiyxnoaSW7AWFCXErFMtYMtmw2wPXrMat72H7jrC2PiU60cRbRiISZMgkqLU82Y9QtpcOXQDDHhWSIvuX625pHlblHVos6VhdoRpozu/By8sFy6onP/1hPt1ysB0OgHpGqq7jtuml5PIYf8x5U8lvEbfqIAXDNL2JNQgymbGM22hvSh0MmktokrjAYMPtQIHy4hCYA1wwsJkaKMxJd3lCeTuZ/lyl0M0OfE18a8ryuA9CZPWJ6XarnsDuZxGe14JOi0jIvMlMRW5fj6qlXSnn6CG5ixOKLG X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB5325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(376002)(136003)(366004)(346002)(396003)(230922051799003)(1800799012)(186009)(64100799003)(451199024)(55016003)(86362001)(33656002)(41300700001)(71200400001)(7696005)(76116006)(66556008)(478600001)(6506007)(53546011)(66946007)(66446008)(64756008)(54906003)(6916009)(66476007)(38070700009)(26005)(9686003)(38100700002)(122000001)(83380400001)(5660300002)(2906002)(316002)(8936002)(52536014)(8676002)(4326008);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8009 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5PEPF00014B96.eurprd02.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 57d2a53f-7431-4a98-72fc-08dbfcd4b9f9 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +jR5ZKr4SVhSy//gwjDpr6i/WIt2bDvg8H4OOx0DK7Gdg+QOxjOsdrrlDtPRfQNDKjFmlOZQ7+vjUY/3bRWkbZEKasd8jmD98XIW5cexVmtDLqUTRq0QLaDG5lnHqeIb0pbufTRl4NhenkX3czYQBWlrAC2kP6vEAJRNwWhrWWzobCmGLtttbl8IuyKm31zIIQnzsVhpyxAo0EM7kNqSCfIoCDz96suKvc9qeywz8mIw0IWgU4IIkFc+75E3cE+q5rv9RLhRLWJ0VcLyPE/ZGlmF6UAw3GijSXjzWWR/yHAbmU4wG7oKPjMZeV9Ne3oR375pjnC0nPswSUXmdwaET5QdrcJ3peOhhzy5kylmhuzOWURsjsYaZwy62mTQarnccGG9KAMJjGVSiht3SFHQZencHpNyzeAJpj1hyWJ8a6C2lgUyjKN2XvT85992eCuz4w5iz8wYiWsKq0VrR09JnYnlt7ApewoP8CFZ/2PTrb+1XS2LVnPFB5pAvRPKyxmHGHuPVmIJC/6/dPN4HbMKeSI7nZykg9pcA+rfrTlVWWcLsnfv2ysKt0JhZ/pbH9SMh4N04UzPbUKaw36COxqR885z1ocIx+dHtxoNw6vDIxrZuxddC+b+i5wPXZHrB3ViW9uAfA6G9kNork+WUSQs5OtHbOxkw7SAP0fpUUz1Hwq7sVQa7DMC74Qe/Y7ItYznHoapaAaThOpOcJQ1W2Ptca+0xJ1vYEiIaL4wxfeEMqAguqHR7bWmZzjsl+2eEGtK X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(4636009)(39860400002)(346002)(396003)(136003)(376002)(230922051799003)(451199024)(64100799003)(186009)(82310400011)(1800799012)(36840700001)(46966006)(40470700004)(40460700003)(336012)(26005)(107886003)(6506007)(7696005)(9686003)(36860700001)(83380400001)(47076005)(52536014)(5660300002)(4326008)(2906002)(6862004)(41300700001)(8676002)(478600001)(70586007)(53546011)(8936002)(70206006)(316002)(54906003)(82740400003)(33656002)(356005)(86362001)(81166007)(55016003)(40480700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2023 18:44:53.6985 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d4f68e4d-80d9-4e46-5695-08dbfcd4c2f2 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5PEPF00014B96.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB10404 X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > -----Original Message----- > From: Richard Biener > Sent: Thursday, December 14, 2023 1:13 PM > To: Tamar Christina > Cc: Richard Sandiford ; gcc-patches@gcc.gnu.or= g; > nd ; jlaw@ventanamicro.com > Subject: RE: [PATCH 9/21]middle-end: implement vectorizable_early_exit fo= r > codegen of exit code >=20 > On Wed, 13 Dec 2023, Tamar Christina wrote: >=20 > > > > > else if (vect_use_mask_type_p (stmt_info)) > > > > > { > > > > > unsigned int precision =3D stmt_info->mask_precision; > > > > > scalar_type =3D build_nonstandard_integer_type (precision, = 1); > > > > > vectype =3D get_mask_type_for_scalar_type (vinfo, scalar_ty= pe, > > > > > group_size); > > > > > if (!vectype) > > > > > return opt_result::failure_at (stmt, "not vectorized: uns= upported" > > > > > " data-type %T\n", scalar_= type); > > > > > > > > > > Richard, do you have any advice here? I suppose > vect_determine_precisions > > > > > needs to handle the gcond case with bool !=3D 0 somehow and for t= he > > > > > extra mask producer we add here we have to emulate what it would = have > > > > > done, right? > > > > > > > > How about handling gconds directly in vect_determine_mask_precision= ? > > > > In a sense it's not needed, since gconds are always roots, and so w= e > > > > could calculate their precision on the fly instead. But handling i= t in > > > > vect_determine_mask_precision feels like it should reduce the numbe= r > > > > of special cases. > > > > > > Yeah, that sounds worth trying. > > > > > > Richard. > > > > So here's a respin with this suggestion and the other issues fixed. > > Note that the testcases still need to be updated with the right stanzas= . > > > > The patch is much smaller, I still have a small change to > > vect_get_vector_types_for_stmt in case we get there on a gcond where > > vect_recog_gcond_pattern couldn't apply due to the target missing an > > appropriate vectype. The change only gracefully rejects the gcond. > > > > Since patterns cannot apply to the same root twice I've had to also do > > the split of the condition out of the gcond in bitfield lowering. >=20 > Bah. Guess we want to fix that (next stage1). Can you please add > a comment to the split out done in vect_recog_bitfield_ref_pattern? Done. >=20 > > Bootstrapped Regtested on aarch64-none-linux-gnu, x86_64-pc-linux-gnu a= nd > no issues. > > > > Ok for master? >=20 > OK with the above change. >=20 Thanks! That leaves one patch left. I'll have that for you Tuesday morning. Curren= tly going over it to see if I can't clean it up (and usually a day or two helps) more to mini= mize respins. I'll then also send the final testsuite patches. Thanks for all the reviews! Cheers, Tamar