public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Tamar Christina <Tamar.Christina@arm.com>
To: Jeff Law <jeffreyalaw@gmail.com>,
	"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: Richard Sandiford <Richard.Sandiford@arm.com>,
	"rep.dot.nop@gmail.com" <rep.dot.nop@gmail.com>,
	"rguenther@suse.de" <rguenther@suse.de>
Subject: RE: [PATCH 1/2]middle-end: Support early break/return auto-vectorization.
Date: Thu, 3 Nov 2022 08:51:23 +0000	[thread overview]
Message-ID: <VI1PR08MB5325AB2C5842A0D840C2354FFF389@VI1PR08MB5325.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <49d6c337-0b22-6b77-8bae-ad5724acbb8d@gmail.com>

> -----Original Message-----
> From: Gcc-patches <gcc-patches-
> bounces+tamar.christina=arm.com@gcc.gnu.org> On Behalf Of Jeff Law via
> Gcc-patches
> Sent: Wednesday, November 2, 2022 10:33 PM
> To: gcc-patches@gcc.gnu.org
> Subject: Re: [PATCH 1/2]middle-end: Support early break/return auto-
> vectorization.
> 
> 
> On 11/2/22 15:50, Bernhard Reutner-Fischer via Gcc-patches wrote:
> > On 2 November 2022 15:45:39 CET, Tamar Christina via Gcc-patches <gcc-
> patches@gcc.gnu.org> wrote:
> >> Hi All,
> >>
> >> This patch adds initial support for early break vectorization in GCC.
> >> The support is added for any target that implements a vector cbranch
> optab.
> >>
> >> Concretely the kind of loops supported are of the forms:
> >>
> >> for (int i = 0; i < N; i++)
> >> {
> >>    <statements1>
> >>    if (<condition>)
> >>      <action>;
> >>    <statements2>
> >> }
> >>
> >> where <action> can be:
> >> - break
> >> - return
> > Just curious, but don't we have graphite for splitting loops on control flow,
> respectively reflow loops to help vectorization like in this case? Did you
> compare, and if so, what's missing?
> 
> Graphite isn't generally enabled, is largely unmaintained and often makes
> things worse rather than better.
> 

Indeed, but also couldn't get graphite to do much in this case.

Pass just says

0 loops carried no dependency.
Pass statistics of "graphite": ----------------

And bails out. and none of the other graphite passes seem to put anything
in the dump files..

That aside, other reason to do it in the vectorizer is that eventually we can build
to support general control flow support and vectorizing these loops without
needing to peel the loop for ISAs that are fully masked.

Regards,
Tamar

> 
> jeff
> 


  reply	other threads:[~2022-11-03  8:51 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-02 14:45 Tamar Christina
2022-11-02 14:46 ` [PATCH 2/2]AArch64 Add implementation for vector cbranch Tamar Christina
2022-11-02 21:50 ` [PATCH 1/2]middle-end: Support early break/return auto-vectorization Bernhard Reutner-Fischer
2022-11-02 22:32   ` Jeff Law
2022-11-03  8:51     ` Tamar Christina [this message]
2022-11-08 17:36 ` Tamar Christina
2022-11-15 11:11   ` Tamar Christina
2022-11-16 12:17     ` Richard Biener
2022-11-16 18:52       ` Jeff Law
2022-11-18 15:04 ` Richard Biener
2022-11-18 18:23   ` Tamar Christina
2022-11-19 10:49     ` Tamar Christina
2022-11-24  9:02     ` Richard Biener
2022-11-24 11:56       ` Tamar Christina
2022-11-25  9:33         ` Richard Biener
2022-11-25 10:32           ` Tamar Christina
2022-12-13 15:01             ` Tamar Christina
2022-12-14  9:41               ` Richard Biener

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR08MB5325AB2C5842A0D840C2354FFF389@VI1PR08MB5325.eurprd08.prod.outlook.com \
    --to=tamar.christina@arm.com \
    --cc=Richard.Sandiford@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jeffreyalaw@gmail.com \
    --cc=rep.dot.nop@gmail.com \
    --cc=rguenther@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).