From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2082.outbound.protection.outlook.com [40.107.22.82]) by sourceware.org (Postfix) with ESMTPS id 84E9C3858C50 for ; Mon, 20 May 2024 11:50:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 84E9C3858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 84E9C3858C50 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.22.82 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1716205822; cv=pass; b=tWtdPm4o1aPwbZHWvxaevngouvSdILqB+c7yhHB0NjkN0nn/N5MlmNpGVxO2t2sPyHIC46Jq9vHw6ZXevo4q55VHFnrWGpqdoLJIw9Ha4mkgC/Xh/ytxtsLx1cDKyxBpGv2rQRcJQeW8S543vttppR4QdpcBGEwoWFRGt1sF6YQ= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1716205822; c=relaxed/simple; bh=TN4EWDfgz8BlFL96vK83I273j4tk2kVwkPLuOGNm8/Q=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=LXumhFl9sdF2yjC+L7p43dAJ03JDOOpzekA5ekE4nbAiofMY85s2Pk659l+mVB/tCtwdYm3H/secfHGv9YiGlIDrcZSnVY8Ihknp4SJIZa26GDTiZUJYaiFpIrwquT9yk1Y4RfW0WbWcxBaAuXn/W5h7zS0LoJDXJYFOK6RBa7A= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=AdlbnBtF5NPWEWDvmCCfMJvxkbnaZ9hrFQhmkpgxDYnI2YEvndfgqfCyoGn8O6YFJoIM85RX/y+x5BddZM76lCHQ4d+HZYRN6NJFzds7NzJull3VoYj9whJmH/9Z1cqSgN7UYdy7pd95v+7kbOj8DUpC/t/oXhcttNFy2S61w9ArdhldYeY/HP99DIU2dvWoKlUnxwuiZSlox/PYNlaxsSdJbi1YrQxTBuM2S7K+YdsxRxl1WlI/QlnfHU525U79ReGZGghOpf0F3h6YzW+Sx3cO4hwVx4OBnz/6+Ui486DDl2+t77ThMQL5yAdsH57M2ibVxqwMPe3VTTI/DxWzig== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gDnkdgKpgNPxbYIuGptEVe9wWKQ3JsXlNEFxMmz+VG0=; b=G7EcaLwF40b7d0v+f/NcsT230NsDQP3K03W9EzzswTzYTic8ausNiZmzV1ul+ePzBw9fNlBBxlS8qcd5gZPnxPeNDodmWoDVrOBWaUzoTYpJJHZ2DdNQHaX1PyPsa+3p6lOyiruYsOFOWtsqPYN4OD7Jv7dS0fxR2GMaZWo1k2GkgJRnNd3EXXeiiSqstxEwXx2c9o49cdA7PtfAGsJWZ1dXf8gBjoUKsr872rSOzB7Y5TD+uD1R7VWnU6v0ej9sbRl7HzFH7ttOrdo66XDYD5HtL+dsaBWL+bmiYjsYNjr1+kT7mWcqlPTtxqNcBw6qIURgmJR406BaO3rYXXXbzg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gDnkdgKpgNPxbYIuGptEVe9wWKQ3JsXlNEFxMmz+VG0=; b=AA+mefrMylRvO3qnVcdd2bt3BCV65IJ85I3UDX7/9Kl0jxIs+03IWoKKFr6E6+cr3q3rB0PheptpXKXJcv3Z0JmF5a/0Gar9dsiUeqgicJU2jNk8k0yrDjJBJsyCTFsKAL0hI6TDPPeuWkZrhgrXPvz3crHLskLnqUfSi9YEOj4= Received: from AS9PR06CA0520.eurprd06.prod.outlook.com (2603:10a6:20b:49d::23) by VI0PR08MB10779.eurprd08.prod.outlook.com (2603:10a6:800:203::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.35; Mon, 20 May 2024 11:50:15 +0000 Received: from AMS0EPF000001A2.eurprd05.prod.outlook.com (2603:10a6:20b:49d:cafe::77) by AS9PR06CA0520.outlook.office365.com (2603:10a6:20b:49d::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.35 via Frontend Transport; Mon, 20 May 2024 11:50:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AMS0EPF000001A2.mail.protection.outlook.com (10.167.16.235) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.7611.14 via Frontend Transport; Mon, 20 May 2024 11:50:15 +0000 Received: ("Tessian outbound b7675f20d34d:v315"); Mon, 20 May 2024 11:50:14 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: c392bd40b6de0fa1 X-CR-MTA-TID: 64aa7808 Received: from c694c7ccab00.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 02AFDF5A-FE1D-4E6D-8D09-156F6EA64549.1; Mon, 20 May 2024 11:50:06 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c694c7ccab00.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 20 May 2024 11:50:06 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BF6aDtrW5d9QMWydJduzCQOZfoXeZ6rNDdisyPecXKFZikGt2VMKIQ4jks3W/2xCt9U2qyzmZOWw5iS1/XT4KCB75SN+8jgjmDz/APJeJTdvIu3vjK8t+Zrl+CkUbFRVvaPXsbRkxDbRw2enk86d1lLSsph/8o8bAH7laBc2UE9s4sELijMc6xrq1CdQT6EVFoHKZSFWfziUbopne4KyEW8tlNAkSpAMi3kLNfwbG3LbAMVfj/6cyuvEAucb1wzJl0KWl/Bixno5Z6mIIzLuSrD53J/3l3vtfKdZk4FaYVARF/iLLmou/CrIX9LcymfVcqtIsWkaF6us2Eu3XSuD5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gDnkdgKpgNPxbYIuGptEVe9wWKQ3JsXlNEFxMmz+VG0=; b=mZ8P8GwReMYQOrWB2PAx3nbAd/jRoiQ2m7Abv5agup54xbWfBMkHmOTGbNelg2Z/9G0b67BXf/eGC8C7h4HxJLQlkja3XUYidnKAvPiDRKwyJn/hSJiWKqb7I+vBGrE1gqv7PdkbhKrXm8cuSAA2Wh+XpA3ph9QUyikB6JNRbbBtQcByPG9C4X8p9/KXLUsx7Rn03QDUYvwSap4JP/qWEAPN/b30xGNB2o10rLK2SX45a7wpS0z9M6SJqa8EHJtBwXfSeFIvcKe8YIAnN6iXYlRXSVY78Qvr/wlzowFtyKW+Mz7F8p3LOOJNKO+WuHef3hwCVwPr40Jh6m2fHYbWtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gDnkdgKpgNPxbYIuGptEVe9wWKQ3JsXlNEFxMmz+VG0=; b=AA+mefrMylRvO3qnVcdd2bt3BCV65IJ85I3UDX7/9Kl0jxIs+03IWoKKFr6E6+cr3q3rB0PheptpXKXJcv3Z0JmF5a/0Gar9dsiUeqgicJU2jNk8k0yrDjJBJsyCTFsKAL0hI6TDPPeuWkZrhgrXPvz3crHLskLnqUfSi9YEOj4= Received: from VI1PR08MB5325.eurprd08.prod.outlook.com (2603:10a6:803:13e::17) by GV2PR08MB8342.eurprd08.prod.outlook.com (2603:10a6:150:bf::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.35; Mon, 20 May 2024 11:50:04 +0000 Received: from VI1PR08MB5325.eurprd08.prod.outlook.com ([fe80::89dc:c731:362b:7c69]) by VI1PR08MB5325.eurprd08.prod.outlook.com ([fe80::89dc:c731:362b:7c69%4]) with mapi id 15.20.7587.030; Mon, 20 May 2024 11:50:03 +0000 From: Tamar Christina To: "pan2.li@intel.com" , "gcc-patches@gcc.gnu.org" CC: "juzhe.zhong@rivai.ai" , "kito.cheng@gmail.com" , "richard.guenther@gmail.com" Subject: RE: [PATCH v1 1/2] Match: Support branch form for unsigned SAT_ADD Thread-Topic: [PATCH v1 1/2] Match: Support branch form for unsigned SAT_ADD Thread-Index: AQHaqqUKiv9Tfs9J70ORqtEXPdRNJ7Gf/9Ag Date: Mon, 20 May 2024 11:50:03 +0000 Message-ID: References: <20240520110048.2827900-1-pan2.li@intel.com> In-Reply-To: <20240520110048.2827900-1-pan2.li@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: VI1PR08MB5325:EE_|GV2PR08MB8342:EE_|AMS0EPF000001A2:EE_|VI0PR08MB10779:EE_ X-MS-Office365-Filtering-Correlation-Id: 41ddbd01-0854-4753-f2e4-08dc78c30369 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230031|376005|1800799015|366007|38070700009; X-Microsoft-Antispam-Message-Info-Original: =?us-ascii?Q?guqLGbCL9zG25TnbRjKBCdvwKqClGDDg60A9EAXwlq+WRRGdqikIK9uJ69wI?= =?us-ascii?Q?Pr1/IETFdguG15PWTQCFePE4RsLEW3VkUpO7Vxb3fJZ6xG3c1qmDCsO1aEtK?= =?us-ascii?Q?5+ov6AmIMt/r+GPWLcWZkUjCifBX1rSFaL4+V1p8O+l9PQpvHMbcgEEm+Dwq?= =?us-ascii?Q?IIZlpRf5L4I8Gh51TppuBn8TP5D+98S53ngl2df4AxVdG9j1210ZZo2npeCf?= =?us-ascii?Q?rVSLa6XOtrhmuZYLp/3pw1xtMq7VVa1amUjeJMrAfuENI+SI6wu+8HBQVVdq?= =?us-ascii?Q?Lbx9aFu5rhAXf2lEu+l91G1RAR3qjKXe1fLeSulVnoqAJnxGhUeiRtXDZeXo?= =?us-ascii?Q?1b1e4OsJs+WSRBBpuEoRtl0f1S3sCYqcAeUzNj65YfkAh1exD4kYOTQls0sy?= =?us-ascii?Q?Mj1eDJILPGmtXvdY/n+cBtDuH8IyzzzHIyj6JdBSd99xWgrFf3FMbDWCq4O8?= =?us-ascii?Q?X0gQwxu05sCuLWDJGADicoWgRfWeQ2n5mNePfJG1A4632XHqsJW5wct/phNF?= =?us-ascii?Q?HWQX/mPstsg6UCK++YlKjYWhLpsHA2NdrUVbMIVV4s/fHli6017kXVGL4ewI?= =?us-ascii?Q?EG7tymSOfwXhjQa6FrXtzptJqCaUS2Iso0QD9XlgqNcbu5sveonpx2qBEwV9?= =?us-ascii?Q?ioYMdJKCBOCfpjJ93gCChqvnXWfY17H4LA3Q3PWrmg9SINw6lLlQR1p+SsIT?= =?us-ascii?Q?ouO9Xut2/6LZXc8extdKtDFfi+A+fzd2msvrnUAiv5H/PYMv2Gzf2aKjmfQ+?= =?us-ascii?Q?Ndal3aGEBWzxj7jPcbOmu17oL92E6W3ocnjk5pPvpPatBM+vKySqaJePzMM+?= =?us-ascii?Q?BqC8MOH2uEH6FCSFOQTEIXbaCu6mThqre+RPVqAB0cHI2XNHXygUvl/6k9Nx?= =?us-ascii?Q?abgbYoen7FolDaxTW9ok4BMgnYxeyaMMNz+IU4IO1WOtvPwFgN0vXklOPQLf?= =?us-ascii?Q?IRHEb4E3c5VpVZpc4n/nqpULnBfx/vzmvO+7xuUq41c8aThRtX50pbwd2K6/?= =?us-ascii?Q?pHOVbiX5/IIZmet1JfMTHfes94u62kK2f4oMKeFa//n/B0dEuTdPQ3OZ8Lnk?= =?us-ascii?Q?UP7bL3Ac6qXi8xGS2KEO6WqUJFV//WQyFDpNRbkwKARWrVTukq6djCdxK/6c?= =?us-ascii?Q?FsolTo78QxJGyZdTvyu30tHcwnBnF5O3EQ2H444MP+bZsPa9oq9GUJbmY98O?= =?us-ascii?Q?ZJlwqvG1zv0s3EoQC19D3kh5oSwiVHhAGXUcwDyOUKTkuTaJti7SEDq5scrB?= =?us-ascii?Q?9D3TyHd+xnVtaQA4jwrbZkuQ9krCX/3Gng5qK5mRGX+NZ42OaiiSpD1GUwD/?= =?us-ascii?Q?0NtE7NLrROVwJZsaFfwIksKY3F9FbdmOXdg9hOQ4fH6QlQ=3D=3D?= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB5325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(1800799015)(366007)(38070700009);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8342 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AMS0EPF000001A2.eurprd05.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ec36e6bc-a334-43ac-191d-08dc78c2fcba X-Microsoft-Antispam: BCL:0;ARA:13230031|1800799015|82310400017|36860700004|376005|35042699013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?InLGVmv0HVnbimapi8ZEfyXqUgaOruiZwvMwQA59zX7vdPl5Rp+gQkZOHCHI?= =?us-ascii?Q?43EQdhXoSARN8Z/L6WoJX228er65DhA9CcGNL1ZSca2qLompzrOxyDz2gPIT?= =?us-ascii?Q?y5iskosy8kwtf3xjbgARxYIoENu0dAW0BDXnBPF+mBgpo2nhK3j+6kXWz3jX?= =?us-ascii?Q?pwL4VeXe5M99+GdaXnh1wytkInfQenl8iqQEysK1w9pF29JtU/ynm1Pj21CR?= =?us-ascii?Q?EwFVG9qTtjqB2wyyXdbV+JFL92jM9aICMY9dessv9G+dxT48aTS7TxFYk6Ke?= =?us-ascii?Q?5/UvIR8Kjuikog1wuTlNw7RQSZ7i5aF3MmdyPG/RfHEoNpH36yVnYaod02d1?= =?us-ascii?Q?v7dOWtHo13ym5UltMp6FxZ3Qd3ULYlfvJq5aaBNhb38edC5vbnotB7SfMBU+?= =?us-ascii?Q?rRe0oqoFKcPcpm1Mi78aRjtmslLbUA4YDhO2xZsBAsJBlD+ZCj7S0hSqlyOQ?= =?us-ascii?Q?QFla0DKQNKZamaJRnYgDB4GRK+gWF07WGAELyC7jpxsvj9pCB2epS2N9Adec?= =?us-ascii?Q?E/9EcSldKD+qj8pDPiu841QTonGFvH5ykcjvyPr68kz2XmonwDLV5aM0MO3c?= =?us-ascii?Q?/kQiaZTTAvjP/tMznXF1xeMBbejQrEFmompLdFOApii7x0QuRgS3W27rpdZl?= =?us-ascii?Q?KNoTywe/palV95sQ9RTtDs5UPcgm3LSESrHbUHsXiSEeWQy6RgRnG/23VYjJ?= =?us-ascii?Q?wdZ0FP9hvYPymj2u4BjpP7Edr9s680qYPAcERMgpBdmGAhCflgriiClAA4zu?= =?us-ascii?Q?Fj1s2XmFeyCMUKpxfM+F6sj5K0hcvl6XbfWMediEr1k1A20ooHXg1WvOr+ZF?= =?us-ascii?Q?Cauhz/B3Q87zStb/3KcLek4BMMESnPnStnR5xmMeWOkIMdQZ2I0P7xUm60Nh?= =?us-ascii?Q?WCiM2jPDPW50eJZRbhvlfP59bqLHoavMd0rUBtJnsp2j59jvFsltNFBmn5eE?= =?us-ascii?Q?zlhtE26yQgbfDjDfbJB2ZHdcSrWfE7G/XHz6E3U0AQclXzfyZOl12G7r0JlP?= =?us-ascii?Q?9b0KeqEMBkwbyylqlYCnsa1uZpytdfR3MQcSXOx1cwoBfvdKv8azvHVVveVv?= =?us-ascii?Q?golyBzUgvSLpd8jWcSyWAA8fN6oUgJS2tdJyD4qAkG0ev1zqqeG2MCtRNbgU?= =?us-ascii?Q?sfhwL35tegoiwa1+/WpROK+XrColGqM2U5ELwES/7Z8zk9/LrT/iyVde1WUm?= =?us-ascii?Q?ZmpXzu9iP60ozLpWiD0+cFyYS+vNgJVrwon9ScgG3oBEmpKHHdUmJZsvjnzD?= =?us-ascii?Q?0+yzlfi1aDWjE/gL76/ywREaBozgoRPiAAIPyF7O36aFyn6RuW7f65j7kdlc?= =?us-ascii?Q?bfF841JYpCuUtlBXlsdk63GM4ignSEuW5JB5A35U3BuFXmO+n3s7fqJPyIeZ?= =?us-ascii?Q?L6gzEQYcjs7sU/kY3ABCwP6drnzp?= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(1800799015)(82310400017)(36860700004)(376005)(35042699013);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2024 11:50:15.0217 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 41ddbd01-0854-4753-f2e4-08dc78c30369 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF000001A2.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI0PR08MB10779 X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,GIT_PATCH_0,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Pan, > -----Original Message----- > From: pan2.li@intel.com > Sent: Monday, May 20, 2024 12:01 PM > To: gcc-patches@gcc.gnu.org > Cc: juzhe.zhong@rivai.ai; kito.cheng@gmail.com; Tamar Christina > ; richard.guenther@gmail.com; Pan Li > > Subject: [PATCH v1 1/2] Match: Support branch form for unsigned SAT_ADD >=20 > From: Pan Li >=20 > This patch would like to support the branch form for unsigned > SAT_ADD. For example as below: >=20 > uint64_t > sat_add (uint64_t x, uint64_t y) > { > return (uint64_t) (x + y) >=3D x ? (x + y) : -1; > } >=20 > Different to the branchless version, we leverage the simplify to > convert the branch version of SAT_ADD into branchless if and only > if the backend has supported the IFN_SAT_ADD. Thus, the backend has > the ability to choose branch or branchless implementation of .SAT_ADD. > For example, some target can take care of branches code more optimally. >=20 > When the target implement the IFN_SAT_ADD for unsigned and before this > patch: > uint64_t sat_add_u_1_uint64_t (uint64_t x, uint64_t y) > { > long unsigned int _1; > uint64_t _2; > __complex__ long unsigned int _6; > long unsigned int _7; >=20 > ;; basic block 2, loop depth 0 > ;; pred: ENTRY > _6 =3D .ADD_OVERFLOW (x_3(D), y_4(D)); > _1 =3D REALPART_EXPR <_6>; > _7 =3D IMAGPART_EXPR <_6>; > if (_7 =3D=3D 0) > goto ; [65.00%] > else > goto ; [35.00%] > ;; succ: 4 > ;; 3 >=20 > ;; basic block 3, loop depth 0 > ;; pred: 2 > ;; succ: 4 >=20 > ;; basic block 4, loop depth 0 > ;; pred: 3 > ;; 2 > # _2 =3D PHI <18446744073709551615(3), _1(2)> > return _2; > ;; succ: EXIT >=20 > } >=20 > After this patch: > uint64_t sat_add (uint64_t x, uint64_t y) > { > long unsigned int _9; >=20 > ;; basic block 2, loop depth 0 > ;; pred: ENTRY > _9 =3D .SAT_ADD (x_3(D), y_4(D)); [tail call] > return _9; > ;; succ: EXIT > } >=20 > The below test suites are passed for this patch: > * The x86 bootstrap test. > * The x86 fully regression test. > * The riscv fully regression test. >=20 > gcc/ChangeLog: >=20 > * match.pd: Add new simplify to convert branch SAT_ADD into > branchless, if and only if backend implement the IFN. >=20 > Signed-off-by: Pan Li > --- > gcc/match.pd | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) >=20 > diff --git a/gcc/match.pd b/gcc/match.pd > index 0f9c34fa897..0547b57b3a3 100644 > --- a/gcc/match.pd > +++ b/gcc/match.pd > @@ -3094,6 +3094,24 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) > (match (unsigned_integer_sat_add @0 @1) > (bit_ior:c (usadd_left_part_2 @0 @1) (usadd_right_part_2 @0 @1))) >=20 > +#if GIMPLE > + > +/* Simplify the branch version of SAT_ADD into branchless if and only if > + the backend has supported the IFN_SAT_ADD. Thus, the backend has the > + ability to choose branch or branchless implementation of .SAT_ADD. *= / > + > +(simplify > + (cond (ge (plus:c@2 @0 @1) @0) @2 integer_minus_onep) > + (if (direct_internal_fn_supported_p (IFN_SAT_ADD, type, > OPTIMIZE_FOR_BOTH)) > + (bit_ior @2 (negate (convert (lt @2 @0)))))) > + > +(simplify > + (cond (le @0 (plus:c@2 @0 @1)) @2 integer_minus_onep) > + (if (direct_internal_fn_supported_p (IFN_SAT_ADD, type, > OPTIMIZE_FOR_BOTH)) > + (bit_ior @2 (negate (convert (lt @2 @0)))))) > + > +#endif Thanks, this looks good to me! I'll leave it up to Richard to approve, Richard: The reason for the direct_internal_fn_supported_p is because some targets said that they currently handle the branch version better due to th= e lack of some types. At the time I reason it's just a target expansion bug but d= idn't hear anything. To be honest, it feels to me like we should do this unconditionally, and ju= st have the targets that get faster branch version to handle it during expand? Since the patch = series provides a canonicalized version now. This means we can also better support targets that have the vector optab bu= t not the scalar one as the above check would fail for these targets. What do you think? Thanks, Tamar > + > /* x > y && x !=3D XXX_MIN --> x > y > x > y && x =3D=3D XXX_MIN --> false . */ > (for eqne (eq ne) > -- > 2.34.1