From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on2048.outbound.protection.outlook.com [40.107.15.48]) by sourceware.org (Postfix) with ESMTPS id ACD933858D37 for ; Fri, 28 Apr 2023 14:03:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ACD933858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cVV8nVZctpwANoQbsQBBPizUospAkS5vAybCRmw85WU=; b=K0ZEnEeynXo9d6aSBB0Pzm8mnjHDLCIZgfc0TkSkUNGGNMUWKRubK/55EHoXauqkXdjWa7zh8y/ydqeN+t46yJu6WmtNkJ7pJlm/lsslov4wqoFTCJk5BIHeR2U/ilVPlAeJ61S8hfYcsGSIMfxpyTLK7gWO9cyZRSv4jRw8Tck= Received: from AM7PR02CA0022.eurprd02.prod.outlook.com (2603:10a6:20b:100::32) by AM8PR08MB5651.eurprd08.prod.outlook.com (2603:10a6:20b:1c4::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.24; Fri, 28 Apr 2023 14:02:59 +0000 Received: from AM7EUR03FT033.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:100:cafe::f9) by AM7PR02CA0022.outlook.office365.com (2603:10a6:20b:100::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.24 via Frontend Transport; Fri, 28 Apr 2023 14:02:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT033.mail.protection.outlook.com (100.127.140.129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.22 via Frontend Transport; Fri, 28 Apr 2023 14:02:58 +0000 Received: ("Tessian outbound 5154e9d36775:v136"); Fri, 28 Apr 2023 14:02:58 +0000 X-CR-MTA-TID: 64aa7808 Received: from dddd7c066372.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2AC45074-BED3-4759-A1C8-6E88A6CB0125.1; Fri, 28 Apr 2023 14:02:52 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id dddd7c066372.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 28 Apr 2023 14:02:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AmsHCEXMDDO3NEL52N1i+yABxpxDpdjo8mHybqpgcow3rW1voc1bivx90xnwrV3WnMy1gubJwyzMpEoSjwc5x9kkyXnu0etKkUiPWq2j9KagZV8uJbCT31oJl3DxnByiAuuCkWAe8uzrsdZSu66m4tYyZwqePkhxxaLXbYHO+KKnqYtpiIo2hpM3lQ2WkhRoX67Jmlx4JPD2svFNOehtdd9g0Oay6t24bbdcH9Xzbdxb1ak7RA5mWGQHISoHdlD+z012aaFlDAO3ongPKDEHDsC/HLQ2fOBg6xoT7I5kNQinuKX/qNtMmB2xazjgBlNtXhb+4OjKvjnkr7eGi0XLKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cVV8nVZctpwANoQbsQBBPizUospAkS5vAybCRmw85WU=; b=CqQqTPYpP7jQMfNJvoR95lgAW04lwFPn/mWOtsb6fZcrCEdZRIkSHz0u96S7NQLeBWWgg9tj31w1DzfogbyGAVIfuFlazm2tp28mtgSA0f8S3toihVODBGWJObaKrda9gLFOpt4sc27+Hp0cbfrANaL1zGh36l38c0hHLP/Px7Z1BYyrdH/43VfcPuR5HCySVMxHoTu8VeRfieGlOvODIburTQATCTxFdBPyTI9rCnj66KjN30LMFIf0A8P87WvwXJsa4vsk49LVE8wowRYSTdcNy41Mpcb8bI/eHZ9WyUaCdVCMTyiRUCQjsdO6P0y4OgRVhCS9uGvZ8bS6hCFmsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cVV8nVZctpwANoQbsQBBPizUospAkS5vAybCRmw85WU=; b=K0ZEnEeynXo9d6aSBB0Pzm8mnjHDLCIZgfc0TkSkUNGGNMUWKRubK/55EHoXauqkXdjWa7zh8y/ydqeN+t46yJu6WmtNkJ7pJlm/lsslov4wqoFTCJk5BIHeR2U/ilVPlAeJ61S8hfYcsGSIMfxpyTLK7gWO9cyZRSv4jRw8Tck= Received: from VI1PR08MB5325.eurprd08.prod.outlook.com (2603:10a6:803:13e::17) by PAVPR08MB9771.eurprd08.prod.outlook.com (2603:10a6:102:31f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.23; Fri, 28 Apr 2023 14:02:48 +0000 Received: from VI1PR08MB5325.eurprd08.prod.outlook.com ([fe80::82f2:dba0:1f9b:c8f]) by VI1PR08MB5325.eurprd08.prod.outlook.com ([fe80::82f2:dba0:1f9b:c8f%7]) with mapi id 15.20.6340.023; Fri, 28 Apr 2023 14:02:48 +0000 From: Tamar Christina To: Paul Koning CC: Hans-Peter Nilsson via Gcc-patches , nd , "rguenther@suse.de" , "jlaw@ventanamicro.com" Subject: RE: [PATCH 2/5] match.pd: Remove commented out line pragmas unless -vv is used. Thread-Topic: [PATCH 2/5] match.pd: Remove commented out line pragmas unless -vv is used. Thread-Index: AQHZeb2YC/ZvtIIX/0uzXi586B6JbK9AtDUAgAAMZLA= Date: Fri, 28 Apr 2023 14:02:48 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 105940F851A9304EAF3C2F9DBB80701C.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: VI1PR08MB5325:EE_|PAVPR08MB9771:EE_|AM7EUR03FT033:EE_|AM8PR08MB5651:EE_ X-MS-Office365-Filtering-Correlation-Id: 52b1a3cf-834f-4be5-7117-08db47f145ca x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: DOG3lcrosCJY922ESzwT6SaegsopYcpNJgpsMh106Fw7iVx3sy+bPDiiEe/TTvP394WLQqKdnZQ0eEN9vhT6sAv6JhRAU9i1N8Bq5r9LnnZhtVTtqAHZFAtFfdM1vsUmQ/Sa34HgPFNVkYd5//gZA7bpo9ztaSrmPK6bTvsxHOfee+ixswh7U3VLlVKxGpcGvKNTQkbYpUOX2ATJifbnlCWrwfjlj4+Sa/2plINEeQoaN4BtAMmuWrE6fx6pFaGYwYmeTDiTYQgVzaYou/RHqmvIWpQkIFkWzv5fy6C2PgSjgVttRsq5xwJRfddYqBxNMP3o1NURh3RDik85N47qAMe19KVsd0B84ewNQSiC+kHEm3zcBQLDSkBKoKIAeu1UQN7UvYsTaVknhO83zUMhGiEN9Ap3DE1cUuFLR2EBpqKz7D1Wj5L4oviibt+tpqQlzfp9ER98bVXrAHkB6teMgO6fDWJ2cGuFx/X9YEhMt7JwYR5jC26sTE0To+XINjOxj7S6oLc5vrim5KUo+wPro2ro7lic7OqLsB8bNpxWzY0QcpG5ODHxmlkr6+XmW4XpPMxbwJ2tkq+2NyYxu7aKNSHq7BwrJ9gd+j1ibn5XYQSDcq7QBIRB8LS5Pa4ag/1m X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB5325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(396003)(136003)(376002)(39860400002)(346002)(451199021)(478600001)(7696005)(64756008)(66946007)(66556008)(66446008)(76116006)(6916009)(4326008)(33656002)(6506007)(9686003)(26005)(53546011)(8676002)(38100700002)(8936002)(41300700001)(186003)(86362001)(122000001)(52536014)(5660300002)(66476007)(55016003)(54906003)(316002)(38070700005)(2906002)(71200400001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9771 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0f61ad51-7756-44bd-4380-08db47f13f99 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dSutN4ZB8QiyWaHv62SF3+puZPcwnVuwB6vsfy9dk+W4QacL/poezmi+/9Z0pExM2jKc/86Cks8ATxHOm5ksC57nmboRrA8lwkNFNpF8bHM2tJu9S7cjWM5iieFOy65sx3jyBNuwlynAS91q6DoItOXiDLTX0QYgH2KGu+0B4oHjDUzqZX4nJhRHdVhZ/mnR6mK5sgKv5cPTsF8ZT47nBAcFxC1Twypb45LlJ2wnEXbAlY4FGIGw9UKb8t7ARDWtia4QdWflW2zpuaaoHHsbT/642fC+dPz+EKUARxGwDVATCdQwxdPySG/pePxHg7laNBhrUXGWz2nhqt+AMVEQDnbPfFkFMQEldUke67JIDcjAtnJLmV5hAOg5MBeSnyTRTmD+5eV3vUrdlyuKIHS9RfmdpcXEb77adlcdMEcxfIVl9NYNd8dTmeGvRbyXF5mYHK+sjph8NyvBwzVDNHXroyMzyXj8NuSCma2gjsrmH2MUgAb+ZswtmMSrM/N8wx51jrZeNm1uj2hQNBSVuP66L2fPmUNIyTGf20Wuy1Jq+5WjaBA+wmf/QMLJ5EdSzJZEdzWGqWIjxn0BVTtlvGkUmE7gRLzD2sR+FKuWvCJtt5J/uMqZU5RmAYIkeHJwMtu/9haOAjss5LHV/y+1IHLG0jH2WJjkTmGBJtq6heteHj89mjhU71SyFezJ8t1RNgnJpjPiIaUAOdwpIOKd5G80MPMUlYWAuy4ebNzDXyoiR7k= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(136003)(39860400002)(396003)(376002)(346002)(451199021)(46966006)(36840700001)(40470700004)(6506007)(9686003)(53546011)(26005)(81166007)(107886003)(356005)(41300700001)(47076005)(7696005)(336012)(186003)(36860700001)(40460700003)(34020700004)(478600001)(54906003)(82310400005)(70206006)(82740400003)(70586007)(55016003)(40480700001)(316002)(4326008)(52536014)(5660300002)(33656002)(2906002)(86362001)(8676002)(6862004)(8936002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2023 14:02:58.6017 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 52b1a3cf-834f-4be5-7117-08db47f145ca X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5651 X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > On the check for verbose=3D=3D2, should that be verbose >=3D 2 ? >=20 That's fair enough. Made the change. Thanks, Tamar. > paul >=20 > > On Apr 28, 2023, at 6:38 AM, Tamar Christina via Gcc-patches patches@gcc.gnu.org> wrote: > > > > Hi All, > > > > genmatch currently outputs commented out line directives that have no > > effect but the compiler still has to parse only to discard. > > > > They are however handy when debugging genmatch output. As such this > > moves them behind the -vv flag. > > > > Bootstrapped Regtested on aarch64-none-linux-gnu and no issues. > > > > Ok for master? > > > > Thanks, > > Tamar > > > > gcc/ChangeLog: > > > > PR bootstrap/84402 > > * genmatch.cc (output_line_directive): Only emit commented directive > > when -vv. > > (main): Initialize verbose. > > > > --- inline copy of patch -- > > diff --git a/gcc/genmatch.cc b/gcc/genmatch.cc index > > > 638606b2502f640e59527fc5a0b23fa3bedd0cee..6d62cdea2082d92e5ecc1 > 102c802 > > 05115a4e3040 100644 > > --- a/gcc/genmatch.cc > > +++ b/gcc/genmatch.cc > > @@ -209,7 +209,7 @@ output_line_directive (FILE *f, location_t location= , > > else > > fprintf (f, "%s:%d", file, loc.line); > > } > > - else > > + else if (verbose =3D=3D 2) > > /* Other gen programs really output line directives here, at least = for > > development it's right now more convenient to have line informat= ion > > from the generated file. Still keep the directives as comment > > for now @@ -5221,6 +5221,7 @@ main (int argc, char **argv) > > return 1; > > > > bool gimple =3D true; > > + verbose =3D 0; > > char *input =3D argv[argc-1]; > > for (int i =3D 1; i < argc - 1; ++i) > > { > > > > > > > > > > -- > >