From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2044.outbound.protection.outlook.com [40.107.8.44]) by sourceware.org (Postfix) with ESMTPS id 776423858D39 for ; Mon, 6 Mar 2023 12:12:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 776423858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tan7SjRlBJJ9aptw5LN34Mckjf+pWjo3LPaIUI/rmk0=; b=8ECgw2MIYMgjGGd6TQqc5coWSLTpG7lzDNO9VOIX6upLnt9zPmCLaF232f0qZmKFuu6hi1E8QDq+dOkxA5KvzeFezzGyTXLpcu/FKXwk3k/8TN0114l42vz7bcliEwa/SvziGAzl3qXCufZ+bwFpvEF1jugs4e++ctVIV3eofrE= Received: from AS9PR06CA0759.eurprd06.prod.outlook.com (2603:10a6:20b:484::13) by PAWPR08MB8814.eurprd08.prod.outlook.com (2603:10a6:102:336::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.28; Mon, 6 Mar 2023 12:12:02 +0000 Received: from VI1EUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:484:cafe::b9) by AS9PR06CA0759.outlook.office365.com (2603:10a6:20b:484::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.28 via Frontend Transport; Mon, 6 Mar 2023 12:12:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT055.mail.protection.outlook.com (100.127.144.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.28 via Frontend Transport; Mon, 6 Mar 2023 12:12:01 +0000 Received: ("Tessian outbound cfb430c87a1e:v135"); Mon, 06 Mar 2023 12:12:01 +0000 X-CR-MTA-TID: 64aa7808 Received: from 340db709e278.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D133317F-62BF-48D3-98D9-F274F91C5E80.1; Mon, 06 Mar 2023 12:11:51 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 340db709e278.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 06 Mar 2023 12:11:51 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mfp3Gs97CMtDPwOcbHOmnl0Fc0/IOWJQ18nKD8FKn0SX9sAvNWhgl5vdY7z0R+cCXe7lep/OOP74r6JFL2pU0+nwKQLKDh0RgrVvF54GUSr5iR1k58ezmK3Z5dKXNpAZQDevKHf360x4yV47ybiUe5RG7A4vhhzIF5DdLyvJSSn0O2yHhm6Iwxb8U6BILMks/sdYpti3yYgNedOCl2vlmliidGYZbOImTUCDxQw23lG3cOZy5tvo/w1LEp19AYYLbxHs7xqofOD69B+KeF66Q5WMs9czTT81dyLfMYP+TGj08pNb5lfzF9GgXnEb5Z7grWgA0sMDS2F0i+5RFRy46A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Tan7SjRlBJJ9aptw5LN34Mckjf+pWjo3LPaIUI/rmk0=; b=OVBi8pAnwgAhQGckwwZJZQco3xj77rJ0VvmLyAVQh4xlDyE1AXjcUZGEv50XKvRNKU4NPFvHeaLoObM4to0bVuSbsiDahkBE0mcLK61QhBDAhzTnyWZ/dSYUav38oE08aDgOd+OqV/C0SmRUUyW9kfC+32gqGbSfvhKJ0q+vDK7Wn/rAVwepNuXMk+vxPf2Yor+VEwsYYHVtuyuMxrr65bS0H9juCIPicl61/UchECsjg/J7jroUP74xN/Z5aRcYrQqYrPjimq0xTJ2oNbknukiB8f8RMgagNyaJfc58j1YiUpo7uIfyibYHrw7+angwBITdktckcjL5ZSY0aaKAlQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tan7SjRlBJJ9aptw5LN34Mckjf+pWjo3LPaIUI/rmk0=; b=8ECgw2MIYMgjGGd6TQqc5coWSLTpG7lzDNO9VOIX6upLnt9zPmCLaF232f0qZmKFuu6hi1E8QDq+dOkxA5KvzeFezzGyTXLpcu/FKXwk3k/8TN0114l42vz7bcliEwa/SvziGAzl3qXCufZ+bwFpvEF1jugs4e++ctVIV3eofrE= Received: from VI1PR08MB5325.eurprd08.prod.outlook.com (2603:10a6:803:13e::17) by AS8PR08MB10363.eurprd08.prod.outlook.com (2603:10a6:20b:56b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.23; Mon, 6 Mar 2023 12:11:48 +0000 Received: from VI1PR08MB5325.eurprd08.prod.outlook.com ([fe80::210c:d369:23f7:84fe]) by VI1PR08MB5325.eurprd08.prod.outlook.com ([fe80::210c:d369:23f7:84fe%9]) with mapi id 15.20.6156.028; Mon, 6 Mar 2023 12:11:47 +0000 From: Tamar Christina To: Segher Boessenkool CC: Jeff Law , Roger Sayle , 'GCC Patches' , Richard Sandiford Subject: RE: [PATCH] PR rtl-optimization/106594: Preserve zero_extend in combine when cheap. Thread-Topic: [PATCH] PR rtl-optimization/106594: Preserve zero_extend in combine when cheap. Thread-Index: AdlOxlGLdZf5RsEKSy2T3BJGVUY5jAAINXiAACxOqpwAAQhMAAABluygAAHR/QAAHpABAAAACihA Date: Mon, 6 Mar 2023 12:11:47 +0000 Message-ID: References: <000c01d94ec7$a6921430$f3b63c90$@nextmovesoftware.com> <20230304221749.GK25951@gate.crashing.org> <3b1ed616-5d90-7a66-63b5-bdb5e320eebf@gmail.com> <20230305213340.GL25951@gate.crashing.org> <20230306120846.GM25951@gate.crashing.org> In-Reply-To: <20230306120846.GM25951@gate.crashing.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: DC2961520A927442922671B21D7DE502.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: VI1PR08MB5325:EE_|AS8PR08MB10363:EE_|VI1EUR03FT055:EE_|PAWPR08MB8814:EE_ X-MS-Office365-Filtering-Correlation-Id: 191e97d2-467c-4072-5a47-08db1e3bfe20 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: BhhhV7DaVfoEA2VX82nEE63DNCFwsz9+5LuoZi474408Tp7x2XA+GkvesnffxKI3FM70sxeP/GuMr9Srjj0bAlDOfzkcvsJ38hu3SJlMIQHbt+Ixqe6iqZNh9A1TT76Lel3z4vPOXhbkYuH1w+U0Ec774naur3wStvFK1LJXmczb6Z25TYM76O+pkp53z7aJgrB9v0dULGbESEVhAj/KkSkI8qQFBrEwAe2ow97/qC8kI6i6eAJm2pfCJF7Mn85Lx1+oBH+1axsgcaobnc5r9L5w9u9Kf2Ub6AJexNTBlphB+MIGTtO7QlpBeMqVKSiPh7mUn71S+QhepHBTdKXq2s3qKYEOFysoh535Ql5vTggvzYKGk4grdsAR3VFOO/1x6iI+Vbk5oyFI6ClvIkYasPKFsLpB2gPvBOmxippgzU+FduaDNs9XCm/jlHoJORttcEwFTRUyohch0gVwjBHO55YrQZ+CpFV3IDDqP1v0bJdumbBbX3ABAHWFF1Oy5rMEDQ/k4U7a1NtY1ola6i8YkSBeKnoGTHUAsdz8KEDekT1zEM9EncvkQCNIymDdm3mv/SqZYgwJIjv8rwIPjNUpNiOX3+WHnRhjJ8QkQ04cXP0hAJHKfB/ztnB8lkaKEzLZmCv0n5MCwcKeWbdJNxsNxiqXQt3iNMKBpCJnpn3EcpWrPtVrGbebBOsM8VVS4wqCVU9EHYE/tk/to4Q5aUpQ5Bp8Ugyvq8haFp7yytwUB/8= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB5325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(396003)(346002)(376002)(366004)(39860400002)(451199018)(33656002)(478600001)(7696005)(52536014)(9686003)(186003)(6506007)(26005)(41300700001)(66446008)(76116006)(2906002)(66556008)(6916009)(8936002)(4326008)(66946007)(8676002)(66476007)(86362001)(64756008)(5660300002)(71200400001)(38100700002)(38070700005)(54906003)(55016003)(316002)(122000001)(158353003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB10363 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2b5141b7-72f5-4feb-900e-08db1e3bf58a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EvG7l0jElomaSGUAciRdBTOGE/59fJ/SAJFL5LpyTjPQ9mOLxxJhKhyD7A0g39c3/EtfZ9c1NPM37cbi6oogK74zAyR4mIzX4iyC3FT+L2na0HwW47CJq1N6KJ7C0WJ6AvzzQPYaP1OXWSw1eS1dJjOwmZZSNVHUJuUxS1b7/bqLjdVBiX+8QqlcpnHKcH6nBhQ+xiB3w3v2uzfSekAK1eQuPB7IQ4cwhASuJbV4HEcpPT2yR4w/hJ3KFk8Y/SMAHeq+j70eTtrcfmosbeUpRv2/GPlJYVZzSUZLNpD3PBjXTKuhwO/nbQ9F+CLO/hkPAIhNg1/Kq7OfMU8/+OW7d7sU4sxogMULJqgDbK6n/w7jZ2BqiZof4drXcXWNs5SN9pDo7dLwbisWGDV4VReQb0qhufdK+k+XZfMjkkU3eLitvhfExFjO2a4IfmG8jIxOHMgEHyEkTDFchPB/BW2TdJ06pXAIerUbdcT+IloeXQ1lh78bxejzL0yr7wSgwAB/u97d67tKpPjBGhPewt/m2R1W7pEPUa8KR84es+sYs/PTfoCTrEjUcJfb1cNe8cl+VQnLbs3l4872PDtMGLZfAuMWUXnWy+ptkrJx6megMnSn0GZtB9TXWQ4MzD9LO22aHc1U85GMCmEVFipgO4JrmY2hUtRGqgiinCwb9DzwIGeIHIcBkWO3GHaqXe9SIqx7Rk5Y/OzaYRlxPIxGn7gvP4rQ+gpCZQKHDGmp1VlWv/Y= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(396003)(136003)(376002)(346002)(39860400002)(451199018)(36840700001)(46966006)(40470700004)(40460700003)(9686003)(186003)(356005)(81166007)(52536014)(6862004)(8936002)(36860700001)(41300700001)(4326008)(8676002)(2906002)(82740400003)(5660300002)(70206006)(70586007)(7696005)(478600001)(47076005)(6506007)(26005)(316002)(54906003)(40480700001)(33656002)(82310400005)(86362001)(55016003)(336012)(158353003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2023 12:12:01.7400 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 191e97d2-467c-4072-5a47-08db1e3bfe20 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB8814 X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Hi! >=20 > On Sun, Mar 05, 2023 at 03:33:40PM -0600, Segher Boessenkool wrote: > > On Sun, Mar 05, 2023 at 08:43:20PM +0000, Tamar Christina wrote: > > Yes, *look* better: I have seen no proof or indication that this would >=20 > ("looks", I cannot type, sorry) >=20 > > actually generate better code, not even on just aarch, let alone on > > the majority of targets. As I said I have a test running, you may be > > lucky even :-) It has to run for about six hours more and after that > > it needs analysis still (a few more hours if it isn't obviously always > > better or worse), so expect results tomorrow night at the earliest. >=20 > The results are in: >=20 > $ perl sizes.pl --percent C[12] > C1 C2 > alpha 7082243 100.066% > arc 4207975 100.015% > arm 11518624 100.008% > arm64 24514565 100.067% > armhf 16661684 100.098% > csky 4031841 100.002% > i386 0 0 > ia64 20354295 100.029% > m68k 4394084 100.023% > microblaze 6549965 100.014% > mips 10684680 100.024% > mips64 8171850 100.002% > nios2 4356713 100.012% > openrisc 5010570 100.003% > parisc 8406294 100.002% > parisc64 0 0 > powerpc 11104901 99.992% > powerpc64 24532358 100.057% > powerpc64le 21293219 100.062% > riscv32 2028474 100.131% > riscv64 9515453 100.120% > s390 20519612 100.279% > sh 0 0 > shnommu 1840960 100.012% > sparc 5314422 100.004% > sparc64 7964129 99.992% > x86_64 0 0 > xtensa 2925723 100.070% >=20 >=20 > C1 is the original, C2 with your patch. These numbers are the code sizes= of a > Linux kernel, some defconfig for every arch. This is a good measure of h= ow > effective combine was. >=20 > The patch is a tiny win for sparc64 and classic powerpc32 only, but bad > everywhere else. Look at that s390 number! Or riscv, or most of the arm > variants (including aarch64). >=20 > Do you want me to look in detail what causes this regression on some > particular target, i.e. why we really still need the expand_compound > functionality there? >=20 Hi, Thanks for having a look! I think the Richards are exploring a different so= lution on the PR so I don't think it's worth looking at now (maybe in stage-1?). Thanks for= checking though! I Appreciate you all helping to get this fixed! Kind Regards, Tamar > (Btw. "0" means the target did not build. For the x86 targets this is j= ust more > -Werror madness that seeped in it seems. For parisc64 and sh it is the c= hoice > of config. Will fix.) >=20 >=20 > Segher