From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-40134.protonmail.ch (mail-40134.protonmail.ch [185.70.40.134]) by sourceware.org (Postfix) with ESMTPS id 068CB3858D1E for ; Sat, 18 Nov 2023 06:43:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 068CB3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=protonmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 068CB3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=185.70.40.134 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700289836; cv=none; b=I1O78UQ4i4vIW5lqpfK8EY4xEBP/vyhtpy9ZX/rPXvTEMwkE43VKaC5DEC8t0kJX7YxJhAutgb8rmy8HB33n7qEniZJrGj0ljBWuTp+PGiTcEDr6HFD4SdnTPTuMor7eFVVPPh7VdfEmuCGny3/ojAwdKyK1cnirIqdLTon3gmU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700289836; c=relaxed/simple; bh=u9NIJZp98wYwUF1tXaeKNI6TgshKI2BknLn5KH9t6bw=; h=DKIM-Signature:Date:To:From:Subject:Message-ID:MIME-Version; b=pPkbyrHiISWZQ3n3MJCgdhbl2wgegaepQELwTz8MggqD7ngMxEUUedAKQS4rTOXtHhhls4XykJD4KtH3TcB1ihP61HuiN6pV1jwYN4H6mHIo2k5D9dzaV/FJJvu6tFDudx+ZdfM6v1D/UwOBvxW81POzc9NMb46B9Sh59T/QnKM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1700289832; x=1700549032; bh=9utvNtJcQLmJ/YZk1j1nBJMApF6yJDGjEcEWA+igqX0=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=g6XR2Q+ozySmxkfEalPKrjinyscZcliGEXUuBOF6gwVttW+s5PljZ5v47S7r+QLbb UVtCBPikdsDF0beHIUYUDEqUdja1LJnYTgRUhzb5RbF+1yHt/yi5zX5pe3iWiwVxX2 KNHRrZGRYkWM98ZyHpUXAV8MIpEkybHUE6C46Qd5FPbqW8xywpUX/IL4/0+Fxw4rM3 58F+SBZ0rFXNFLWQ+xmF4N3kN10tv6Y054xWDDR0PPWHRBE5cJmusfhIC2eMTm7Wn0 K7MgKWqlQW+VOdvEN0MT7ePUKNP7+JFaD3C8iQfcnQ8ElrvUDUclWx7LnYkMYUn05y 6WMmO0epyF7vQ== Date: Sat, 18 Nov 2023 06:43:34 +0000 To: waffl3x From: waffl3x Cc: Jason Merrill , "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH v3 1/2] c++: Initial support for P0847R7 (Deducing This) [PR102609] Message-ID: In-Reply-To: References: <2nV4Jls2nmL2lahW6X-HZsBb90H1QZJhy3ApVC8xpxvP6KUYDriDYJpxzqjDnshOUEQ6ehYzuXU6rJmPvj3l6jtqAniFlH4Buyfls4E8cfY=@protonmail.com> <00094736-8325-4c83-9237-a6c15c324c24@redhat.com> <3tSXKK_P5IpLLm2VJ76q-eiLPZhiaC6_ZpwOrej22LWsmGA_YXipLXwLdLNeFlShJaqpFH_LPQW6tqkPD1WlFnExnL-iDoW9CoA-KQETWYw=@protonmail.com> Feedback-ID: 14591686:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TO_EQ_FM_DIRECT_MX,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The patch is coming along, I just have a quick question regarding style. I make use of IILE's (immediately invoked lambda expression) a whole lot in my own code. I know that their use is controversial in general so I would prefer to ask instead of just submitting the patch using them a bunch suddenly. I wouldn't have bothered either but this part is really miserable without them. If that would be okay, I would suggest an additional exception to bracing style for lambdas. This: [](){ // stuff }; Instead of this: []() { // stuff }; This is especially important for IILE pattern IMO, else it looks really mediocre. If this isn't okay okay I'll refactor all the IILE's that I added, or just name them and call them instead. Whatever you think is most appropriate. Alex