From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 5EC703858D33 for ; Wed, 1 Mar 2023 12:32:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5EC703858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677673971; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=VNTMLKgPcaz0tPrCdjyxel3ESkDDJfoj2Bxt507Uyuk=; b=TEOKtM2bKpFtyaviaIHF7o6LGFDwH9X9Y7YVJWp+qd+5bOrnJsQKQRB4yJj2RlM3GMRbts Pzz6sowXEMROTp/AB1xJZHpNjuV7rcx9j9TEo3S7bs1BpS5Mm8aprbyTA/ALiTQrwfUBbQ MKloDK5espCv7CBHEmXcE9zqFyGKdXI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-613-hxlK5lrRO8-w78TTFUnbtw-1; Wed, 01 Mar 2023 07:32:50 -0500 X-MC-Unique: hxlK5lrRO8-w78TTFUnbtw-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 39170800B23; Wed, 1 Mar 2023 12:32:49 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DF841492C14; Wed, 1 Mar 2023 12:32:48 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 321CWj9p1630615 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 1 Mar 2023 13:32:45 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 321CWh2m1630614; Wed, 1 Mar 2023 13:32:43 +0100 Date: Wed, 1 Mar 2023 13:32:43 +0100 From: Jakub Jelinek To: Ian Lance Taylor , "Joseph S. Myers" Cc: gcc-patches@gcc.gnu.org Subject: Patch ping: Re: [PATCH] libgcc, i386, optabs, v2: Add __float{, un}tibf to libgcc and expand BF -> integral through SF intermediate [PR107703] Message-ID: Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi! On Wed, Nov 16, 2022 at 12:51:14PM +0100, Jakub Jelinek via Gcc-patches wrote: > On Wed, Nov 16, 2022 at 10:06:17AM +0100, Jakub Jelinek via Gcc-patches wrote: > > Thoughts on this? I guess my preference would be the BF -> SF -> TI > > path because we won't need to waste > > 32: 0000000000015e10 321 FUNC GLOBAL DEFAULT 13 __fixbfti@@GCC_13.0.0 > > 89: 0000000000015f60 299 FUNC GLOBAL DEFAULT 13 __fixunsbfti@@GCC_13.0.0 > > If so, I'd need to cut the fix parts of the patch below and > > do something in the middle-end. > > Here is adjusted patch that does that. > > 2022-11-16 Jakub Jelinek > > PR target/107703 > * optabs.cc (expand_fix): For conversions from BFmode to integral, > use shifts to convert it to SFmode first and then convert SFmode > to integral. > > * soft-fp/floattibf.c: New file. > * soft-fp/floatuntibf.c: New file. > * config/i386/libgcc-glibc.ver: Export __float{,un}tibf @ GCC_13.0.0. > * config/i386/64/t-softfp (softfp_extras): Add floattibf and > floatuntibf. > (CFLAGS-floattibf.c, CFLAGS-floatunstibf.c): Add -msse2. I'd like to ping the libgcc non-i386 part of this patch, Uros said the i386 part is ok but that one depends on the generic libgcc changes. I'll ping the optabs.cc change separately. https://gcc.gnu.org/pipermail/gcc-patches/2022-November/606398.html with more info in https://gcc.gnu.org/pipermail/gcc-patches/2022-November/606382.html Thanks. Jakub