From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 883203858D33 for ; Wed, 1 Mar 2023 12:42:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 883203858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677674553; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=roSoRPFjn+lpJNDQZqiebMVDiChhpJu2yeWOJvW9rdk=; b=TijKBFxqKtst+wllEsCsPv9e89QykxIhy1AuH4nV1vpdnkHOMuLLRm9/Du1qWCH5hqSPHy sZNKv9CmezynJ+Z0nt0LVFTLOiXv5fRjEqttdyHcwugl80hJB0sxdSOaw0DsfyJxipgq61 PwX5XbD6Ic243C9/u4udHvyMvlnHgGA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-394-VVa7SViCMJGpWfKZVbO27w-1; Wed, 01 Mar 2023 07:42:32 -0500 X-MC-Unique: VVa7SViCMJGpWfKZVbO27w-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DC37E183B3C1; Wed, 1 Mar 2023 12:42:31 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9A79FC15BAD; Wed, 1 Mar 2023 12:42:31 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 321CgSLP1630669 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 1 Mar 2023 13:42:29 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 321CgSxY1630668; Wed, 1 Mar 2023 13:42:28 +0100 Date: Wed, 1 Mar 2023 13:42:28 +0100 From: Jakub Jelinek To: Tobias Burnus Cc: gcc-patches , fortran Subject: Re: [Patch] OpenMP/Fortran: Fix handling of optional is_device_ptr + bind(C) [PR108546] Message-ID: Reply-To: Jakub Jelinek References: <452ab67b-34f5-d816-436d-33f8f9ac44d4@codesourcery.com> MIME-Version: 1.0 In-Reply-To: <452ab67b-34f5-d816-436d-33f8f9ac44d4@codesourcery.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Feb 28, 2023 at 05:18:25PM +0100, Tobias Burnus wrote: > OpenMP/Fortran: Fix handling of optional is_device_ptr + bind(C) [PR108546] > > For is_device_ptr, optional checks should only be done before calling > libgomp, afterwards they are NULL either because of absent or, by > chance, because it is unallocated or unassociated (for pointers/allocatables). > > Additionally, it fixes an issue with explicit mapping for 'type(c_ptr)'. > > PR middle-end/108546 > > gcc/fortran/ChangeLog: > > * trans-openmp.cc (gfc_trans_omp_clauses): Fix mapping of > type(C_ptr) variables. > > gcc/ChangeLog: > > * omp-low.cc (lower_omp_target): Remove optional handling > on the receiver side, i.e. inside target (data), for > use_device_ptr. > > libgomp/ChangeLog: > > * testsuite/libgomp.fortran/is_device_ptr-3.f90: New test. > * testsuite/libgomp.fortran/use_device_ptr-optional-4.f90: New test. Ok, thanks. Jakub