From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id D03B13858D33 for ; Wed, 1 Mar 2023 13:09:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D03B13858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677676181; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=YS8ScVHPMEMHZdO8g6wM0w+SK1bnNP4A9IMYxq1/DrE=; b=CxtXflKk/E9aoK65FYYyiSEABJxiriDFWiKzQ8ESbXU/H4M1jGqtVKr9QuYKNmumT1KAEb y+l+pTT5X095otOkh509kfVGG6Q36Z+GFaY6sSlc0TmI6B2f9TEUbYDM5R910s/oOyZgtV A7cVjKdHB1RC1vO7IeUT5AiMX31sVeo= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-47-Eh_0Cp4ZOuGJhozwDc2sPA-1; Wed, 01 Mar 2023 08:09:40 -0500 X-MC-Unique: Eh_0Cp4ZOuGJhozwDc2sPA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DD38F1C1742F; Wed, 1 Mar 2023 13:09:39 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A08022166B26; Wed, 1 Mar 2023 13:09:39 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 321D9bR51630857 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 1 Mar 2023 14:09:37 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 321D9ann1630856; Wed, 1 Mar 2023 14:09:36 +0100 Date: Wed, 1 Mar 2023 14:09:36 +0100 From: Jakub Jelinek To: Richard Biener Cc: gcc-patches@gcc.gnu.org, jason@redhat.com Subject: Re: [PATCH] debug/108772 - ICE with late debug generated with -flto Message-ID: Reply-To: Jakub Jelinek References: <01327.123030108070400465@us-mta-295.us.mimecast.lan> MIME-Version: 1.0 In-Reply-To: <01327.123030108070400465@us-mta-295.us.mimecast.lan> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Mar 01, 2023 at 01:07:02PM +0000, Richard Biener wrote: > When combining -g1 with -flto we run into the DIE location annotation > machinery for globals calling dwarf2out_late_global_decl but not > having any early generated DIE for function scope statics. In > this process we'd generate a limbo DIE since also the function scope > doesn't have any early generated DIE. The limbo handling then tries > to force a DIE for the context chain which ultimatively fails and > ICEs at the std namespace decl because at -g1 we don't represent that. > > The following avoids this situation by making sure to never generate > any limbo DIEs from dwarf2out_late_global_decl in the in_lto_p path > but instead for function scope globals rely on DIE generation for > the function to output a DIE for the local static (which doesn't > happen for -g1). > > I explored a lot of other options to fix this but in the end this > seems to be the most spot-on fix with the least risk of unwanted > effects. > > LTO bootstrapped on x86_64-unknown-linux-gnu (running into PR108984), > bootstrapped and tested on x86_64-unknown-linux-gnu. > > OK? > > Thanks, > Richard. > > PR debug/108772 > * dwarf2out.cc (dwarf2out_late_global_decl): Do not > generate a DIE for a function scope static when we do > not have a DIE for the function already. > > * g++.dg/lto/pr108772_0.C: New testcase. LGTM, but please give Jason a day to chime in if he disagrees. Jakub