From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 26A47385828E for ; Fri, 17 Feb 2023 22:35:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 26A47385828E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676673331; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=lZJ8TZjOegCiACqZYJlfWceiFSSuijpQFlACZ3rLJ8s=; b=NYyOyOgjIdOfUHdDUg6MJ4FSdjDSiZcFrv9fc8v9/vNhFP7waOtvud2b3n591bfABFTfnH 93yIpNlD3UyGb5G4wb2nYJoQ/+S9gnAjGSSYFA0FaQI1owSgkpOrwcv1LwUKBONAvHizHD wT8EDhbv9bIwRVXVZl7C+HsDygN4D7k= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-350-vFRTPuPcMCWfBGwONlGfbw-1; Fri, 17 Feb 2023 17:35:27 -0500 X-MC-Unique: vFRTPuPcMCWfBGwONlGfbw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 20FC3185A78B; Fri, 17 Feb 2023 22:35:27 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.211]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D6084C15BA0; Fri, 17 Feb 2023 22:35:26 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 31HMZOJp503019 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 17 Feb 2023 23:35:24 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 31HMZNlZ502354; Fri, 17 Feb 2023 23:35:23 +0100 Date: Fri, 17 Feb 2023 23:35:22 +0100 From: Jakub Jelinek To: Qing Zhao Cc: rguenther@suse.de, gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Fixing PR107411 Message-ID: Reply-To: Jakub Jelinek References: <20230217222603.2485714-1-qing.zhao@oracle.com> MIME-Version: 1.0 In-Reply-To: <20230217222603.2485714-1-qing.zhao@oracle.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Feb 17, 2023 at 10:26:03PM +0000, Qing Zhao via Gcc-patches wrote: > + else if (!DECL_NAME (lhs_var)) > + { > + char *lhs_var_name_str > + = xasprintf ("D.%u", DECL_UID (lhs_var)); Why xasprintf? D.%u can be sprintfed into a fixed size automatic buffer, say 3 + (HOST_BITS_PER_INT + 2) / 3 would be a good upper bound for the size of the buffer. Then you don't need to free it... > + if (strcmp (lhs_var_name_str, var_name_str) == 0) > + { > + free (lhs_var_name_str); > + return; > + } > + free (lhs_var_name_str); > + } > + } > gcc_assert (var_name_str && var_def_stmt); > } > } > -- > 2.31.1 Jakub