From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 913323858C83 for ; Wed, 22 Feb 2023 18:11:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 913323858C83 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31MHDsCG009548; Wed, 22 Feb 2023 18:11:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=qPHTdvQPXQdzXdYFedIqHOLso01NPIb32u1n+KFSXWQ=; b=eoLsYLh5qlFQFSUVtbjZgqqAJDy0+VZqymHBZ501Qmsjq11I02sWaXT+/JIoKegQpq52 TPH+XDzqLxUjH15mQ4ZAQsyDKDhueITft1DfJML9A41wlb3UVwVT8lgE7BEh1bA3o4Nu EPw6uSxxDNnrJ4DnMkjdXieVLHDlQ2KUBrNQ1gjL8W0Nyg51nVGXjZ5wkYlvldhcntx9 b2QmaeE8K5QLXTYjeOk1KHD4EPKQYBlU+Bh9QjB2eSB3T0EIrdrurKknxHZ2oHfvp+as l0V6bFpVCvMVsHc5YNuez0PijLJnpi2rVL2pxhNeBtSIA5so/Hvs2CS8Nvc/AgspKuH2 xQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3nwmt4x56d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Feb 2023 18:11:10 +0000 Received: from m0098419.ppops.net (m0098419.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 31MHQonn002660; Wed, 22 Feb 2023 18:11:10 GMT Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3nwmt4x562-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Feb 2023 18:11:10 +0000 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 31MFsNpH000559; Wed, 22 Feb 2023 18:11:09 GMT Received: from smtprelay05.dal12v.mail.ibm.com ([9.208.130.101]) by ppma04dal.us.ibm.com (PPS) with ESMTPS id 3ntpa7fyxm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Feb 2023 18:11:09 +0000 Received: from smtpav06.dal12v.mail.ibm.com (smtpav06.dal12v.mail.ibm.com [10.241.53.105]) by smtprelay05.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 31MIB8PS7078646 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 22 Feb 2023 18:11:08 GMT Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 560FD5805D; Wed, 22 Feb 2023 18:11:08 +0000 (GMT) Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C775058043; Wed, 22 Feb 2023 18:11:07 +0000 (GMT) Received: from toto.the-meissners.org (unknown [9.65.233.34]) by smtpav06.dal12v.mail.ibm.com (Postfix) with ESMTPS; Wed, 22 Feb 2023 18:11:07 +0000 (GMT) Date: Wed, 22 Feb 2023 13:11:06 -0500 From: Michael Meissner To: "Kewen.Lin" Cc: Michael Meissner , gcc-patches@gcc.gnu.org, Segher Boessenkool , David Edelsohn , Peter Bergner , Will Schmidt Subject: Re: [PATCH 1/2] PR target/107299: Fix build issue when long double is IEEE 128-bit Message-ID: Mail-Followup-To: Michael Meissner , "Kewen.Lin" , gcc-patches@gcc.gnu.org, Segher Boessenkool , David Edelsohn , Peter Bergner , Will Schmidt References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-GUID: G-FLvY9_WserOZSuGA_hQ64gNm36PJcQ X-Proofpoint-ORIG-GUID: 84UWLQsfx9k4xSEIgs2EYVj4JFCKD7mD X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-22_06,2023-02-22_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=759 phishscore=0 mlxscore=0 impostorscore=0 adultscore=0 malwarescore=0 priorityscore=1501 suspectscore=0 spamscore=0 clxscore=1011 bulkscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302220157 X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Feb 22, 2023 at 06:37:39PM +0800, Kewen.Lin wrote: > Thanks for working on this! If updating libgcc source to workaround this issue > is the best option we can have at this moment, it's fine. Thanks. Yes, I agree that it does not fix the root issue. > Comparing to one > previous proposal which removes the workaround in build_common_tree_nodes for > rs6000 KFmode, a bit concern on this one is that users can still meet the ICE > with a simple case like: > > typedef float TFtype __attribute__((mode (TF))); > > TFtype > test (TFtype t) > { > return __builtin_copysignf128 (1.0q, t); > } > > but I guess they would write this kind of code very rarely? I tend to think that it is better to consistantly use __float128/_Float128 types with the 'f128' functions, and use long double with the 'l'. It would be nice to fix the root cause (of __float128 and _Float128 not being the same type within the compiler). It is complicated by the fact that until C++2x, you can't use the _Float128 type. You can use the __float128 and __ibm128 extensions, but you can't use those extensions with _Complex. This means for C++, you have to use the __attrbibute__((mode)) to get to the complex type. And due to the way I initially implemented it, whether you use T{C,F}, K{C,F}, and I{C,F} depends on the switches. But without fixing that (which is fairly complex), I really want the master branch fixed so you can build GCC with long double defaulting to IEEE 128-bit. -- Michael Meissner, IBM PO Box 98, Ayer, Massachusetts, USA, 01432 email: meissner@linux.ibm.com