From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B282C3858C5E for ; Thu, 23 Feb 2023 10:49:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B282C3858C5E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677149390; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=WIrEM7T9R9XMl0vS9P3rhAyGTrDp5neTPbzO6pjwAuM=; b=NtMCBwRPsJkTFlale+uUK10wCHgiaPUiLjk9bdToIesweF9C9ysmvCadmLl3Oxk28zDfmE ATsOCKp3eNnikZlHzt4jhGlFVx7GHsrFdya9XCKNgQDbQdBDirxLOHvurFS0WjOjZqTsn+ JHkLJuWqs+9WyhfXCtw1IVxHNaJue2Y= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-102-cwS6ZmvMMsOUtcN6cQuV5Q-1; Thu, 23 Feb 2023 05:49:49 -0500 X-MC-Unique: cwS6ZmvMMsOUtcN6cQuV5Q-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 746481871DB1; Thu, 23 Feb 2023 10:49:48 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.62]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 30BEB4014D1D; Thu, 23 Feb 2023 10:49:48 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 31NAnj4P512037 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 23 Feb 2023 11:49:46 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 31NAnhaT512036; Thu, 23 Feb 2023 11:49:43 +0100 Date: Thu, 23 Feb 2023 11:49:43 +0100 From: Jakub Jelinek To: Yash Shinde Cc: gcc-patches@gcc.gnu.org, raj.khem@gmail.com, Randy.MacLeod@windriver.com, Sundeep.Kokkonda@windriver.com Subject: Re: [PATCH] libgcc_s: Use alias for __cpu_indicator_init instead of symver Message-ID: Reply-To: Jakub Jelinek References: <20230222122333.28218-1-Yash.Shinde@windriver.com> MIME-Version: 1.0 In-Reply-To: <20230222122333.28218-1-Yash.Shinde@windriver.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Feb 22, 2023 at 04:23:33AM -0800, Yash Shinde wrote: > From: Khem Raj > > Adapter from > > https://gcc.gnu.org/ml/gcc-patches/2015-05/msg00899.html > > This fix was debated but hasnt been applied gcc upstream since > they expect musl to support '@' in symbol versioning which is > a sun/gnu versioning extention. This patch however avoids the > need for the '@' symbols at all This is an undesirable ABI change: -__cpu_indicator_init@GCC_4.8.0 FUNC GLOBAL DEFAULT -__cpu_model@GCC_4.8.0 OBJECT GLOBAL DEFAULT 16 +__cpu_indicator_init@@GCC_4.8.0 FUNC GLOBAL DEFAULT +__cpu_model@@GCC_4.8.0 OBJECT GLOBAL DEFAULT 16 So, this is certainly unacceptable. > libgcc/Changelog: > > 2015-05-11 Szabolcs Nagy > > * config/i386/cpuinfo.c (__cpu_indicator_init_local): Add. > (__cpu_indicator_init@GCC_4.8.0, __cpu_model@GCC_4.8.0): Remove. > > * config/i386/t-linux (HOST_LIBGCC2_CFLAGS): Remove -DUSE_ELF_SYMVER. > > gcc/Changelog: > > 2015-05-11 Szabolcs Nagy > > * config/i386/i386-expand.c (ix86_expand_builtin): Make __builtin_cpu_init > call __cpu_indicator_init_local instead of __cpu_indicator_init. Jakub