From: Jakub Jelinek <jakub@redhat.com>
To: Jason Merrill <jason@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH RFC] c++: static_assert (false) in template [DR2518]
Date: Fri, 17 Feb 2023 22:00:55 +0100 [thread overview]
Message-ID: <Y+/rB1MOTkHnBO+Q@tucnak> (raw)
In-Reply-To: <20230217203209.2141339-1-jason@redhat.com>
On Fri, Feb 17, 2023 at 03:32:09PM -0500, Jason Merrill via Gcc-patches wrote:
> Tested x86_64-pc-linux-gnu. This isn't really a regression fix, but it's very
> safe, and fixes a longstanding annoyance, so I'm leaning toward putting it into
> GCC 13. Thoughts?
I think it is ok for GCC 13.
I bet for the testsuite coverage of the whole DR2518 wording we have already
tons of testcases which verify we actually error on #error directives and
warn on #warning directives and error in failed static_assert unless in
uninstantiated templates that it isn't worth repeating them in the
dr2518*.C testcase(s).
I'm a little bit surprised we didn't check for errors from static_asserts
failed asserts in uninstantiated templates...
Jakub
next prev parent reply other threads:[~2023-02-17 21:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 20:32 Jason Merrill
2023-02-17 21:00 ` Jakub Jelinek [this message]
2023-02-17 22:45 ` Marek Polacek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+/rB1MOTkHnBO+Q@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).