From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 1F6073858C62 for ; Wed, 8 Feb 2023 17:15:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1F6073858C62 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675876507; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=GVO0y4gwSU9JbW4QbMuHGV3l7a3afeN9wHw4QbMVj0U=; b=BYjWGjionuBL8m8+6PFe4jojUV1xR1Ikx7raf7Ne1m21XEwDWC3ooVXZ8jeVEV6dxHGqhf uuk504+N6UGL90cRKQmHSQgIoOLDSRmKPyJwj4/7a/7C+Eqezq+2oUupbgkY5fUviJiE+C Tsfg1Ball2WLs2gJqYdRm7J0fSiq7K8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-171-GXOBk5giMeGsbaUuTJijWA-1; Wed, 08 Feb 2023 12:15:04 -0500 X-MC-Unique: GXOBk5giMeGsbaUuTJijWA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A29B8857F49; Wed, 8 Feb 2023 17:15:03 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.223]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 616CD175AD; Wed, 8 Feb 2023 17:15:03 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 318HF0Vp3955380 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 8 Feb 2023 18:15:00 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 318HExf43955379; Wed, 8 Feb 2023 18:14:59 +0100 Date: Wed, 8 Feb 2023 18:14:58 +0100 From: Jakub Jelinek To: Jan Hubicka Cc: Richard Biener , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] cgraph: Handle simd clones in cgraph_node::set_{const,pure}_flag [PR106433] Message-ID: Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Feb 08, 2023 at 06:10:08PM +0100, Jan Hubicka wrote: > My understanding of simd clones is bit limited, but I think you are > right that they should have the same semantics as their caller. > > I think const may be one that makes compiler to ICE, but > there are many other places where function body is analyzed and all its > aliases/thunks and other variants should be updated too. For exmaple > set_pure_flag, nothrow, noreturn and analysis done by modref, > ipa-refernece etc. > > I wonder if we want to update them all and hide that in some > abstraction? Next stage 1 I can work on inventing iterators for those > kind of things as current approach combinindg direct walkters and > function wrappers has become bit hard to maintain in cases like this. I think it depends on whether we do that analysis or update it post IPA or not. Because simd clones are created very late during IPA, if say the nothrow, noreturn, modref etc. analysis is done only during IPA or before it, we don't need to walk the simd clones. It is just for late GIMPLE analysis that changes flags that later on could be used in callers of those functions. pure/const flag is what I know can happen this late, what else? Jakub