From: Jan Hubicka <hubicka@ucw.cz>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Richard Biener <rguenther@suse.de>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] cgraph: Handle simd clones in cgraph_node::set_{const,pure}_flag [PR106433]
Date: Wed, 8 Feb 2023 18:27:46 +0100 [thread overview]
Message-ID: <Y+PbksO2Rz/tnVOa@kam.mff.cuni.cz> (raw)
In-Reply-To: <Y+PYknbDVKklfdwS@tucnak>
> On Wed, Feb 08, 2023 at 06:10:08PM +0100, Jan Hubicka wrote:
> > My understanding of simd clones is bit limited, but I think you are
> > right that they should have the same semantics as their caller.
> >
> > I think const may be one that makes compiler to ICE, but
> > there are many other places where function body is analyzed and all its
> > aliases/thunks and other variants should be updated too. For exmaple
> > set_pure_flag, nothrow, noreturn and analysis done by modref,
> > ipa-refernece etc.
> >
> > I wonder if we want to update them all and hide that in some
> > abstraction? Next stage 1 I can work on inventing iterators for those
> > kind of things as current approach combinindg direct walkters and
> > function wrappers has become bit hard to maintain in cases like this.
>
> I think it depends on whether we do that analysis or update it post IPA
> or not. Because simd clones are created very late during IPA, if say
> the nothrow, noreturn, modref etc. analysis is done only during IPA or
> before it, we don't need to walk the simd clones.
> It is just for late GIMPLE analysis that changes flags that later on
> could be used in callers of those functions.
> pure/const flag is what I know can happen this late, what else?
We have late pure/const (doing pure, const, nothrow, noreturn), modref
(which also discovers pure/const attributes and produces its own
summaries) and except.c at the very end of copimlation can set notrow
flag...
This is all I can think of.
Honza
>
> Jakub
>
prev parent reply other threads:[~2023-02-08 17:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 8:36 Jakub Jelinek
2023-02-07 9:28 ` Richard Biener
2023-02-08 17:10 ` Jan Hubicka
2023-02-08 17:14 ` Jakub Jelinek
2023-02-08 17:27 ` Jan Hubicka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+PbksO2Rz/tnVOa@kam.mff.cuni.cz \
--to=hubicka@ucw.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).