From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 665113858C50 for ; Thu, 9 Feb 2023 10:25:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 665113858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675938338; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=fZRZ0ZICidofyhcRgaoC+Qyq3gvZoANN6IOumJ26ahs=; b=inCkAMHKROUD6Rgbbnw0qMCfDLCPUATo/r0R70PLKG/AnR9ookFO8mm2d4GFA5Z/Q/jaHy H7f0rGpG03oHo2ayrTnTBmcnmooAo9eelM5NeH/39jv5Iinr50ePns8KMxIz/USmkJWxMT 0dwzRAvsLepgIyGpfYj+7lC84Rz9ZBk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-664-KHDzb8_EOSq8k48xkSW3zA-1; Thu, 09 Feb 2023 05:25:37 -0500 X-MC-Unique: KHDzb8_EOSq8k48xkSW3zA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2B98518483B3; Thu, 9 Feb 2023 10:25:37 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.223]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DF50A1121318; Thu, 9 Feb 2023 10:25:36 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 319APYAD1922622 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 9 Feb 2023 11:25:34 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 319APXWi1922621; Thu, 9 Feb 2023 11:25:33 +0100 Date: Thu, 9 Feb 2023 11:25:33 +0100 From: Jakub Jelinek To: Tobias Burnus Cc: gcc-patches Subject: Re: [Patch] OpenMP: Parse align clause in allocate directive in C/C++ Message-ID: Reply-To: Jakub Jelinek References: <857e44cb-92ce-7f1d-c036-579d2e345107@codesourcery.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Feb 09, 2023 at 11:16:39AM +0100, Tobias Burnus wrote: > Any further comments before I commit it? > OpenMP: Parse align clause in allocate directive in C/C++ > > gcc/c/ChangeLog: > > * c-parser.cc (c_parser_omp_allocate): Parse align > clause and check for restrictions. > > gcc/cp/ChangeLog: > > * parser.cc (cp_parser_omp_allocate): Parse align > clause. The " and check for restrictions" part now applies also to C++... > + if (expr != error_mark_node) > + alignment = expr; > + /* FIXME: Remove when adding check to semantic.cc; cf FIXME below. */ s/semantic.cc/semantics.cc/ Ok with those nits fixed. Jakub