From: Jakub Jelinek <jakub@redhat.com>
To: Richard Biener <rguenther@suse.de>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] tree-optimization/108691 - indirect calls to setjmp
Date: Mon, 13 Feb 2023 13:46:56 +0100 [thread overview]
Message-ID: <Y+oxQBPcBdaW6JjO@tucnak> (raw)
In-Reply-To: <nycvar.YFH.7.77.849.2302131236120.9226@jbgna.fhfr.qr>
On Mon, Feb 13, 2023 at 12:41:48PM +0000, Richard Biener wrote:
> > Could we e.g. prevent turning such indirect calls into direct calls?
>
> We do exactly have gimple_call_fntype and gimple_call_ctrl_altering_p
> to not require special-casing indirect to direct call promotion here.
Ah, so if we make returns_twice apply to function types, then we could
just compare if gimple_call_fntype has also returns_twice and if not, not
consider it actually returns_twice.
> > Anyway, notice_special_calls is called in various spots, not just DCE,
> > wouldn't it be better to simply not set calls_setjmp flag in there if
> > the current function already has cfg and the call isn't ctrl altering?
>
> I thought about changing gimple_call_flags instead, filtering out
> ECF_RETURNS_TWICE. I just didn't make up my mind on what
> property to key at (and to require 'cfun' to be set to query it).
> But sure, changing notice_special_calls also works - the only
> other relevant caller is the inliner I think, and that could be
> replaced by caller |= callee of the two flags tracked instead of
> re-scanning each inlined stmt.
>
> Would you be happy with changing notice_special_calls, dropping the
> DCE hunk but keeping the cfgexpand/calls.cc hunks?
I think so.
Jakub
next prev parent reply other threads:[~2023-02-13 12:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 11:00 Richard Biener
2023-02-13 11:14 ` Jakub Jelinek
2023-02-13 12:41 ` Richard Biener
2023-02-13 12:46 ` Jakub Jelinek [this message]
2023-02-13 13:18 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+oxQBPcBdaW6JjO@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).