From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 984D53858D1E for ; Tue, 14 Feb 2023 15:55:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 984D53858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676390154; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=jtWNfeiri9r5Pi4ylXyGjEPYiV5jEHDqfviH9aPDHfg=; b=iQEZDf+DQBgLL6wkDVq2dUXdsjvUcr/sBrqwhvglib0Fce5PwW6fU4CEsmgp7BP1gI8Zjo 3jZBDDumYwtqgWReDwp4KjMuRSfM0rTnkgUcnoHNumMV2F4coPpmczAYvx63yiIk9Jl7ji QI6P5e+OiGdTXGa44PxtZ1zuAImGaXk= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-218-Lkt5El7hPFeG-CoIlX03gw-1; Tue, 14 Feb 2023 10:55:52 -0500 X-MC-Unique: Lkt5El7hPFeG-CoIlX03gw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5FC543814942; Tue, 14 Feb 2023 15:55:52 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.193.203]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1DC3B140EBF6; Tue, 14 Feb 2023 15:55:51 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 31EFtm2O732457 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 14 Feb 2023 16:55:49 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 31EFtmGM732456; Tue, 14 Feb 2023 16:55:48 +0100 Date: Tue, 14 Feb 2023 16:55:47 +0100 From: Jakub Jelinek To: Richard Biener Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Fix possible sanopt compile-time hog Message-ID: Reply-To: Jakub Jelinek References: <20230214152025.2226E138E3@imap2.suse-dmz.suse.de> MIME-Version: 1.0 In-Reply-To: <20230214152025.2226E138E3@imap2.suse-dmz.suse.de> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Feb 14, 2023 at 04:20:24PM +0100, Richard Biener wrote: > While working on bitmap operations I figured sanopt.cc uses > a sbitmap worklist, iterating using bitmap_first_set_bit on it. > That's quadratic since bitmap_first_set_bit for sbitmap is O(n). > > The fix is to use regular bitmaps for the worklist and the bitmap > feeding it and to avoid a useless copy. > > Bootstrap and regtest running on x86_64-unknown-linux-gnu. > > OK for trunk? > > Thanks, > Richard. > > * sanopt.cc (sanitize_asan_mark_unpoison): Use bitmap > for with_poison and alias worklist to it. > (sanitize_asan_mark_poison): Likewise. Ok, thanks. Jakub