From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id ADA5F3858C2F for ; Wed, 15 Feb 2023 10:13:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ADA5F3858C2F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676456037; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=ARKRHybOU/8VVCeYlBk0Y3xZ0KamKlWJoHvzZsW7njw=; b=NV2lJYjTGGH1EtBUDQgPPvvmOklFxj3luusRtGqY1pnS7Ml28cHgdexuliqTsUvkLevQc3 oeeysdb48+5GmIkZQBmtKWKgDBmJHlEKP8cH/acOH/T+cofR7+vCxAG4CzfkwnZYxHkEUh 5is33XJigz7o6ExnjRCIcYgchcmZrL4= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-663-PjzXVqLrMsC0Crnv3yEZPg-1; Wed, 15 Feb 2023 05:13:52 -0500 X-MC-Unique: PjzXVqLrMsC0Crnv3yEZPg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2B15129AB3F2; Wed, 15 Feb 2023 10:13:51 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.193.203]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E15C52166B30; Wed, 15 Feb 2023 10:13:50 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 31FADmXB755759 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 15 Feb 2023 11:13:48 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 31FADlYl755758; Wed, 15 Feb 2023 11:13:47 +0100 Date: Wed, 15 Feb 2023 11:13:47 +0100 From: Jakub Jelinek To: Tobias Burnus Cc: gcc-patches Subject: Re: [Patch] libgomp: Fix 'target enter data' with always pointer Message-ID: Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Feb 13, 2023 at 09:28:15PM +0100, Tobias Burnus wrote: > libgomp: Fix 'target enter data' with always pointer > > As GOMP_MAP_ALWAYS_POINTER operates on the previous map item, ensure that > with 'target enter data' both are passed together to gomp_map_vars_internal. > > libgomp/ChangeLog: > > * target.c (gomp_map_vars_internal): Add 'i > 0' before doing a > kind check. > (GOMP_target_enter_exit_data): If the next map item is > GOMP_MAP_ALWAYS_POINTER map it together with the current item. > * testsuite/libgomp.fortran/target-enter-data-3.f90: New test. 8 spaces instead of tab, this won't get through the git pre-commit hook. Otherwise LGTM. Jakub