public inbox for
 help / color / mirror / Atom feed
From: Jakub Jelinek <>
To: Joseph Myers <>
Cc: Jonathan Wakely <>,,
Subject: Re: [RFC PATCH] libstdc++, v2: Partial library support for std::float{16, 32, 64, 128}_t
Date: Mon, 17 Oct 2022 23:50:17 +0200	[thread overview]
Message-ID: <Y03OGc98btCd3REM@tucnak> (raw)
In-Reply-To: <>

On Mon, Oct 17, 2022 at 09:33:02PM +0000, Joseph Myers wrote:
> > > And I/O etc. support is missing, not sure I'm able to handle that and if it
> > > is e.g. possible to keep that support out of, because what
> > > extended floating point types one has on a particular arch could change over
> > > time (I mean e.g. bfloat16_t support or float16_t support can be added
> > > etc.).
> > 
> > Yes, I think we can add the I/O functions as always_inline because all
> > they're going to do is convert the argument to float, double, or long
> > double and then call the existing overloads. There will be no new
> > virtual functions.
> As with fma, note that doing conversions from strings to floating-point is 
> a case where doing the operation on float and then narrowing is 
> technically incorrect because double rounding can occur (the rounded float 
> result can be half way between two values of the narrower type, without 
> that being the exact mathematical result) but the operation should be 
> correctly rounding.  It's fine to use float or double operations in the 
> other direction (floating-point to strings), of course.

That is true, but for istream and ostream that is what the standard
requires.  This is because there are required facets to be called and
they are available just for float/double/long double and it would be
an ABI change to allow more.
For extended floating point wider than long double it is implementation
defined what happens.
And otherwise, there is
[ Note: When the extended floating-point type has a floating-point
conversion rank that is not equal to the rank of any standard floating-point
type, then double rounding during the conversion can result in inaccurate
results.  from_chars can be used in situations where maximum accuracy is
important.  - end note ]
As for <charconv>, I think we'll need to implement both directions,
though perhaps the float16_t or bfloat16_t to_chars can be partly or fully
implemented using the float to_chars.


      parent reply	other threads:[~2022-10-17 21:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-27  8:45 [RFC PATCH] libstdc++: Partial library support for std::float{16,32,64,128}_t Jakub Jelinek
2022-10-16 10:20 ` [RFC PATCH] libstdc++, v2: " Jakub Jelinek
2022-10-17 13:07   ` Jonathan Wakely
2022-10-17 16:25     ` [PATCH] libstdc++, v3: Partial library support for std::float{16,32,64,128}_t and std::bfloat16_t Jakub Jelinek
2022-10-18  9:18       ` Jonathan Wakely
2022-10-17 21:33     ` [RFC PATCH] libstdc++, v2: Partial library support for std::float{16, 32, 64, 128}_t Joseph Myers
2022-10-17 21:45       ` Jonathan Wakely
2022-10-17 21:50       ` Jakub Jelinek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y03OGc98btCd3REM@tucnak \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).