From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 055A73858C83 for ; Tue, 18 Oct 2022 11:27:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 055A73858C83 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666092447; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=kUdrUyALrzj9+9M2RQsJtDM3DSoAYGss+/ejWOv67V0=; b=QK27Gz1QTZf+cJ3kjPyt7k5z6okRljkePtcpfxQyXkFJ/MaK5Xy5ScQ61rYxZsvGHSld7F YeNzdW1Gl/hj/TTrllOvjjlgtICWaQ2wOZzpQw5NNTxybIqVT+0p1MCkj6ZgNK/oHb9eT9 OTLsRXl1QfD1IZ4tCjOe6zXUODx5fHA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-344-SsT78YO8NoiW0xkOuXEWoA-1; Tue, 18 Oct 2022 07:27:26 -0400 X-MC-Unique: SsT78YO8NoiW0xkOuXEWoA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 34B03857AB4 for ; Tue, 18 Oct 2022 11:27:25 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.193.252]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E7DC9410DEC; Tue, 18 Oct 2022 11:27:24 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 29IBRHLu057113 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 18 Oct 2022 13:27:22 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 29IBR78v057107; Tue, 18 Oct 2022 13:27:07 +0200 Date: Tue, 18 Oct 2022 13:27:01 +0200 From: Jakub Jelinek To: Jonathan Wakely Cc: gcc-patches@gcc.gnu.org Subject: Re: [ping] [wwwdocs] Add reference to pp_format to Coding Conventions Message-ID: Reply-To: Jakub Jelinek References: <20220921093927.870907-1-jwakely@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Oct 18, 2022 at 12:15:08PM +0100, Jonathan Wakely via Gcc-patches wrote: > ping... > > On 21/09/22 10:39 +0100, Jonathan Wakely wrote: > > Finding the docs for the GCC-specific diagnostic formats isn't easy. > > This might help. > > > > OK for wwwdocs? > > -- >8 -- > > htdocs/codingconventions.html | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/htdocs/codingconventions.html b/htdocs/codingconventions.html > index e4d30510..f1d1f165 100644 > --- a/htdocs/codingconventions.html > +++ b/htdocs/codingconventions.html > @@ -333,7 +333,8 @@ code token. >
  • Diagnostics using the GCC diagnostic functions should generally > use the GCC-specific formats such as %qs or > %< and %> for quoting and > -%m for errno numbers.
    • > +%m for errno numbers. See > +pp_format in pretty-print.cc for supported formats. I'm afraid pretty-print.cc covers only some of them. E.g. tree-diagnostic.cc (default_tree_printer) adds several important ones (%T, %E, %D and %F; but unfortunately we don't document those like the comment about pp_format does). Then there are the C++ specific formats, cp/error.cc (cp_printer) comment documents those. fortran/error.cc (error_print) comment similarly for Fortran FE specific modifiers. dumpfile.cc (dump_pretty_printer::decode_format) documents its extensions too. Jakub