From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jakub@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
	by sourceware.org (Postfix) with ESMTPS id AF78D3858C83
	for <gcc-patches@gcc.gnu.org>; Tue, 18 Oct 2022 12:53:03 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AF78D3858C83
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1666097583;
	h=from:from:reply-to:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:cc:mime-version:mime-version:
	 content-type:content-type:in-reply-to:in-reply-to:  references:references;
	bh=MWF6FWGyK5X+Em8Us5+50ayWid/ZmRvfwPkXkviDVgk=;
	b=aKPwX4aw5Ts3CHtF2DRZQCsYKmEvuVlFemS05zf1C9c9bQqpaglE4X8wtAqL/E1ODNG32C
	kRH4Z85qy9brJAMsDcI2BTQIkq6kdqRi0mOZs4eu+M3+2RWXbyIUgY5+bR8oBqS9JH7KeX
	we7gMHy03QTbMrTREzIhWk3dMdc/K/k=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-209-bZf97_LLNC2PjMUo8eTyFA-1; Tue, 18 Oct 2022 08:52:59 -0400
X-MC-Unique: bZf97_LLNC2PjMUo8eTyFA-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 391BF857FB0
	for <gcc-patches@gcc.gnu.org>; Tue, 18 Oct 2022 12:52:59 +0000 (UTC)
Received: from tucnak.zalov.cz (unknown [10.39.193.252])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id E8FEDAB585;
	Tue, 18 Oct 2022 12:52:58 +0000 (UTC)
Received: from tucnak.zalov.cz (localhost [127.0.0.1])
	by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 29ICqu0l058682
	(version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT);
	Tue, 18 Oct 2022 14:52:56 +0200
Received: (from jakub@localhost)
	by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 29ICqtKM058681;
	Tue, 18 Oct 2022 14:52:55 +0200
Date: Tue, 18 Oct 2022 14:52:54 +0200
From: Jakub Jelinek <jakub@redhat.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] libsanitizer: Avoid implicit function declaration in
 configure test
Message-ID: <Y06hpjQJ1a4T3V3v@tucnak>
Reply-To: Jakub Jelinek <jakub@redhat.com>
References: <87r0z5jws2.fsf@oldenburg.str.redhat.com>
MIME-Version: 1.0
In-Reply-To: <87r0z5jws2.fsf@oldenburg.str.redhat.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On Tue, Oct 18, 2022 at 11:39:25AM +0200, Florian Weimer via Gcc-patches wrote:
> libsanitizer/
> 
> 	* configure.ac (check for necessary platform features):

I'd use (sanitizer_supported) or (SANITIZER_SUPPORTED) above instead,
that is what is what is being determined by the test.

> 	Include <unistd.h> for syscall prototype.
> 	* configure: Regenerate.

Otherwise LGTM, thanks.

> --- a/libsanitizer/configure.ac
> +++ b/libsanitizer/configure.ac
> @@ -161,7 +161,8 @@ case "$target" in
>    *-*-linux*)
>      # Some old Linux distributions miss required syscalls.
>      sanitizer_supported=no
> -    AC_TRY_COMPILE([#include <sys/syscall.h>],[
> +    AC_TRY_COMPILE([#include <sys/syscall.h>
> +#include <unistd.h>],[
>        syscall (__NR_gettid);
>        syscall (__NR_futex);
>        syscall (__NR_exit_group);
> 
> base-commit: acdb24166d13d87c374e578d2ad5d58249171930

	Jakub