From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 26FF13858C83 for ; Tue, 18 Oct 2022 12:57:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 26FF13858C83 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666097873; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=CvuGJwKfLfb/MpcuXQrDLni6TkMNPILpVfGp5Q7NiZc=; b=fUF9UIZGWk10FbtGFkB+lubGaAXbYr0OvXHQcQw1OXqdt6/em1GBZDWvDRtShI1dRxV28N rVYY6OTT4cTQLS1Ts/FPTZylyxN6r5s/L4c2BhbVxgzhkVoPaynXH47lvAQzIZpYUK3UCX r2CfZepUmj17/+KcMeysHumvqqGDhqI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-509-4-G_LAU5NKWpPKvvSC7Zpw-1; Tue, 18 Oct 2022 08:57:51 -0400 X-MC-Unique: 4-G_LAU5NKWpPKvvSC7Zpw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1A6DF80A0A6 for ; Tue, 18 Oct 2022 12:57:51 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.193.252]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CD400111DCE5; Tue, 18 Oct 2022 12:57:50 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 29ICvmEC058719 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 18 Oct 2022 14:57:48 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 29ICvlLb058718; Tue, 18 Oct 2022 14:57:47 +0200 Date: Tue, 18 Oct 2022 14:57:47 +0200 From: Jakub Jelinek To: Florian Weimer Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] libiberty: Fix C89-isms in configure tests Message-ID: Reply-To: Jakub Jelinek References: <87h701jvk2.fsf@oldenburg.str.redhat.com> MIME-Version: 1.0 In-Reply-To: <87h701jvk2.fsf@oldenburg.str.redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Oct 18, 2022 at 12:05:49PM +0200, Florian Weimer via Gcc-patches wrote: > libiberty/ > > * acinclude.m4 (check for working strncmp): Add missing > int return type and parameter list to the definition of main. > Include for string functions. Avoid calling > undeclared exit function. > (stack direction for C alloca): Avoid calling undeclared exit > function. Spaces instead of tabs. I'd think we should #include for exit and keep exit, I vaguely remember non-zero return from main doesn't always work reliably, which is why e.g. in the testsuite we usually abort instead of return non-zero from main. Don't remember if it is just for some bare metal cases or what, which on the either side probably don't have mmap. Jakub