From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id A2289385701A for ; Tue, 18 Oct 2022 14:09:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A2289385701A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666102150; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=qK0rscDMSUwF+MoCBP/sXsHAJHiGRIY1Nzl8ujf1DL4=; b=Jm2UfGEsLuRHhF/n7W0+yM7AogDSl1ApqLpoLOgbH2/A8P8xLqJYNWSFxQ0fZdO2+9O4Td nUBsMGybRrfED0kQzbr7dGBMq99GMcWq//9bn6XxcPmjJH5PfKXHEXvdFXKeNBdS7DELcZ ECZ0dx/k+oKWOiI8FCQkQARUVvNp0SM= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-487-5yXFp6b_MweDyDCGkJYyLQ-1; Tue, 18 Oct 2022 10:09:08 -0400 X-MC-Unique: 5yXFp6b_MweDyDCGkJYyLQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 12AC23817A77 for ; Tue, 18 Oct 2022 14:09:01 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.193.252]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 851CEE56A7; Tue, 18 Oct 2022 14:08:50 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 29IE8UjD060695 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 18 Oct 2022 16:08:32 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 29IE8Pgc060694; Tue, 18 Oct 2022 16:08:25 +0200 Date: Tue, 18 Oct 2022 16:08:24 +0200 From: Jakub Jelinek To: Florian Weimer Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] libiberty: Fix C89-isms in configure tests Message-ID: Reply-To: Jakub Jelinek References: <87h701jvk2.fsf@oldenburg.str.redhat.com> <875yghjkfa.fsf@oldenburg.str.redhat.com> MIME-Version: 1.0 In-Reply-To: <875yghjkfa.fsf@oldenburg.str.redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Oct 18, 2022 at 04:06:17PM +0200, Florian Weimer wrote: > By the way, the stack direction test currently gives incorrect results > on x86-64 due to -O2 and address comparison of unrelated objects. I > assume this doesn't matter because we don't use it on compilers that > support alloca natively. Guess it would be better to cast the addresses to uintptr_t and compare that. Jakub