From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id D92203857407 for ; Fri, 14 Oct 2022 14:38:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D92203857407 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665758283; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=bIi9AZYQO+bAEKC3RXWb//I2DAoHmVQMK9uShgoyaSg=; b=c71VuE/pa02dQgFLY7z7JHPEMRdUXFgzD7j5MHtUI0fTc+P12sqCH66iVDEDEJKwYa81kT oiSaYnb+xzr3HUTwDstF40TEgQmj0AVu6jqTfw8+h90YF7mSnG+b9A7h8+awuQ5nLdChDL MQi4HX43RuVehdbwFMpgkccwS8Tv+Ws= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-479-ps8-ll0qPK6wnRB8GH-QhQ-1; Fri, 14 Oct 2022 10:38:02 -0400 X-MC-Unique: ps8-ll0qPK6wnRB8GH-QhQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2CA76833A13 for ; Fri, 14 Oct 2022 14:38:02 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.55]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E1CA440315F; Fri, 14 Oct 2022 14:38:01 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 29EEbxH52564107 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 14 Oct 2022 16:37:59 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 29EEbxCY2564106; Fri, 14 Oct 2022 16:37:59 +0200 Date: Fri, 14 Oct 2022 16:37:58 +0200 From: Jakub Jelinek To: Aldy Hernandez Cc: GCC patches , Andrew MacLeod Subject: Re: [PATCH] Check rvc_normal in real_isdenormal. Message-ID: Reply-To: Jakub Jelinek References: <20221014143047.672008-1-aldyh@redhat.com> MIME-Version: 1.0 In-Reply-To: <20221014143047.672008-1-aldyh@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Oct 14, 2022 at 04:30:47PM +0200, Aldy Hernandez wrote: > [Jakub, thanks for pointing this out. OK?] > > [-Inf, -Inf] is being flushed to [-Inf, -0.0] because real_isdenormal > is being overly pessimistic. It is missing a check for rvc_normal. > This doesn't cause problems in real.cc because all uses of > real_isdenormal are already on the rvc_normal path. The uses in > value-range.cc however, are not. > > This patch adds a check for rvc_normal. > > gcc/ChangeLog: > > * real.h (real_isdenormal): Check rvc_normal. > * value-range.cc (range_tests_floats): New test. LGTM. Jakub