From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id B7B7E385841F for ; Wed, 19 Oct 2022 17:39:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B7B7E385841F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666201159; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M9NVZD0ibGNcBb3gXBWR/tM+Iba8Z40dh74/7szLrXU=; b=d5n2UaX+x1llB48EyDNQKT1JWw8YA/uC0TumdKd0t/DiaYcnMHjzWEKb5hltdWE1MkQbb1 FKi7QeV+kJ52ZhgmQLopS5YHp42OVLnr+MYp14pBle+vW1+j4vn7YZhZwHkmnnsM1ig5qo 4ufEXQP7fbhBVPZk9NYbAKqZYl8/40E= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-499-WqkohBcSN5mP-O7l8Tgt4A-1; Wed, 19 Oct 2022 13:39:16 -0400 X-MC-Unique: WqkohBcSN5mP-O7l8Tgt4A-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9FEAF381078F; Wed, 19 Oct 2022 17:39:15 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.193.252]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 607432028DC1; Wed, 19 Oct 2022 17:39:15 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 29JHdCEt3963979 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 19 Oct 2022 19:39:12 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 29JHd60v3963978; Wed, 19 Oct 2022 19:39:06 +0200 Date: Wed, 19 Oct 2022 19:39:05 +0200 From: Jakub Jelinek To: Andrew MacLeod Cc: Jan Hubicka , Richard Biener , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] middle-end, v4: IFN_ASSUME support [PR106654] Message-ID: Reply-To: Jakub Jelinek References: <479fa663-fb3e-a90d-ae7a-0fdd5acbfa00@redhat.com> <16da3b46-f061-076a-19b5-c482f45477b3@redhat.com> <70311a20-1a94-21a1-e897-37289c9e0f0c@redhat.com> MIME-Version: 1.0 In-Reply-To: <70311a20-1a94-21a1-e897-37289c9e0f0c@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=WINDOWS-1252 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Oct 19, 2022 at 12:55:12PM -0400, Andrew MacLeod via Gcc-patches wrote: > > Not sure I understand this part. op is whatever we pass as the ith > > argument to IFN_ASSUME. I'd expect that at this point one needs to > > remap that to the (i-1)th PARM_DECL of assume_id (so e.g. when you > > have the above loop you could as well start with DECL_ARGUMENTS and move > > that to DECL_CHAIN at the end of every iteration. And then > > query ssa_default_def (DECL_STRUCT_FUNCTION (assume_id), parm) > > in each case and get global range of what that returns. > > OK, this is the bit of code I dont know how to write :-) > > yes, op is the name of the value within this current function, and yes, that > needs to be mapped to the argument decl in the assume function.   Then we > need to query what range was given to that name during the assume pass.  > when that is returned, the add_range (op, range) will inject it as a side > effect. > > Can you write that loop? I meant something like (untested code): && gimple_call_internal_fn (s) == IFN_ASSUME) { tree assume_id = gimple_call_arg (s, 0); - for (unsigned i = 1; i < gimple_call_num_args (s); i++) + tree parm = DECL_ARGUMENTS (assume_id); + struct function *fun = DECL_STRUCT_FUNCTION (assume_id); + for (unsigned i = 1; + i < gimple_call_num_args (s) && parm; + i++, parm = DECL_CHAIN (parm)) { tree op = gimple_call_arg (s, i); tree type = TREE_TYPE (op); + tree arg = ssa_default_def (fun, parm); + if (arg == NULL_TREE) + continue; if (gimple_range_ssa_p (op) && Value_Range::supports_type_p (type)) { Value_Range assume_range (type); and querying SSA_NAME_RANGE_INFO of arg rather than op. > > > > > > + for (unsigned x= 0; x < gimple_phi_num_args (phi); x++) > > for (unsigned x = 0; ... > > ? > > > > > @@ -4345,6 +4345,30 @@ execute_ranger_vrp (struct function *fun, bool warn_array_bounds_p) > > > scev_initialize (); > > > calculate_dominance_info (CDI_DOMINATORS); > > > + assume_query *r2 = new assume_query (); > > > + for (unsigned i = 0; i < num_ssa_names; i++) > > > + { > > > + tree name = ssa_name (i); > > > + if (!name || !gimple_range_ssa_p (name)) > > > + continue; > > > + tree type = TREE_TYPE (name); > > > + if (!Value_Range::supports_type_p (type)) > > > + continue; > > > + Value_Range assume_range (type); > > > + if (r2->assume_range_p (assume_range, name)) > > > + { > > > + if (dump_file) > > > + { > > > + fprintf (dump_file, "for an assume function, "); > > > + print_generic_expr (dump_file, name, TDF_SLIM); > > > + fprintf (dump_file, " would have a range of "); > > > + assume_range.dump (dump_file); > > > + fputc ('\n', dump_file); > > > + } > > > + } > > > + } > > > + delete r2; > > I have expected (but tell me if that isn't possible) this could be something > > done in the new pass_assumptions::execute () rather than vrp and you'd > > create the assume_query there (i.e. just for assume_functions) and then > > query it solely for ssa_default_def of the parameters and save in > > SSA_NAME_RANGE_INFO. > > I just discovered the assumption pass, and I have moved it to there. > > I dont know much about managing the parameters, but presumably yes, we'd > only query it for the parameters...........  I was showing the query for > every name just to show what its producing. Inside of the assume function (cfun->assume_function being true) one could again walk DECL_ARGUMENTS and for arguments with types which ranger is able to cope with and they are reg types, ssa_default_def (cfun, parm) to get the SSA_NAME of the default def (if any). > --- a/gcc/tree-vrp.cc > +++ b/gcc/tree-vrp.cc > @@ -4465,6 +4465,35 @@ public: > bool gate (function *fun) final override { return fun->assume_function; } Regarding your second mail, see above gate, this pass is only run for assume functions and nothing else. > unsigned int execute (function *) final override > { > + assume_query query; > + if (dump_file) > + fprintf (dump_file, "Assumptions :\n--------------\n"); > + for (unsigned i = 0; i < num_ssa_names; i++) > + { > + tree name = ssa_name (i); > + if (!name || !gimple_range_ssa_p (name)) > + continue; > + tree type = TREE_TYPE (name); > + if (!Value_Range::supports_type_p (type)) > + continue; > + Value_Range assume_range (type); > + if (query.assume_range_p (assume_range, name)) > + { > + set_range_info (name, assume_range); > + if (dump_file) > + { > + print_generic_expr (dump_file, name, TDF_SLIM); > + fprintf (dump_file, " -> "); > + assume_range.dump (dump_file); > + fputc ('\n', dump_file); > + } > + } > + } > + if (dump_file) > + { > + fputc ('\n', dump_file); > + gimple_dump_cfg (dump_file, dump_flags); > + } > return TODO_discard_function; > } Jakub