From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 3ED5F3858D39 for ; Wed, 19 Oct 2022 16:09:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3ED5F3858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666195754; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=lhdgxnG5KRaUG68zBYYNuq9xjAdjwOBay5yR2M+KkXU=; b=OP/63nhc0W2nl9yio0FVUVxZRF9l18S7a72a0t8oOAgJXM+KY/jDYBp+kP2+CQWA0vQRif bgM5gom/8qudcrvI11LI5OwpOge0+A26CKEGnJBJewbQmtH3kon1ZS8GYSOQJe71YsBDwW qsCp3TfLOSEglie/XeljdIHKuugzd9s= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-403-HKvWWrchNoiSIHZVllgBRA-1; Wed, 19 Oct 2022 12:09:13 -0400 X-MC-Unique: HKvWWrchNoiSIHZVllgBRA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A5CAB833B0F; Wed, 19 Oct 2022 16:09:12 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.193.252]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 915A4492B23; Wed, 19 Oct 2022 16:09:05 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 29JG8jZu3962793 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 19 Oct 2022 18:08:46 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 29JG8YBn3962791; Wed, 19 Oct 2022 18:08:34 +0200 Date: Wed, 19 Oct 2022 18:08:34 +0200 From: Jakub Jelinek To: Andrew Stubbs , "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH] libgomp: fix hang on fatal error Message-ID: Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Oct 19, 2022 at 03:27:52PM +0200, Jakub Jelinek via Gcc-patches wrote: > > --- a/libgomp/error.c > > +++ b/libgomp/error.c > > @@ -77,7 +77,7 @@ void > > gomp_vfatal (const char *fmt, va_list list) > > { > > gomp_verror (fmt, list); > > - exit (EXIT_FAILURE); > > + abort (); > > } > > > > void > > I don't like this, abort has quite different user visible behavior > from exit, e.g. the former often dumps core. > > I believe in most places libgomp handles this by releasing locks before > calling gomp_{,v}fatal: > gomp_mutex_unlock (®ister_lock); > gomp_fatal ("Out of memory allocating %lu bytes", (unsigned long) size); > > gomp_mutex_unlock (&devicep->lock); > gomp_fatal ("Copying of %s object [%p..%p) to %s object [%p..%p) failed", > src, srcaddr, srcaddr + size, dst, dstaddr, dstaddr + size); > > etc. > I could live with a gomp_fatal/gomp_vfatal alternative that would > use _exit/_Exit (but not sure if it is supported on all targets where > libgomp is) for uses where releasing locks is for whatever reason > not an option. Or yet another possibility would be not use gomp_fatal from within the plugins, but use gomp_error instead and through possibly adjusted plugin APIs tell libgomp that there was a fatal error and let libgomp unlock anything that needs unlocking and exit (EXIT_FAILURE); afterwards. Jakub