From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id A3E6C385116D for ; Thu, 20 Oct 2022 10:47:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A3E6C385116D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666262840; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=1auOe/yzdIvS1ag0ij0oYHEfAyo9Kptngyi/Rgx8Zu4=; b=C0g8bMPm10QxH3dHpkjhgEUJ6xTonMqBPbUcMDl9Muj6PBZdtKcyV5fmsUYnPv69gsdt3J BSzisFk/wUx0SzrwKBUKww0UwE6043Z7jRuKyGQkNFs3pavT4xSAfDrAOMOYhMwxIRGtJl s2COJcoNV7FaFb1P2Ojr+FKhUtadQx8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-554-2sf6JB_sMq6Rx5K3fFJJNg-1; Thu, 20 Oct 2022 06:47:15 -0400 X-MC-Unique: 2sf6JB_sMq6Rx5K3fFJJNg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AA298833AF5; Thu, 20 Oct 2022 10:47:14 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.193.252]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E41061121315; Thu, 20 Oct 2022 10:47:08 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 29KAkmSI1616660 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 20 Oct 2022 12:46:59 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 29KAkf6u1616659; Thu, 20 Oct 2022 12:46:41 +0200 Date: Thu, 20 Oct 2022 12:46:41 +0200 From: Jakub Jelinek To: Tobias Burnus Cc: gcc-patches , Andrew Stubbs , "Vollweiler, Marcel" Subject: Re: [Patch] libgomp: Add offload_device_gcn check, add requires-4a.c test Message-ID: Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Oct 12, 2022 at 04:05:32PM +0200, Tobias Burnus wrote: > include/ChangeLog: > > * gomp-constants.h (GOMP_DEVICE_HSA): Comment (unused). Comment out unused define. or so, please. > libgomp/ChangeLog: > > * testsuite/lib/libgomp.exp (check_effective_target_offload_device_gcn): > New. > * testsuite/libgomp.c-c++-common/on_device_arch.h (device_arch_gcn, > on_device_arch_gcn): New. > * testsuite/libgomp.c-c++-common/requires-4a.c: New test; copied from > requires-4.c but using heap-allocated memory. Otherwise LGTM. Jakub