From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 34DE7384D195 for ; Thu, 20 Oct 2022 16:47:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 34DE7384D195 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666284455; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9Iku1c/a8jChDYyRooivNBNiGZ90ckv7BD3eG4GYLmc=; b=LCqopEMPKPrLgE3ZhGYaQfMo2vu2ARAAhbf5J6IRUou8F7Psf4GMST/KR6zJrx6Mj1KfBz jpt5NQY3/diB1nB/EUZKxn1nBHqbDY3dMiTfZAKK6a2NLT/Y8g3J1bVsEgu7ghkqk1nA+c 2vyvDx1B8EzckAM27bOd8zaTgHMUIVM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-59-xNTz1QDoNReViDfjFsX-XQ-1; Thu, 20 Oct 2022 12:47:30 -0400 X-MC-Unique: xNTz1QDoNReViDfjFsX-XQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 341E288283D; Thu, 20 Oct 2022 16:47:30 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.193.252]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C844AC15BA5; Thu, 20 Oct 2022 16:47:29 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 29KGlQ9A1648263 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 20 Oct 2022 18:47:27 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 29KGlOjK1648262; Thu, 20 Oct 2022 18:47:24 +0200 Date: Thu, 20 Oct 2022 18:47:23 +0200 From: Jakub Jelinek To: Joseph Myers Cc: Martin =?utf-8?B?TGnFoWth?= , Xi Ruoyao , Sandra Loosemore , GCC Patches , GCC Development Subject: Re: Announcement: Porting the Docs to Sphinx - 9. November 2022 Message-ID: Reply-To: Jakub Jelinek References: <9975b774-46d7-8870-fd92-498f5ec50ab4@suse.cz> <9ea57a95-fefe-81a3-848e-ede0893f5b61@suse.cz> <8198573b-89e2-a232-3e33-0e5c4153c112@suse.cz> <494cee6fc68c06e039f46c3d6f8331a32e81ab5e.camel@linuxfromscratch.org> <7bae16bc-9069-4964-a80e-7ebff82e007e@suse.cz> <2a4347ab-40a1-2afc-f48c-6d8290afb7c6@suse.cz> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Oct 20, 2022 at 04:43:06PM +0000, Joseph Myers wrote: > On Thu, 20 Oct 2022, Martin Liška wrote: > > > > Also, but not strictly part of the release issue: > > > > > > (d) Builds with missing or old Sphinx should work regardless of whether > > > such files are in the source directory - but if they aren't in the source > > > directory, the effect of missing or old Sphinx (detected at configure > > > time) should be to disable building and installing documentation. > > > > All right Joseph, is it something you're willing to help me once we start > > using Sphinx? Apparently, there will be many consequent steps after we switch. > > Sure, but most of the conditionals are *already* present, just need > updating as part of the Sphinx transition. E.g. gcc/Makefile.in has > BUILD_INFO and GENERATED_MANPAGES conditionals based on configure tests > for whether relevant tools are present and new enough; the rules for > $(DESTDIR)$(infodir)/%.info quietly allow the info files not to be > present, so installing also works without the info files or tools to build > them, and the rules for installing man pages similarly ignore errors; and > there are srcinfo and srcman rules, enabled based on @GENINSRC@, to copy > those built files to the source directory, which are what's used when > --enable-generated-files-in-srcdir is used as part of building a release > tarball. > > The main thing I've suggested that I think may actually be new is an error > for trying to build a release tarball without new-enough Sphinx (I think > the current rules would quietly not copy info / man pages to the source > directory if build tools were missing - but having those tools missing > when building a release tarball is much less likely than not having > new-enough Sphinx). But perhaps that test should go to maintainer-scripts/gcc_release. Can be either of the form of checking if Sphinx is new enough, or checking of make actually built the documentation before creating the tarballs. Jakub