From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nikam.ms.mff.cuni.cz (nikam.ms.mff.cuni.cz [195.113.20.16]) by sourceware.org (Postfix) with ESMTPS id A59793856DC0 for ; Fri, 21 Oct 2022 12:52:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A59793856DC0 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=ucw.cz Authentication-Results: sourceware.org; spf=none smtp.mailfrom=kam.mff.cuni.cz Received: by nikam.ms.mff.cuni.cz (Postfix, from userid 16202) id EBD49285051; Fri, 21 Oct 2022 14:52:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1; t=1666356742; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QF5gOrgglnmUD6H/re3hepwwgSFQyA7tjBRZuEVHsAQ=; b=bZyHT8y1HDqdcT1zqfzslGlEAwJvZXJ923Yq6VtGpldNeYFL3Hz+qgBViqB8lCl1JqtCCX lHpwf1MvGZAizvy8K5hV1kfnbJAtWpJenxj8bO4jnaH3UABJtf4oRLmtkn28l3B9fMts2R i7c1DCP9FQosjwnIsAwxR8wGQ35i5dg= Date: Fri, 21 Oct 2022 14:52:22 +0200 From: Jan Hubicka To: Richard Biener Cc: "Kumar, Venkataramanan" , "Joshi, Tejas Sanjay" , "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH] [X86_64]: Enable support for next generation AMD Zen4 CPU Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > On Fri, Oct 21, 2022 at 12:00 PM Kumar, Venkataramanan via Gcc-patches > wrote: > > > > Hi all, > > > > > -----Original Message----- > > > From: Joshi, Tejas Sanjay > > > Sent: Monday, October 17, 2022 8:09 PM > > > To: gcc-patches@gcc.gnu.org > > > Cc: Kumar, Venkataramanan ; > > > honza.hubicka@gmail.com; Uros Bizjak > > > Subject: RE: [PATCH] [X86_64]: Enable support for next generation AMD > > > Zen4 CPU > > > > > > [Public] > > > > > > Hi, > > > > > > > BTW: Perhaps znver1.md is not the right filename anymore, since it hosts > > > all four Zen schedulers. > > > > > > I have renamed the file to znver.md in this revision, PFA. > > > Thank you for the review, we will push it for trunk if we don't get any > > > further comments. > > > > I have pushed the patch on behalf of Tejas. > > This grew insn-automata.cc from 201502 lines to 639968 lines and the build > of the automata (genautomata) to several minutes in my dev tree. > > You did something wrong. Please fix! I think it may make sense to make the initial patch without scheduler model update with zen3 scheduling. I can work on updating the model which needs some benchmarking and setting up the cost tables first. The problem here is that adding extra variants to execution core model likely forces too many states. In general DFA is not best model for such symmetirc and parallel execution core (since there are way too many combinations individual pipes may get). I was thinking of adding an option to generate alternative model based on bitmasks, but never got around implementing that. So with current infrastructure we always need to simplify a bit. Which is also not big deal since the scheduling is not well documented anyway and our model is not precise at all (it misses the on-chip scheduler). Honza > > Richard. > > > Regards, > > Venkat. > >