From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 1017F3856DC0 for ; Fri, 21 Oct 2022 16:51:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1017F3856DC0 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666371085; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=7/NJAsohO/7gv5igbWD2WcsowDkqX3NNibCgN8tbyl4=; b=bKAReUje64nwtNjluLhkKuCimpO8fl9ZSuZU3S6IlvC6D0Z3+JnkZfq23ckw3o7IlDNvXZ A0GKy26aHyYfxaJx5tycCQjeW4DszD0ia3n8R0mJ6rnqS9bTysYyyUP0WjcN5HtkW3iLHI qC5D7hPN9WGxKlGySpZ8rJXb46jVBPU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-424-HkxzINarMmC_QQOcgjdMWQ-1; Fri, 21 Oct 2022 12:51:22 -0400 X-MC-Unique: HkxzINarMmC_QQOcgjdMWQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3D6038339C5; Fri, 21 Oct 2022 16:51:22 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.193.252]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F10FA492B04; Fri, 21 Oct 2022 16:51:21 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 29LGpJME3544738 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 21 Oct 2022 18:51:19 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 29LGpHSM3544736; Fri, 21 Oct 2022 18:51:17 +0200 Date: Fri, 21 Oct 2022 18:51:17 +0200 From: Jakub Jelinek To: Segher Boessenkool Cc: Aldy Hernandez , GCC patches Subject: Re: [PATCH] Rename nonzero_bits to known_zero_bits. Message-ID: Reply-To: Jakub Jelinek References: <20221021131426.308205-1-aldyh@redhat.com> <20221021164533.GW25951@gate.crashing.org> MIME-Version: 1.0 In-Reply-To: <20221021164533.GW25951@gate.crashing.org> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Oct 21, 2022 at 11:45:33AM -0500, Segher Boessenkool wrote: > On Fri, Oct 21, 2022 at 03:14:26PM +0200, Aldy Hernandez via Gcc-patches wrote: > > The name nonzero_bits is confusing. We're not tracking nonzero bits. > > We're tracking known-zero bits, or at the worst we're tracking "maye > > nonzero bits". But really, the only thing we're sure about in the > > "nonzero" bits are the bits that are zero, which are known to be 0. > > We're not tracking nonzero bits. > > Indeed. > > > I know we've been carrying around this name forever, but the fact that > > both of the maintainers of the code *HATE* it, should be telling. > > Also, we'd also like to track known-one bits in the irange, so it's > > best to keep the nomenclature consistent. > > And that as well. > > However: > > > * asan.cc (handle_builtin_alloca): Rename *nonzero* to *known_zero*. > > Our "nonzero" means "not known to be zero", not "known to be zero", so > this renaming makes it worse than it was. Rename it to Agreed. I think maybe_nonzero_bits would be fine. Anyway, the reason it is called this way is that we have similar APIs on the RTL side, nonzero_bits* in rtlanal.cc. So if we rename, it should be renamed consistently. > "not_known_zero", make that a thin wrapper around a new "known_zero", > and slowly get rid of not_known_zero? Jakub