From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 142AF3858421 for ; Mon, 24 Oct 2022 13:14:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 142AF3858421 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666617281; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=SPBEyMe5z7B6eYbudHaNFddhCVk629aVSYL0GQZj+1w=; b=TONZXiIHubgCY2X+9Nzu1bZ0LETqKAHdeUiEZL6B/8q3LjcTQ7XBr5WRJwFppeCXaPaubw TvK5yzWZZUHal/X/On3I8ZhCJg+jK5j5ebKXYD5igmO4OzGQjCQgvDX4N5L/PyK4ypueOa MrgqkNdX/M6lD8RIeSg6aJdK+cwll00= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-486-sv2mNQl0MYeHTe5ti-PDBQ-1; Mon, 24 Oct 2022 09:14:40 -0400 X-MC-Unique: sv2mNQl0MYeHTe5ti-PDBQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 48B39811E7A; Mon, 24 Oct 2022 13:14:40 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.193.252]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F23652028E94; Mon, 24 Oct 2022 13:14:39 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 29ODEaxK3061269 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 24 Oct 2022 15:14:37 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 29ODEZw63061268; Mon, 24 Oct 2022 15:14:35 +0200 Date: Mon, 24 Oct 2022 15:14:34 +0200 From: Jakub Jelinek To: Tobias Burnus Cc: gcc-patches Subject: Re: [Patch] OpenMP: Fix reverse offload GOMP_TARGET_REV IFN corner cases [PR107236] Message-ID: Reply-To: Jakub Jelinek References: <9e2d0331-92c4-c8a6-a662-61f298fb3976@codesourcery.com> MIME-Version: 1.0 In-Reply-To: <9e2d0331-92c4-c8a6-a662-61f298fb3976@codesourcery.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Oct 18, 2022 at 09:27:04PM +0200, Tobias Burnus wrote: > The cgraph_node::create_clone issue is exposed with -O2 for the existing > libgomp.fortran/reverse-offload-1.f90. > > omp-offload.cc > > PR middle-end/107236 > > gcc/ChangeLog: > * omp-expand.cc (expand_omp_target): Set calls_declare_variant_alt > in DECL_CONTEXT and not to cfun->decl. > * cgraphclones.cc (cgraph_node::create_clone): Copy also the > node's calls_declare_variant_alt value. > > gcc/testsuite/ChangeLog: > * gfortran.dg/gomp/target-device-ancestor-6.f90: New test. LGTM, thanks. Jakub