From: Jakub Jelinek <jakub@redhat.com>
To: gcc-patches@gcc.gnu.org
Subject: [committed] gimplify: Call gimple_boolify on IFN_ASSUME argument [PR107368]
Date: Tue, 25 Oct 2022 10:48:21 +0200 [thread overview]
Message-ID: <Y1ei1ZtN132Hr3h3@tucnak> (raw)
Hi!
The following testcase ICEs in C, because assume attribute condition
has int type rather than bool and the gimplification into GIMPLE_ASSUME
assigns it into a bool variable.
Fixed by calling gimple_boolify.
Bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk.
2022-10-25 Jakub Jelinek <jakub@redhat.com>
PR tree-optimization/107368
* gimplify.cc (gimplify_call_expr): For complex IFN_ASSUME
conditions call gimple_boolify on the condition.
* gcc.dg/attr-assume-5.c: New test.
--- gcc/gimplify.cc.jj 2022-10-24 10:22:08.590902730 +0200
+++ gcc/gimplify.cc 2022-10-24 11:01:54.121339779 +0200
@@ -3586,7 +3586,7 @@ gimplify_call_expr (tree *expr_p, gimple
a separate function easily. */
tree guard = create_tmp_var (boolean_type_node);
*expr_p = build2 (MODIFY_EXPR, void_type_node, guard,
- CALL_EXPR_ARG (*expr_p, 0));
+ gimple_boolify (CALL_EXPR_ARG (*expr_p, 0)));
*expr_p = build3 (BIND_EXPR, void_type_node, NULL, *expr_p, NULL);
push_gimplify_context ();
gimple_seq body = NULL;
--- gcc/testsuite/gcc.dg/attr-assume-5.c.jj 2022-10-24 11:13:47.169624469 +0200
+++ gcc/testsuite/gcc.dg/attr-assume-5.c 2022-10-24 11:16:11.137662896 +0200
@@ -0,0 +1,10 @@
+/* PR tree-optimization/107368 */
+/* { dg-do compile } */
+/* { dg-options "-O2" } */
+
+double
+f4 (double x)
+{
+ [[gnu::assume (x && x > 0.0)]];
+ return x;
+}
Jakub
reply other threads:[~2022-10-25 8:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1ei1ZtN132Hr3h3@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).