From: Jakub Jelinek <jakub@redhat.com>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org
Subject: [PATCH] libstdc++: Fix up to_chars ppc64le _Float128 overloads [PR107636]
Date: Sat, 12 Nov 2022 09:47:14 +0100 [thread overview]
Message-ID: <Y29dkunenk2cCh7w@tucnak> (raw)
Hi!
As reported, I've misplaced __extension__ keywords in these cases
(wanted not to have them on the whole inlines because _Float128 is
completely standard now while __float128 is not, but before return
it is a syntax error.
I've verified on a short testcase that both g++ and clang++ accept
__extension__ after return keyword.
Bootstrapped/regtested on x86_64-linux and i686-linux (admittedly
not powerpc64le-linux with new glibc), ok for trunk?
2022-11-12 Jakub Jelinek <jakub@redhat.com>
PR libstdc++/107636
* include/std/charconv (to_chars): Fix up powerpc64le _Float128
overload __extension__ placement.
--- libstdc++-v3/include/std/charconv.jj 2022-11-11 08:15:45.696183293 +0100
+++ libstdc++-v3/include/std/charconv 2022-11-11 16:32:52.992693605 +0100
@@ -892,23 +892,25 @@ namespace __detail
inline to_chars_result
to_chars(char* __first, char* __last, _Float128 __value) noexcept
{
- __extension__
- return to_chars(__first, __last, static_cast<__float128>(__value));
+ return __extension__ to_chars(__first, __last,
+ static_cast<__float128>(__value));
}
inline to_chars_result
to_chars(char* __first, char* __last, _Float128 __value,
chars_format __fmt) noexcept
{
- __extension__
- return to_chars(__first, __last, static_cast<__float128>(__value), __fmt);
+
+ return __extension__ to_chars(__first, __last,
+ static_cast<__float128>(__value), __fmt);
}
inline to_chars_result
to_chars(char* __first, char* __last, _Float128 __value,
chars_format __fmt, int __precision) noexcept
{
- __extension__
- return to_chars(__first, __last, static_cast<__float128>(__value), __fmt,
- __precision);
+
+ return __extension__ to_chars(__first, __last,
+ static_cast<__float128>(__value), __fmt,
+ __precision);
}
#else
to_chars_result to_chars(char* __first, char* __last, _Float128 __value)
Jakub
next reply other threads:[~2022-11-12 8:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-12 8:47 Jakub Jelinek [this message]
2022-11-12 11:27 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y29dkunenk2cCh7w@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).