From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 839283858D28 for ; Wed, 2 Nov 2022 09:27:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 839283858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667381261; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=A9UtyE2MVgRfjZ/iAvV1QRp3cvwAVgEyYjVXVjMPcd0=; b=H9dwPJzn+pW5U/2W2MQoG5wxuJy05nZbfAYQCZIRjIiiJWOY/bRtcT9wprVJfW5fjfKbT3 owoUPY93Uuura0EPxHxg9Nn9k3N6q2iUzEUSQYYRSGG5jWFsUb6O9QLGY/RpCm4C+KsQom B4hspdfF3VGT29lF+La2++12XDoKP8s= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-645-P09yPsYcNAOjfQGhvcl6mA-1; Wed, 02 Nov 2022 05:27:39 -0400 X-MC-Unique: P09yPsYcNAOjfQGhvcl6mA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5FF4985A583; Wed, 2 Nov 2022 09:27:39 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.193.252]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 20E3B201F403; Wed, 2 Nov 2022 09:27:39 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 2A29RaOU2091826 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 2 Nov 2022 10:27:36 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 2A29RZgc2091823; Wed, 2 Nov 2022 10:27:35 +0100 Date: Wed, 2 Nov 2022 10:27:35 +0100 From: Jakub Jelinek To: Rainer Orth Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] builtins: Guard builtins.cc against HUGE_VAL and NAN definitions Message-ID: Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Nov 02, 2022 at 10:13:44AM +0100, Rainer Orth wrote: > trunk bootstrap recently broke on Solaris like this: > > /vol/gcc/src/hg/master/local/gcc/builtins.cc:2104:8: error: pasting "CFN_BUILT_IN_" and "(" does not give a valid preprocessing token > 2104 | case CFN_BUILT_IN_##MATHFN: \ > | ^~~~~~~~~~~~~ > /vol/gcc/src/hg/master/local/gcc/builtins.cc:2112:3: note: in expansion of macro 'CASE_MATHFN' > 2112 | CASE_MATHFN(MATHFN) \ > | ^~~~~~~~~~~ > /vol/gcc/src/hg/master/local/gcc/builtins.cc:1967:5: note: in expansion of macro 'CASE_MATHFN_FLOATN' > 1967 | CASE_MATHFN_FLOATN (HUGE_VAL) \ > > and similarly for NAN. > > It turns out this happens because is included at some point, > which (in ) defines > > #define HUGE_VAL (__builtin_huge_val()) > #define NAN (__builtin_nanf("")) > > While this only happpens on Solaris right now, the same issue would be > present on other targets when gets included somehow. > > To avoid this, this patch #undef's both macros. > > Bootstrapped without regressions on i386-pc-solaris2.11 and > sparc-sun-solaris2.11. > > Ok for trunk? > > Rainer > > -- > ----------------------------------------------------------------------------- > Rainer Orth, Center for Biotechnology, Bielefeld University > > > 2022-11-01 Rainer Orth > > gcc: > * builtins.cc (mathfn_built_in_2): #undef HUGE_VAL, NAN. LGTM, thanks. Jakub