From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 0CEDF3858417 for ; Thu, 3 Nov 2022 12:44:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0CEDF3858417 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667479450; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=XHjN/7mnSFpiMIP7ziJJlzd9khhJjWoWuTEaOB750rE=; b=Bl1v6USmP36dBKXOOrp5UqBATVUkNU3Q4x6rBRmfGdVyAXp0dKCq7X/pVzYHkq4NTPG47R zyh+v7wrMF9R1/2jWrzvBOfk3daP/+sAzHSGuY6ftbqGD6XtdhVgu5/LMvg9+p9zmsapHs d7PS/hyuAHglTmdEjZjPolV8wht0hdg= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-342-AyjguJIcN_WG_vol4y5LFA-1; Thu, 03 Nov 2022 08:44:06 -0400 X-MC-Unique: AyjguJIcN_WG_vol4y5LFA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 59F97299E74D; Thu, 3 Nov 2022 12:44:06 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.193.252]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 193FEC15BAB; Thu, 3 Nov 2022 12:44:05 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 2A3Ci3fg3934757 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 3 Nov 2022 13:44:03 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 2A3Ci2X13934756; Thu, 3 Nov 2022 13:44:02 +0100 Date: Thu, 3 Nov 2022 13:44:01 +0100 From: Jakub Jelinek To: Tobias Burnus Cc: gcc-patches , fortran Subject: Re: [Patch] OpenMP/Fortran: 'target update' with strides + DT components Message-ID: Reply-To: Jakub Jelinek References: <51e764f7-635f-9754-dc4b-d2cd2b58435d@codesourcery.com> MIME-Version: 1.0 In-Reply-To: <51e764f7-635f-9754-dc4b-d2cd2b58435d@codesourcery.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Oct 31, 2022 at 03:46:25PM +0100, Tobias Burnus wrote: > OpenMP/Fortran: 'target update' with strides + DT components > > OpenMP 5.0 permits to use arrays with strides and derived > type components for the list items to the 'from'/'to' clauses > of the 'target update' directive. > > gcc/fortran/ChangeLog: > > * openmp.cc (gfc_match_omp_clauses): Permit derived types. > (resolve_omp_clauses):Accept noncontiguous > arrays. Formatting. Missing space before Accept and arrays. could fit on the same line. > * trans-openmp.cc (gfc_trans_omp_clauses): Fixes for > derived-type changes; fix size for scalars. > > libgomp/ChangeLog: > > * testsuite/libgomp.fortran/target-11.f90: New test. > * testsuite/libgomp.fortran/target-13.f90: New test. Otherwise LGTM, assuming it actually works correctly. I don't remember support for non-contiguous copying to/from devices being actually added, on the library side we certainly have omp_target_memcpy_rect which under the hood just does multiple copies of the contiguous subparts, but I don't remember something similar done in GOMP_target_update. And I think it is not ok to copy bytes that aren't requested to be copied. Jakub