From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 4A17D3858427 for ; Thu, 3 Nov 2022 13:39:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4A17D3858427 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667482742; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7+352d6f5ZeHILnrbelwAbyHwjhTESLXBkKaMxnVQBE=; b=Vq9bTZjPAF8S1rqa3PZ5jOpcAjZcaj1oAoOE10qXUCUXgo+2hXTrWv3WSqUGHJXTMG6iM3 NPzpgo+GdP3QB71HRMlIXWzO4S4/m7oiBnZgz4gy3p3RCZ4HNMAv2S7acaOdACOXXvPH6p z6bMz48cRSs2QvnNx/+NbD7Ue5Ig+30= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-1-2fd5Y2_1ON6hsMhU3ufesg-1; Thu, 03 Nov 2022 09:38:59 -0400 X-MC-Unique: 2fd5Y2_1ON6hsMhU3ufesg-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 593DF800B23; Thu, 3 Nov 2022 13:38:59 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.193.252]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 193694A9254; Thu, 3 Nov 2022 13:38:58 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 2A3DcuI33952107 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 3 Nov 2022 14:38:56 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 2A3DctjU3952106; Thu, 3 Nov 2022 14:38:55 +0100 Date: Thu, 3 Nov 2022 14:38:55 +0100 From: Jakub Jelinek To: Tobias Burnus Cc: gcc-patches , fortran Subject: Re: [Patch] OpenMP/Fortran: 'target update' with DT components (was: [Patch] OpenMP/Fortran: 'target update' with strides + DT components) Message-ID: Reply-To: Jakub Jelinek References: <51e764f7-635f-9754-dc4b-d2cd2b58435d@codesourcery.com> <23585d74-e7dc-10ca-97ac-124a3a513151@codesourcery.com> MIME-Version: 1.0 In-Reply-To: <23585d74-e7dc-10ca-97ac-124a3a513151@codesourcery.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Nov 03, 2022 at 02:35:03PM +0100, Tobias Burnus wrote: > On 03.11.22 13:44, Jakub Jelinek wrote: > > [...] > > Otherwise LGTM, assuming it actually works correctly. > > > > I don't remember support for non-contiguous copying to/from devices > > being actually added, [...] And I think it is not ok to copy bytes > > that aren't requested to be copied. > > I have now removed that stride support and only kept the bug fix and the > DT component parts of the patch. > > The only code change is to remove the stride check disabling in > openmp.cc and in one testcase, to remove the stride part. > > I will commit it as attached, unless there are further comments (or the > just started reg testing shows that something does not work). > > Tobias > > PS: For strides, I now filed: PR middle-end/107517 "[OpenMP][5.0] > 'target update' with strides — for C/C++ and Fortran" > https://gcc.gnu.org/PR107517 > ----------------- > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955 > OpenMP/Fortran: 'target update' with DT components > > OpenMP 5.0 permits to use arrays with derived type components for the list > items to the 'from'/'to' clauses of the 'target update' directive. > > gcc/fortran/ChangeLog: > > * openmp.cc (gfc_match_omp_clauses): Permit derived types for > the 'to' and 'from' clauses of 'target update'. > * trans-openmp.cc (gfc_trans_omp_clauses): Fixes for > derived-type changes; fix size for scalars. > > libgomp/ChangeLog: > > * testsuite/libgomp.fortran/target-11.f90: New test. > * testsuite/libgomp.fortran/target-13.f90: New test. LGTM, thanks. Jakub