From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 76AD83858C00 for ; Mon, 7 Nov 2022 12:56:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 76AD83858C00 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667825773; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=vgJFOyAGf8ha77Xc233ivUbUsU++DZsyOoL9nobEYZs=; b=fPXr1TxKWfJtqbJbqOpT2b6aW6tHCRp/Vm7BW5i6u7vwuQN+sKcAY22N5YIXTZEQrVK/SK tABi85diTTLqLLd1sB5NBHb5bc+nq4knLIisjbM/du+BGaco3DErkwZUqogZe5Gow4uEkN NqiPnSF/iJ9fHarv3N+6XOnvUPjKJTo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-114-fdPYMG_vMFWYgr6k3LjEZg-1; Mon, 07 Nov 2022 07:56:12 -0500 X-MC-Unique: fdPYMG_vMFWYgr6k3LjEZg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E9A19805AC8 for ; Mon, 7 Nov 2022 12:56:11 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.193.252]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A54A62166B29; Mon, 7 Nov 2022 12:56:11 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 2A7Cu9I9378741 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 7 Nov 2022 13:56:09 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 2A7Cu8HP378740; Mon, 7 Nov 2022 13:56:08 +0100 Date: Mon, 7 Nov 2022 13:56:08 +0100 From: Jakub Jelinek To: Aldy Hernandez Cc: "MacLeod, Andrew" , GCC patches Subject: Re: [PATCH] [PR24021] Implement PLUS_EXPR range-op entry for floats. Message-ID: Reply-To: Jakub Jelinek References: <20221013123649.474497-1-aldyh@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Nov 07, 2022 at 01:48:28PM +0100, Aldy Hernandez wrote: > On Mon, Nov 7, 2022 at 1:43 PM Jakub Jelinek wrote: > > > > On Mon, Nov 07, 2022 at 01:35:35PM +0100, Aldy Hernandez wrote: > > > Let me see if I understand you correctly... > > > > > > real_isdenormal is always returning false for our uses in frange? So > > > instead of using real_isdenormal in flush_denormals_to_zero, perhaps > > > we should be using: > > > > > > REAL_EXP (r) < REAL_MODE_FORMAT (mode)->emin > > > > > > ?? > > > > > > Could we perhaps make real_isdenormal always work for all values? Is > > > that possible? > > > > Yes. Or have real_isdenormal_target for the uses in real.cc > > which would be private to real.cc and would do what real_isdenormal > > currently does, and then real_isdenormal with the above definition > > (well, r->cl == rvc_normal && ...). > > If the REAL_EXP(r)... definition works for everyone, can't we just use > that? Or do you think there'd be a measurable performance impact? It doesn't work alone. Either denormals are in normalized form, then r->cl == rvc_normal && REAL_EXP (r) < REAL_MODE_FORMAT (mode)->emin is true, or they are in denormal form, then r->cl == rvc_normal && (r->sig[SIGSZ-1] & SIG_MSB) == 0 is true. You could use r->cl == rvc_normal && (REAL_EXP (r) < REAL_MODE_FORMAT (mode)->emin || (r->sig[SIGSZ-1] & SIG_MSB) == 0) but that would be waste of compile time both in real.cc and outside of real.cc. Jakub