From: Jakub Jelinek <jakub@redhat.com>
To: Aldy Hernandez <aldyh@redhat.com>
Cc: GCC patches <gcc-patches@gcc.gnu.org>,
Andrew MacLeod <amacleod@redhat.com>
Subject: [PATCH] testsuite: Fix up pr107541.c test
Date: Tue, 8 Nov 2022 12:50:05 +0100 [thread overview]
Message-ID: <Y2pCbby26nP6ipNf@tucnak> (raw)
In-Reply-To: <20221107114238.663927-1-aldyh@redhat.com>
On Mon, Nov 07, 2022 at 12:42:38PM +0100, Aldy Hernandez via Gcc-patches wrote:
> * gcc.dg/tree-ssa/pr107541.c: New test.
The test fails when long is 32-bit rather than 64-bit (say x86_64 with
RUNTESTFLAGS='--target_board=unix\{-m32,-m64\} tree-ssa.exp=pr107541.c'
).
I've tweaked it to use long long so it passes even on the 32-bit
targets, and added an early out for weirdo targets because I think
the test assumes the usual 1/2/4/8 bytes sizes for char/short/int/long long.
Tested on x86_64-linux, ok for trunk?
2022-11-08 Jakub Jelinek <jakub@redhat.com>
PR tree-optimization/107541
* gcc.dg/tree-ssa/pr107541.c (c): Use long long type rather than long.
(main): Punt if sizeof short isn't 2, or int 4, or long long 8.
--- gcc/testsuite/gcc.dg/tree-ssa/pr107541.c.jj 2022-11-07 15:12:24.519022064 +0100
+++ gcc/testsuite/gcc.dg/tree-ssa/pr107541.c 2022-11-08 12:45:12.926718243 +0100
@@ -3,9 +3,11 @@
unsigned char a = 1;
char b, e;
-long c;
+long long c;
short d;
int main() {
+ if (sizeof (short) != 2 || sizeof (int) != 4 || sizeof (long long) != 8)
+ return 0;
a = ~(1 && a);
c = ~((~a / 8 | -2) & 11007578330939886389LLU);
e = -c;
Jakub
next prev parent reply other threads:[~2022-11-08 11:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 11:42 [COMMITTED] [range-op] Restrict division by power of 2 optimization to positive numbers Aldy Hernandez
2022-11-08 11:50 ` Jakub Jelinek [this message]
2022-11-13 0:15 ` [PATCH] testsuite: Fix up pr107541.c test Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2pCbby26nP6ipNf@tucnak \
--to=jakub@redhat.com \
--cc=aldyh@redhat.com \
--cc=amacleod@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).