From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id BFE7E3858427 for ; Tue, 8 Nov 2022 13:15:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BFE7E3858427 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667913359; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=jLc5EcFiZNOio2/OmQc3a5xbgD2C63IlN1T4QBFjdHo=; b=IcLN6bFhFR4czFuKgjpgJCMCScahdyKn4qldk2AtlN/DN88nHS3VncaBAGJTFRVavjsbru dZIShMD0xQWgEhtjkX2uSyxnFvCXRML5bU4mF9i0iZc4+Xpn4gvI20AUOtMhRQ9Cb4IEqe kwgYaJ8WL5tZhubvn8W0aPGOgZXd4JU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-205-Uv9YYRQsPn2oCxwsw69MjQ-1; Tue, 08 Nov 2022 08:15:57 -0500 X-MC-Unique: Uv9YYRQsPn2oCxwsw69MjQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 603BD800B23 for ; Tue, 8 Nov 2022 13:15:57 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.194.183]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 20117C1908C; Tue, 8 Nov 2022 13:15:57 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 2A8DFsUc2242845 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 8 Nov 2022 14:15:54 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 2A8DFr2n2242844; Tue, 8 Nov 2022 14:15:53 +0100 Date: Tue, 8 Nov 2022 14:15:53 +0100 From: Jakub Jelinek To: Aldy Hernandez Cc: "MacLeod, Andrew" , GCC patches Subject: Re: [PATCH] [PR24021] Implement PLUS_EXPR range-op entry for floats. Message-ID: Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Nov 08, 2022 at 01:47:58PM +0100, Aldy Hernandez wrote: > On Tue, Nov 8, 2022 at 12:07 PM Jakub Jelinek wrote: > > > > On Mon, Nov 07, 2022 at 04:38:29PM +0100, Aldy Hernandez wrote: > > > From d214bcdff2cb90ad1eb808d29bda6fb98d510b4c Mon Sep 17 00:00:00 2001 > > > From: Aldy Hernandez > > > Date: Mon, 7 Nov 2022 14:18:57 +0100 > > > Subject: [PATCH] Provide normalized and denormal format version of > > > real_isdenormal. > > > > > > Implement real_isdenormal_target() to be used within real.cc where the > > > argument is known to be in denormal format. Rewrite real_isdenormal() > > > for use outside of real.cc where the argument is known to be > > > normalized. > > > > > > gcc/ChangeLog: > > > > > > * real.cc (real_isdenormal_target): New. > > > (encode_ieee_single): Use real_isdenormal_target. > > > (encode_ieee_double): Same. > > > (encode_ieee_extended): Same. > > > (encode_ieee_quad): Same. > > > (encode_ieee_half): Same. > > > (encode_arm_bfloat_half): Same. > > > * value-range.cc (frange::flush_denormals_to_zero): Same. > > > * real.h (real_isdenormal): Rewrite to look at mode. > > > > I'd make real_isdenormal_target static inline bool > > rather than inline bool, it is only defined in real.cc, so there is > > no point exporting it. > > Huh. I thought inline alone would inhibit the exporting. Thanks. That is what happens with C99 inline (unless there is extern for the decl), but C++ inline is different. It isn't guaranteed to be exported, but with -fkeep-inline-functions or if you say take address of the inline in a way that can't be optimized back into a call to the inline (or even just call it with -O0), it is exported. > > > Though, as you've added the mode argument, the real.cc inline > > could very well also be called real_isdenormal too, it wouldn't be > > a redeclaration or ODR violation. > > Great, even better. > > OK pending tests? > Aldy > From c3ca1d606bfb22bf4f8bc7ac0ce561bd6afc3368 Mon Sep 17 00:00:00 2001 > From: Aldy Hernandez > Date: Mon, 7 Nov 2022 14:18:57 +0100 > Subject: [PATCH] Provide normalized and denormal format version of > real_isdenormal. > > Implement a variant of real_isdenormal() to be used within real.cc > where the argument is known to be in denormal format. Rewrite > real_isdenormal() for use outside of real.cc where the argument is > known to be normalized. > > gcc/ChangeLog: > > * real.cc (real_isdenormal): New. > * real.h (real_isdenormal): Add mode argument. Rewrite for > normalized values. > * value-range.cc (frange::flush_denormals_to_zero): Pass mode to > real_isdenormal. > --- > gcc/real.cc | 10 ++++++++++ > gcc/real.h | 7 ++++--- > gcc/value-range.cc | 5 +++-- > 3 files changed, 17 insertions(+), 5 deletions(-) > > diff --git a/gcc/real.cc b/gcc/real.cc > index aae7c335d59..028aad95ec4 100644 > --- a/gcc/real.cc > +++ b/gcc/real.cc > @@ -111,6 +111,16 @@ static const REAL_VALUE_TYPE * real_digit (int); > static void times_pten (REAL_VALUE_TYPE *, int); > > static void round_for_format (const struct real_format *, REAL_VALUE_TYPE *); > + > +/* Determine whether a floating-point value X is a denormal. R is > + expected to be in denormal form, so this function is only > + meaningful after a call to round_for_format. */ > + > +static inline bool > +real_isdenormal (const REAL_VALUE_TYPE *r) > +{ > + return (r->sig[SIGSZ-1] & SIG_MSB) == 0; I would probably keep the r->cl == rvc_normal in here too. I know the code in real.cc didn't do it before, but what r->sig is for the rvc_zero/rvc_inf is unclear. It is true that get_zero/get_canonical_?nan/get_inf clear the whole sig, but not really sure if we guarantee that everywhere. The real.cc uses were like: bool denormal = ...; at the start of the function and then switch (...) { ... case rvc_normal: if (denormal) ... } so another even better possibility would be to use your simple real.cc (real_isdenormal) and drop all the denormal variables, so: - bool denormal = ...; switch (...) { ... case rvc_normal: - if (denormal) + if (real_isdenormal (r)) ... } Otherwise LGTM. Jakub