From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 474403858D39 for ; Wed, 9 Nov 2022 13:33:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 474403858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668000779; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=zDh3zetbMgttqfoOWeAcBi6aDXwtrdLBzt0znsN6WP8=; b=IZco5hLVRkjTmPChUKaKSfNQuyMXza6/VSPadujFNsfKdnAtLMrzfvHVzlDjxq+FXKqGau p7QORiaguo+NmsPhqvlt8hsuY+ZBWp2iaezK2W1g+x386LN+9SNmbTD6lV8Wl0rK7sEAgc MZ+/CH41blnHEcv2J5X4d0oVZcOdG9M= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-185-qQELPygdPbiY7W8zqPtWZw-1; Wed, 09 Nov 2022 08:32:58 -0500 X-MC-Unique: qQELPygdPbiY7W8zqPtWZw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5653885A59D for ; Wed, 9 Nov 2022 13:32:58 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.194.183]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 16BE52027061; Wed, 9 Nov 2022 13:32:57 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 2A9DWttV4105709 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 9 Nov 2022 14:32:55 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 2A9DWtg74105708; Wed, 9 Nov 2022 14:32:55 +0100 Date: Wed, 9 Nov 2022 14:32:54 +0100 From: Jakub Jelinek To: Aldy Hernandez Cc: GCC patches , Andrew MacLeod Subject: Re: [COMMITTED] [range-op-float] Abstract out binary operator code out of PLUS_EXPR entry. Message-ID: Reply-To: Jakub Jelinek References: <20221109070758.1030615-1-aldyh@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Nov 09, 2022 at 02:14:19PM +0100, Aldy Hernandez wrote: > On Wed, Nov 9, 2022 at 1:48 PM Jakub Jelinek wrote: > > > > On Wed, Nov 09, 2022 at 08:07:57AM +0100, Aldy Hernandez wrote: > > > The PLUS_EXPR was always meant to be a template for further > > > development, since most of the binary operators will share a similar > > > structure. This patch abstracts out the common bits into the default > > > definition for range_operator_float::fold_range() and provides an > > > rv_fold() to be implemented by the individual entries wishing to use > > > the generic folder. This is akin to what we do with fold_range() and > > > wi_fold() in the integer version of range-ops. > > > > Shouldn't foperator_mult be very similar to this (except that until > > division is done op[12]_range can't be implemented), with the exception > > that the invalid case isn't -INF + INF or INF + -INF, but > > 0 * +/-INF or +/-INF * 0? > > Multiplication and division are tricky because you have to keep track > of signs to order the resulting range. It's the most annoying pattern > we have for integers: Ah, you're right. Reminds me of check_for_binary_op_overflow for multiplication. Jakub