From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2079.outbound.protection.outlook.com [40.107.103.79]) by sourceware.org (Postfix) with ESMTPS id C71153858D28 for ; Wed, 9 Nov 2022 18:42:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C71153858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=IsveYKD2aazVSgzP/6oIBgThlKpo61CTyifSkgZnOWo14uwCXhkmR5mmo1fzvmu2Kom8r23VMiLD0oWwOxNciUq1pL7Cg13GCTMZ/PMaiNexE+CFGOvuFxZxeJ470yQb+X9ccZtAHa74LI+GCNlg6UwwlHzgKNy4v6ZI7qghk6bxq336L57GXgnK5dLMOlftLq7NFqlGhT4XRcdwQAbQHLB6BpQuoBBqIVEb+qNBGFAddz5/DPQdFOoE7CZc2NSkgW7TlVHlZI1MZGvUTxMaiN88XFC0Cb1Ux//Hh3rME1MLvJOEeKXTs1L7s4R8CUZ/IWjyb6QhW/4JsRTQpHHMxg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b24YNaJIdQqZu2GMr4qLJVmnKDE1R1+E/aSHRmzs5S0=; b=mBN/g/LjlK8yugCrlFkVJZLD18tUUmA+YDnKLDxVfTaYYaedm+855aoy8U8dEq0GOyoapIwlonxTjQuAQZEYKrQkZ/A6w+G4K+Ij59fyAjTj9erA2U9iGrl+zi6UI+isnT/0b86g444ZjpTC7/2GO+3sS1/02JOMZwDZ3fgg7FdYwOXBZJp677M4iBPAyVHWrWypWmnbqIWseYeMeinO6NLO1Lq12pXO/J4j+JyoGDPX2+42pQXtYWv77nizkLNIuC4tbySrEnlIkpqQuIZxeuJLjCo3ZqMAD+iiTcSl5mznvfH2ZSCtUC+52mxu7fMfnK8fWVilpYdJPZH6dT2ATg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b24YNaJIdQqZu2GMr4qLJVmnKDE1R1+E/aSHRmzs5S0=; b=UkNzC2zyW9gtxVP7j14cuDqGDnJPcVhKHlwo233Y/LKk9ZevFXhSPQXcZ0dWzaHbRFKudAhVb8l/pRFMC46CstI9o1LlR4kDbsOJMcI/S2LYA/PmjcCZ72MvD51rN4RTHjmV2pzVo+GSueG54PNdzu4gGEu7Gp8TkNJY2RNFUAA= Received: from AS8P250CA0002.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:330::7) by PR3PR08MB5707.eurprd08.prod.outlook.com (2603:10a6:102:8b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Wed, 9 Nov 2022 18:42:35 +0000 Received: from AM7EUR03FT019.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:330:cafe::80) by AS8P250CA0002.outlook.office365.com (2603:10a6:20b:330::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Wed, 9 Nov 2022 18:42:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT019.mail.protection.outlook.com (100.127.140.245) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Wed, 9 Nov 2022 18:42:35 +0000 Received: ("Tessian outbound 58faf9791229:v130"); Wed, 09 Nov 2022 18:42:34 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 546bd52cd513be61 X-CR-MTA-TID: 64aa7808 Received: from cab0b0b17391.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1E9475C3-1430-4965-B09D-D3204DA9BD43.1; Wed, 09 Nov 2022 18:42:28 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cab0b0b17391.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 09 Nov 2022 18:42:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nFPsZH/9ytaHGZuwVbGLEmlmtU+sUpUX7Z7k/NNqPeST/Ma76tQBXbJVuY3tjGZHY2clzOMtNqmMP5srqNg7FoIcSHruum1jq5aeMv7aA7dyMWtNr4lGj5sS9onIlUIzKHieBXSwxNCdMcz0RioWnumYriFbzujNDOPh1BqNGmnAB9bOpfLovWdOWD5uKAkwVvp2mmYcQHCpqVNw+cTOFrQc75W97YIYnmaiso/bzI2rVg5EiqLos/NH1YEcLZPRcIAvNF8V5mbpiYyG7mz7EohOMkgpJ7esbzjIz+cu2xQixW/Sq2bKzdb2J4NUxxtkNgQ1YirwE0F7xl2C5nNu6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b24YNaJIdQqZu2GMr4qLJVmnKDE1R1+E/aSHRmzs5S0=; b=DOjpN97j8axp+rykaoDg4AKxusNz7qbGv5ioInrkyAbagwM+bjajs/QH9af2A2XezS55gppKwmVuUfGvGkr1sjwjg0twRM7swRW0kz2Gd2boc6qOhOfXWvLBaVpoki06KqUDaHNXZVrUfWa2a9JYFS6suLdrb6r4YLrmlrQc9pCc+9ZUuIHjKUVe7EllNuvuWkb0M9onZGUtshWWB9pXv+gMd9+I46TSZddQ/CUbxKm9w8hbtzQLh+SnR4rULPYrIa9onJD/IrTYiBJo5rhg+VQTXnSgpm78sxEEZrjEX88t6Rs/pQGDf3Cu38zAI/WX/5ZHtt30s6bXhrsHbLSncw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b24YNaJIdQqZu2GMr4qLJVmnKDE1R1+E/aSHRmzs5S0=; b=UkNzC2zyW9gtxVP7j14cuDqGDnJPcVhKHlwo233Y/LKk9ZevFXhSPQXcZ0dWzaHbRFKudAhVb8l/pRFMC46CstI9o1LlR4kDbsOJMcI/S2LYA/PmjcCZ72MvD51rN4RTHjmV2pzVo+GSueG54PNdzu4gGEu7Gp8TkNJY2RNFUAA= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from PAXPR08MB7201.eurprd08.prod.outlook.com (2603:10a6:102:20b::17) by AS8PR08MB5941.eurprd08.prod.outlook.com (2603:10a6:20b:296::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Wed, 9 Nov 2022 18:42:27 +0000 Received: from PAXPR08MB7201.eurprd08.prod.outlook.com ([fe80::3e3f:b52b:2f6d:3667]) by PAXPR08MB7201.eurprd08.prod.outlook.com ([fe80::3e3f:b52b:2f6d:3667%9]) with mapi id 15.20.5813.012; Wed, 9 Nov 2022 18:42:26 +0000 Date: Wed, 9 Nov 2022 18:42:08 +0000 From: Alex Coplan To: Ramana Radhakrishnan Cc: gcc-patches , Richard Earnshaw Subject: Re: [Patch Arm] Fix PR 92999 Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO4P302CA0041.GBRP302.PROD.OUTLOOK.COM (2603:10a6:600:317::19) To PAXPR08MB7201.eurprd08.prod.outlook.com (2603:10a6:102:20b::17) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: PAXPR08MB7201:EE_|AS8PR08MB5941:EE_|AM7EUR03FT019:EE_|PR3PR08MB5707:EE_ X-MS-Office365-Filtering-Correlation-Id: 909c79d1-5ca9-4a0e-a5f8-08dac2822b22 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: il09B7RFDtQrPU7NBOCypv54icLqDmUNBp9/XCpASmpWNJZg4Gk8H8rIvwJV7eWdYEhh+bMVK9VTZ9xsaXRU6AJPYLxIgWNoT/GYn2St9ns28l+Jx0vcbz2q1cvYuFxiH+COWo2PXlS0dU5m5xB2VhNxfkuWUK9NPqV5BCgzrlkpFHmKdYTcpCxd2kEdNqEJfphcGd5QEsXfKhmYQDdRA39C42K0vz8JaUzn6noh+ktOZPKcOgV5tJ+4m1JAOu1P28avkwxJkm8Q/feM2BeyrucUei4aw0TcQa3ANysck83SJit7x777vWpODvRwkik9dhp0hpRDECkUgFV4oxJpnBjCtWNQTauAdSMrvLqURcf4uJp929VSfjGmavFbzNyktiZOLavJxegVO8HGFmFdY9nYRc8W+16cxu4xwwWg3YEYW5l2T58ujd3ijr6/Q0Mv1gfJaxrArcEHzgL3Z9syirTLCbRysVD0whMexZwe7a0m3GwGwTsA7WrKJ+JiGr1MFSNRqgoWxbwirvGv3EsBKrt7ouTUKsyzQcEtIMlZTrptmrXe4CHF+RNYr5MD5SWNgHlvd4cBBcWpXuivLp/KLCE0f4FW2yed/idO9+HAOEHrn5jvnml5EZnMmDitsuzA00TfO3Gc2DG9vgkuVllJNc0koUFQcTiaYKkRAe54FGSF52jjzbLu+gTi8wwMfQ1ih69HvSQP0CgXz6UPfw79Myk6bgBvqlyILn1pv+LkdKU= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7201.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(396003)(136003)(39860400002)(366004)(451199015)(66556008)(8676002)(4326008)(38100700002)(66476007)(2906002)(19627235002)(6916009)(54906003)(6486002)(5660300002)(6506007)(66946007)(44832011)(8936002)(41300700001)(316002)(6666004)(186003)(53546011)(6512007)(26005)(2616005)(478600001)(83380400001)(86362001)(84970400001)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB5941 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f4157537-940c-4570-9a9a-08dac28225dd X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oMkWc7GQe60w6y3FiVM8au9CH5RCSuI73HVSG/RKHfgyOu2ArRi14vqX7e4j47fg57WgldEG7bfPk2sEBjd62MMfgKCY5QRJuJrbzbBkZOlG2rcng7EWCpGz5wPGzyg6nZefiZ66PbsKMb2o7TpthhUVJEdLBdQ0eqIqeLwNAQ1hDTesWZVhSNKqOcDvpO88mEm7SGqK9CaNii3M66hgPB1CsgapoYuk3/8V0Lih05xDKpvsGp76nIH8vZEKlLLrJw4CW4CFnF9Nzy6lDMSYdE63Xw0hThh7Jmxc9snBuwFaljk2aXcohk8xEpK4yixhH5pZV3bre42JEUKwEyx+Bwer/4p4ln0GiVQnlGSp+La7Cp5genTfdWiE4/LWiZy1l/uYUr7mI3vm3IR7yCj1CJs6SMhMg65TPghhCCcvkykpNdrgCs5flrC7xcyGC7M/kAqJmRud0rrQwwmsGUj5hrXDn0djFZaP+2OW5yNuTziq3Dt6I9HScfg5a/V0rPRAW+THNmBMQOOsJrP0obG/ZmlODZ3lh75cHPNrBQNRfWUUcaWPiIvPHl5bznTaJ+41EsmkYsSUXYWCfycQubmNp17eT95tkwtyzPRUS8Wyfo4kjUWj59R8i3+7lEnhmtlihWlZ2QuRrYhtvdTib6ESTzci72natrAv6HdAF4g0h+Qq0C47uFkAtnz0RaUTQ6gQudXp3fig2MngZr5VmBAbJopuSoQlqm2pViGH5AO9DhLblGG8PthJceuoY9fgnlDsymhynaeNRUGoGnVaNox5buzc8A6kEX94eEYIpzoNOg8= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(346002)(376002)(39860400002)(451199015)(46966006)(36840700001)(40470700004)(82740400003)(83380400001)(356005)(81166007)(84970400001)(316002)(47076005)(40480700001)(54906003)(19627235002)(36756003)(36860700001)(6486002)(6666004)(82310400005)(86362001)(336012)(70206006)(70586007)(40460700003)(2616005)(8676002)(4326008)(2906002)(478600001)(186003)(44832011)(26005)(5660300002)(6512007)(41300700001)(6506007)(53546011)(8936002)(6862004);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 18:42:35.0949 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 909c79d1-5ca9-4a0e-a5f8-08dac2822b22 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5707 X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,KAM_NUMSUBJECT,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Ramana, On 08/11/2022 18:20, Ramana Radhakrishnan via Gcc-patches wrote: > PR92999 is a case where the VFP calling convention does not allocate > enough FP registers for a homogenous aggregate containing FP16 values. > I believe this is the complete fix but would appreciate another set of > eyes on this. > > Could I get a hand with a regression test run on an armhf environment > while I fix my environment ? I ran a bootstrap/regtest on arm-linux-gnueabihf, which ran OK (no regressions, new test passes). FWIW, I noticed some minor style issues with the patch, though: $ contrib/check_GNU_style.py Arm-Fix-PR-92999.diff === ERROR type #1: there should be exactly one space between function name and parenthesis (2 error(s)) === gcc/config/arm/arm.cc:6746:18: shift = (MAX(GET_MODE_SIZE(ag_mode), GET_MODE_SIZE(SFmode)) gcc/config/arm/arm.cc:6747:23: / GET_MODE_SIZE(SFmode)); Thanks, Alex > > gcc/ChangeLog: > > PR target/92999 > * config/arm/arm.c (aapcs_vfp_allocate_return_reg): Adjust to handle > aggregates with elements smaller than SFmode. > > gcc/testsuite/ChangeLog: > > * gcc.target/arm/pr92999.c: New test. > > > Thanks, > Ramana > > Signed-off-by: Ramana Radhakrishnan