From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id C737D3852239 for ; Thu, 24 Nov 2022 10:28:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C737D3852239 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669285731; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=EipA2nD4ndeLr6DiWNr+kRIdKPUWc0KUUUT3cj+uJxA=; b=C20FDQWtun6AId4Z+mCOyUxlTxUBSonh+yPkWM9SVGrC3Jcjf5uxiWO/9p5Yo0kynPi5fI 4Zf49BB0LNynK+O/pZUegEB+hvtOYibAso29XAEiweyS53uYS0D4huREGxdKPqugoIzC0e A9FTeH5I0bq0Ooe3dUACDqGCO0SAwSc= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-227-YwuatSL7NmGLYd9zqwmZqw-1; Thu, 24 Nov 2022 05:28:47 -0500 X-MC-Unique: YwuatSL7NmGLYd9zqwmZqw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4ADE13815D28; Thu, 24 Nov 2022 10:28:47 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.194.202]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EF5A510197; Thu, 24 Nov 2022 10:28:46 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 2AOASgLs227221 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 24 Nov 2022 11:28:42 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 2AOASfSm227220; Thu, 24 Nov 2022 11:28:41 +0100 Date: Thu, 24 Nov 2022 11:28:41 +0100 From: Jakub Jelinek To: Florian Weimer Cc: Joseph Myers , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] c: Propagate erroneous types to declaration specifiers [PR107805] Message-ID: Reply-To: Jakub Jelinek References: <87cz9fqixe.fsf@oldenburg.str.redhat.com> <5350a633-56bb-cb4e-5e93-e6dce4b92a1@codesourcery.com> <87pmdc658b.fsf@oldenburg.str.redhat.com> MIME-Version: 1.0 In-Reply-To: <87pmdc658b.fsf@oldenburg.str.redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Nov 24, 2022 at 11:01:40AM +0100, Florian Weimer via Gcc-patches wrote: > * Joseph Myers: > > > On Tue, 22 Nov 2022, Florian Weimer via Gcc-patches wrote: > > > >> Without this change, finish_declspecs cannot tell that whether there > >> was an erroneous type specified, or no type at all. This may result > >> in additional diagnostics for implicit ints, or missing diagnostics > >> for multiple types. > >> > >> PR c/107805 > >> > >> gcc/c/ > >> * c-decl.cc (declspecs_add_type): Propagate error_mark_bode > >> from type to specs. > >> > >> gcc/testsuite/ > >> * gcc.dg/pr107805-1.c: New test. > >> * gcc.dg/pr107805-1.c: Likewise. > > > > OK. > > Thanks. Permission to backport this to GCC 12 after a week or two? In this case I'd wait a month, it will take some time until possible error recovery bugs are discovered. Jakub