From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 7F1CA3947C23 for ; Tue, 15 Nov 2022 23:50:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7F1CA3947C23 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668556217; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=r3L4M23NBFKAJlSquMmg0+R9G4eaXp4jeJzsQ4gmED4=; b=bB58PPA8ZR/4qihDNdxX1M4oGijKUB03UYMeSA0OdBTAGePB843BlZceK8J8+2bKYj3SYc oGIxz7k4/OYBrSSnmi9wlsn0cGiLG6KAVhBLyYcqlq5PbnvgyKjGyrlDFTXP2n+I0/LhOJ hkr8/T0XpJ4QOWtXCtYDf0iqFyRn+a8= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-359--t0Pfj7xN4GjQpY04uP9Dg-1; Tue, 15 Nov 2022 18:50:15 -0500 X-MC-Unique: -t0Pfj7xN4GjQpY04uP9Dg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 907C92999B3F for ; Tue, 15 Nov 2022 23:50:15 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.38]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 43987112131E; Tue, 15 Nov 2022 23:50:15 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 2AFNoATZ856599 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 16 Nov 2022 00:50:11 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 2AFNoAZm855952; Wed, 16 Nov 2022 00:50:10 +0100 Date: Wed, 16 Nov 2022 00:50:10 +0100 From: Jakub Jelinek To: Jason Merrill Cc: gcc-patches@gcc.gnu.org, Marek Polacek , Jonathan Wakely Subject: Re: [PATCH] c++, v2: Implement C++23 P2647R1 - Permitting static constexpr variables in constexpr functions Message-ID: Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Nov 15, 2022 at 06:36:38PM -0500, Jason Merrill wrote: > > Here is an updated patch that passed bootstrap/regtest, the only > > change is another testcase tweak. > > > > 2022-11-13 Jakub Jelinek > > > > gcc/c-family/ > > * c-cppbuiltin.cc (c_cpp_builtins): Bump __cpp_constexpr > > value from 202207L to 202211L. > > gcc/cp/ > > * constexpr.cc (cxx_eval_constant_expression): Implement C++23 > > P2647R1 - Permitting static constexpr variables in constexpr functions. > > Allow decl_maybe_constant_var_p static or thread_local vars for > > C++23. > > This was accepted as a DR, so it shouldn't be limited to C++23 mode. > Certainly it should be allowed in C++20 mode; I don't have a strong opinion > about C++14/17. Jonathan, do you? How will a feature with feature test macro with multiple values work as DR? Or will everything but the macro be treated as a DR (so __cpp_constexpr >= 202211L only for C++23)? Because __cpp_constexpr >= 202211L is >= 202207L too and that implies P2448R2 which wasn't a DR and >= 202110L which implies P2242R3 which wasn't a DR. And C++20 added other 2 non-DR papers that bumped the value. C++17 another one. > > (potential_constant_expression_1): Likewise. > > gcc/testsuite/ > > * g++.dg/cpp23/constexpr-nonlit17.C: New test. > > * g++.dg/cpp23/feat-cxx2b.C: Adjust expected __cpp_constexpr > > value. > > * g++.dg/ext/stmtexpr19.C: Don't expect an error for C++23 or later. Jakub